From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92067A054F; Tue, 16 Mar 2021 14:39:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E154242952; Tue, 16 Mar 2021 14:39:12 +0100 (CET) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id 990A94003D for ; Tue, 16 Mar 2021 14:39:10 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 7EB62580A4D; Tue, 16 Mar 2021 09:39:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 16 Mar 2021 09:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= OhMabDnYQKJaiDJ4FnUnTROszVdCUv/1yxxOnu2bOYI=; b=tW+fWzNoNqiBabMF PLH7sJh6XDcoynm2V1d8okHZ03NBT4evg2jgLdZuVchkoADdAFHu2akVV7gmT94R r49GyDsU+xEe+LS0Lulc8DUg09zVthhIsGInogENv2/FlozxunwF0wwjcWynk6xT HVN05rAOUCxlGK8yrs/aN56jN3DVoW5r8evu2ElQ4iNtVMR7j11vlbXE5nGFPGiP ljOD1PsVDmbpKiqtnw8izwhUTE+YgfQ8ExytvRisn+NxY8vC262ChceSDmIRYJVH 76LDesIS0YCXd0+5PtNVvHXorfHSgmkJliQ1SnGgOagLiWngJOwW89hbCXyNRHmX wXgrrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=OhMabDnYQKJaiDJ4FnUnTROszVdCUv/1yxxOnu2bO YI=; b=U5zrDREMXwL8bqui4JVrCbAVKbBHBYsIGB3vr1pisExIwrQHORRNIsn8T uX0bk2zLjDZ/QxBp97jQj6p6NytwVdbpCM5rgUaKX/NXNeVXp7/PbSdZa6PHA9hq 5il7lrTJhpaCw9387lb+KUqUzCjhLFerGXND6FtzTTux2ldW92iis396+f+lHZIk 4qdWINTThMPk9DqXADQuuvWAFIlFPZ4Z5F7WsfAPeASfw2XONvYSOD7mPj2/XrMO AjTuAyvdo0e92zsrQ8TeShIrWzLLsw6eKawDhFgMAuvhXyRqqtBRlmbv9Gzsya/Q sbogN4rvRycRfkA5LjEenuiFVXyng== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefvddgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B7089108005F; Tue, 16 Mar 2021 09:39:06 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang , Andrew Rybchenko , Ferruh Yigit Cc: dev@dpdk.org, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, bruce.richardson@intel.com Date: Tue, 16 Mar 2021 14:39:05 +0100 Message-ID: <8879674.o8TafV64eK@thomas> In-Reply-To: <93fd4fce-a961-8ccf-fd32-0386461e4e99@intel.com> References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210312121223.2028029-2-qi.z.zhang@intel.com> <93fd4fce-a961-8ccf-fd32-0386461e4e99@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/03/2021 14:05, Ferruh Yigit: > On 3/12/2021 12:12 PM, Qi Zhang wrote: > > PMDs use RTE_LIBRTE__DEBUG_RX|TX as compile option to wrap > > data path debug code. As .config has been removed since the meson build, > > It is not friendly for new DPDK users to notice those debug options. > > > > The patch introduces below compile options for specific Rx/Tx data path > > debug, so PMD can choose to reuse them to avoid maintain their own. > > > > - RTE_LIBRTE_ETHDEV_DEBUG_RX > > - RTE_LIBRTE_ETHDEV_DEBUG_TX > > > > Also, all the compile options are documented on the overview page, so > > users can easily find them. English question: is "compile option" correct, or should it be "compilation option"? Cc Bruce to have a native in the discussion :) > > --- a/doc/guides/nics/overview.rst > > +++ b/doc/guides/nics/overview.rst > > @@ -32,3 +32,23 @@ More details about features can be found in :doc:`features`. > > +The ethdev layer support below compile options for debug purpose: s/support/supports/ > > + > > +- ``RTE_LIBRTE_ETHDEV_DEBUG`` (default **disabled**) > > + > > + Compile with debug code on data path. What is data path if not Rx or Tx? > > + > > +- ``RTE_LIBRTE_ETHDEV_DEBUG_RX`` (default **disabled**) > > + > > + Compile with debug code on Rx data path. > > + > > +- ``RTE_LIBRTE_ETHDEV_DEBUG_TX`` (default **disabled**) > > + > > + Compile with debug code on Tx data path. In general, I think "LIBRTE_" is redundant and useless as macro prefix. > > + > > +.. Note:: > > + > > + The lib_ethdev use above options to wrap debug code to trace invalid parameters on s/lib_ethdev/ethdev library/ > > + data path APIs, so performance downgrade is expected when enable those options. s/enable/enabling/ > > + Each PMD can decide to reuse them to wrap their own debug code in the Rx/Tx path. Oh yes it could reduce the number of options. > Overall patch looks good to me, but not sure about adding the documentation to > the NIC overview page. What do you think about moving the doc to next chapter, > under "3.1. Driver Compilation"? +1