From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 07C652951 for ; Thu, 21 Jul 2016 15:28:19 +0200 (CEST) Received: from alille-653-1-293-182.w90-1.abo.wanadoo.fr ([90.1.53.182] helo=[192.168.1.13]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bQE3x-0007c5-6Q; Thu, 21 Jul 2016 15:30:54 +0200 To: Santosh Shukla , dev@dpdk.org References: <1469101787-7186-1-git-send-email-santosh.shukla@caviumnetworks.com> Cc: thomas.monjalon@6wind.com From: Olivier Matz Message-ID: <887a9e8d-b7cf-4148-d749-5019b206405e@6wind.com> Date: Thu, 21 Jul 2016 15:28:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1469101787-7186-1-git-send-email-santosh.shukla@caviumnetworks.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] test_mempool: remove unused mp_ext var X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2016 13:28:19 -0000 Hi Santosh, On 07/21/2016 01:49 PM, Santosh Shukla wrote: > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So > removing ptr var. Now freeing mp_stack var. > > Signed-off-by: Santosh Shukla > --- > app/test/test_mempool.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c > index 46ad670..3b21cf7 100644 > --- a/app/test/test_mempool.c > +++ b/app/test/test_mempool.c > @@ -506,7 +506,6 @@ test_mempool(void) > { > struct rte_mempool *mp_cache = NULL; > struct rte_mempool *mp_nocache = NULL; > - struct rte_mempool *mp_ext = NULL; > struct rte_mempool *mp_stack = NULL; > > rte_atomic32_init(&synchro); > @@ -605,7 +604,7 @@ test_mempool(void) > err: > rte_mempool_free(mp_nocache); > rte_mempool_free(mp_cache); > - rte_mempool_free(mp_ext); > + rte_mempool_free(mp_stack); > return -1; > } > > Strange, it seems these modifications were present in latest patch from David Hunt (v6). Maybe a bad manipulation during the push? The "Fixes:" line should be added though. Acked-by: Olivier Matz