From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B7B5F1B3BA
for <dev@dpdk.org>; Thu, 4 Apr 2019 17:23:30 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 4D93F220CF;
Thu, 4 Apr 2019 11:23:30 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Thu, 04 Apr 2019 11:23:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=ybl9JTqMF3Q0E0+JmOv0+JJKHU2L1boik64GdjzNnh8=; b=PHElUuRiZ7iA
FFPh/e+27yN4GST5E7VfGkBxH1Zo/xY33DjmdjD31jKNNWDrTb6GqYrxGnIVcbtk
Fx5VWMb7E8+r9ma/jkplFkLUnUR+G7jGL2+10Y7fR3t1sJG0XVqB9E2qfVG8Uq+L
ZKAFRwwTV1RLaUd6lCI5ubCWca5C8ME=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=ybl9JTqMF3Q0E0+JmOv0+JJKHU2L1boik64GdjzNn
h8=; b=DYrmdzUxzbskAT8IPNbdfqXaLQGxyBl1z92P3mMFNWV3jqN7qZMefNNxu
YaaxKkmxp5b2W4DRAifukQd/44ge/bF+fb49bwaBmN5mc7dADCOcIgQPga4NkxFD
1roEZyRoVX+P4xJhRvIThRvM/GV3EzjlkBlv7Tjqefcjg6d/TOtFo5rs9Wd8JfpS
pkFxAR1jTmr98AdkJOmGHmTf1nTChWYaKOo542we+9KmhbZUy9NDjOldxTvp1BB7
LVS2n+9Obp0QEqQ5O0hxDovr6/Qavi+KS5+T3xYt9TIWfCdsv6TPfz9vg40aU7jh
+aoqN9S4p1d2i3S9lL71BSbwqx41w==
X-ME-Sender: <xms:cSGmXFmrC8BNUHH5X1sQKge4C8a3tIivCBKkzZl_jfI4CGu5c1WsuA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgdekjeculddtuddrgedutddrtddtmd
cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp
uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg
hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeen
ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg
hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep
mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth
gvrhfuihiivgeptd
X-ME-Proxy: <xmx:cSGmXOjKUQ7ObZLi9sXoWkfNHHbXTZm2OAgb5SE1HiV2xanoW5pJ5g>
<xmx:cSGmXDu8jkHOqUHZNp0G4cxRWCaO9_nboEOP_EFO616zADwbYnr8Uw>
<xmx:cSGmXN8JuBLIGF2Rg6FBY9D9py_CPa-28WmAKOBe9jSYyEpn-11sFw>
<xmx:ciGmXJE7CjSaHTdhFlYtxVu3BKDn9AWrMbhkeI7lS6RZQORx_1xNWQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 6CE711030F;
Thu, 4 Apr 2019 11:23:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Eads, Gage" <gage.eads@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Richardson,
Bruce" <bruce.richardson@intel.com>, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"alialnu@mellanox.com" <alialnu@mellanox.com>
Date: Thu, 04 Apr 2019 17:23:26 +0200
Message-ID: <8884422.lsyktsHzmi@xps>
In-Reply-To: <9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com>
References: <20190404130009.22042-1-thomas@monjalon.net>
<9184057F7FC11744A2107296B6B8EB1E54210E11@FMSMSX108.amr.corp.intel.com>
<9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Apr 2019 15:23:31 -0000
04/04/2019 17:13, Ferruh Yigit:
> On 4/4/2019 3:14 PM, Eads, Gage wrote:
> >> 04/04/2019 15:00, Thomas Monjalon:
> >>> When enabling pedantic compilation with
> >> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> >>> the compiler complains about non standard 128-bit integer type:
> >>>
> >>> include/rte_atomic_64.h:223:3: error:
> >>> ISO C does not support =E2=80=98__int128=E2=80=99 types [-Werror=3Dpe=
dantic]
> >>>
> >>> It must be marked as an extension of the standard C language to be
> >>> accepted in pedantic compilation.
> >>>
> >>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>
> >> Forgot one line:
> >>
> >> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
> >>
> >> Note: It seems only Ferruh can reproduce it.
> >> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
> >=20
> > With that change:
> > Acked-by: Gage Eads <gage.eads@intel.com>
> >=20
>=20
> I confirm it fixes the build issue:
>=20
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 46DF2A0679
for <public@inbox.dpdk.org>; Thu, 4 Apr 2019 17:23:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 0E84E1B3BC;
Thu, 4 Apr 2019 17:23:32 +0200 (CEST)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B7B5F1B3BA
for <dev@dpdk.org>; Thu, 4 Apr 2019 17:23:30 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 4D93F220CF;
Thu, 4 Apr 2019 11:23:30 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Thu, 04 Apr 2019 11:23:30 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=ybl9JTqMF3Q0E0+JmOv0+JJKHU2L1boik64GdjzNnh8=; b=PHElUuRiZ7iA
FFPh/e+27yN4GST5E7VfGkBxH1Zo/xY33DjmdjD31jKNNWDrTb6GqYrxGnIVcbtk
Fx5VWMb7E8+r9ma/jkplFkLUnUR+G7jGL2+10Y7fR3t1sJG0XVqB9E2qfVG8Uq+L
ZKAFRwwTV1RLaUd6lCI5ubCWca5C8ME=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=ybl9JTqMF3Q0E0+JmOv0+JJKHU2L1boik64GdjzNn
h8=; b=DYrmdzUxzbskAT8IPNbdfqXaLQGxyBl1z92P3mMFNWV3jqN7qZMefNNxu
YaaxKkmxp5b2W4DRAifukQd/44ge/bF+fb49bwaBmN5mc7dADCOcIgQPga4NkxFD
1roEZyRoVX+P4xJhRvIThRvM/GV3EzjlkBlv7Tjqefcjg6d/TOtFo5rs9Wd8JfpS
pkFxAR1jTmr98AdkJOmGHmTf1nTChWYaKOo542we+9KmhbZUy9NDjOldxTvp1BB7
LVS2n+9Obp0QEqQ5O0hxDovr6/Qavi+KS5+T3xYt9TIWfCdsv6TPfz9vg40aU7jh
+aoqN9S4p1d2i3S9lL71BSbwqx41w==
X-ME-Sender: <xms:cSGmXFmrC8BNUHH5X1sQKge4C8a3tIivCBKkzZl_jfI4CGu5c1WsuA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgdekjeculddtuddrgedutddrtddtmd
cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp
uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg
hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeen
ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg
hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep
mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth
gvrhfuihiivgeptd
X-ME-Proxy: <xmx:cSGmXOjKUQ7ObZLi9sXoWkfNHHbXTZm2OAgb5SE1HiV2xanoW5pJ5g>
<xmx:cSGmXDu8jkHOqUHZNp0G4cxRWCaO9_nboEOP_EFO616zADwbYnr8Uw>
<xmx:cSGmXN8JuBLIGF2Rg6FBY9D9py_CPa-28WmAKOBe9jSYyEpn-11sFw>
<xmx:ciGmXJE7CjSaHTdhFlYtxVu3BKDn9AWrMbhkeI7lS6RZQORx_1xNWQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 6CE711030F;
Thu, 4 Apr 2019 11:23:28 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Eads, Gage" <gage.eads@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Richardson,
Bruce" <bruce.richardson@intel.com>, "Ananyev,
Konstantin" <konstantin.ananyev@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"alialnu@mellanox.com" <alialnu@mellanox.com>
Date: Thu, 04 Apr 2019 17:23:26 +0200
Message-ID: <8884422.lsyktsHzmi@xps>
In-Reply-To: <9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com>
References: <20190404130009.22042-1-thomas@monjalon.net>
<9184057F7FC11744A2107296B6B8EB1E54210E11@FMSMSX108.amr.corp.intel.com>
<9ef6aa9a-2bf6-8eb9-b184-ce962b2355f8@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] eal/x86: fix pedantic build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190404152326.DzbLMdlULuUqQ1bi7NRdWpv9tDAlcAeTaiIELNQhHXg@z>
04/04/2019 17:13, Ferruh Yigit:
> On 4/4/2019 3:14 PM, Eads, Gage wrote:
> >> 04/04/2019 15:00, Thomas Monjalon:
> >>> When enabling pedantic compilation with
> >> CONFIG_RTE_LIBRTE_MLX5_DEBUG,
> >>> the compiler complains about non standard 128-bit integer type:
> >>>
> >>> include/rte_atomic_64.h:223:3: error:
> >>> ISO C does not support =E2=80=98__int128=E2=80=99 types [-Werror=3Dpe=
dantic]
> >>>
> >>> It must be marked as an extension of the standard C language to be
> >>> accepted in pedantic compilation.
> >>>
> >>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >>
> >> Forgot one line:
> >>
> >> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange")
> >>
> >> Note: It seems only Ferruh can reproduce it.
> >> I wonder whether the RTE_STD_C11 of the union is hiding the issue.
> >=20
> > With that change:
> > Acked-by: Gage Eads <gage.eads@intel.com>
> >=20
>=20
> I confirm it fixes the build issue:
>=20
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks