From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0046.outbound.protection.outlook.com [104.47.40.46]) by dpdk.org (Postfix) with ESMTP id 3C70A107A for ; Thu, 21 Sep 2017 14:49:58 +0200 (CEST) Received: from BN6PR03CA0081.namprd03.prod.outlook.com (10.164.122.147) by MWHPR03MB2702.namprd03.prod.outlook.com (10.168.207.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 21 Sep 2017 12:49:56 +0000 Received: from BN1BFFO11FD017.protection.gbl (2a01:111:f400:7c10::1:136) by BN6PR03CA0081.outlook.office365.com (2603:10b6:405:6f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.56.11 via Frontend Transport; Thu, 21 Sep 2017 12:49:56 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD017.mail.protection.outlook.com (10.58.144.80) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.35.14 via Frontend Transport; Thu, 21 Sep 2017 12:49:56 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8LCnsOf026293; Thu, 21 Sep 2017 05:49:54 -0700 To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-26-shreyansh.jain@nxp.com> <065975c7-b471-2994-b0fe-f17c9fa76ab5@intel.com> From: Shreyansh Jain Message-ID: <888dc27f-8240-42e1-5e29-59a9100ee379@nxp.com> Date: Thu, 21 Sep 2017 18:30:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <065975c7-b471-2994-b0fe-f17c9fa76ab5@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131504717966759213; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7966004)(336005)(346002)(39860400002)(376002)(39380400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189002)(24454002)(377454003)(199003)(50986999)(54356999)(305945005)(76176999)(6246003)(53936002)(2950100002)(6916009)(6666003)(356003)(2906002)(189998001)(230700001)(33646002)(104016004)(65826007)(5660300001)(23676002)(105606002)(106466001)(68736007)(77096006)(8656003)(83506001)(498600001)(31686004)(53546010)(50466002)(85426001)(36756003)(65956001)(65806001)(97736004)(47776003)(64126003)(58126008)(31696002)(54906003)(229853002)(8676002)(316002)(81156014)(8936002)(86362001)(4326008)(93886005)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2702; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD017; 1:AdP1dExoBJ0k80zcEfflWnppuBP1XIrrJV/8HiA5TSon/Ea51iD+j0eFAG8PgvgqRDRe85v9M3gQb1UnF7ai62ExXk6qPral3klpjbAjZvxL3xRqUpZSZAx6eyYLXj8P X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 547bd1a2-0367-430c-552d-08d500ef4329 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:MWHPR03MB2702; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 3:T8ON6ogosGbyIlXbUVJraDgvWgEJK9QwSg+O4pea6ZExh+NtbtZlgnbQyAgeRMdFFXZzd3OxVqRXBGDACIuCXe4NH9CYT1CKA2PgxhN1w994T0A+3cn3CtW2UFdSlHgR6URW50znY44iZhHsWb+g3YCkRkXwg8cOqzEilbyVYWVq4Kg1/TzxPhhfNPeIk26A9JBTxJmuWQZeXRo0olKwld/5I1YvwyslfBkKhegIBEQa3EmqiVvAYR+Y6AZhXty1BPL8+OsytTHrvqp1azZrSijGRbSA6TmbnmJN1XQkonAo9UaLZVqVcMDvl7SH/1kUJLUvqrohMq7GQtVh+Sh19cwOQ7GZZ0wxkL4F96GrHhM=; 25:0WJ2CfhLXab/xjyzgJLykC/3zqle58Msyq7IUURK6M2QiM5iZhlE0kv8nwX6QLqPI+/St7fUBfS32KaJPFk+cdIYcM7onrfrXOrMOeo+5NESHlOjHywtdhheYkNyTaoPnlox88okvtk5cNPWqh+0PqpZB/U9brMBG6wMQ8bo8piEQcn9Znw3Ni6+5+kF3pIAFcxJibkyMeBonwJBJRXHJHND4He0D/nUTmzPbnBsc7zFffCqPeACGmKohFHm+mnuGxMZW9mmiBvVikcC1qSUCqPwRxkUdBSweUjD4gZWPeMOnpO5JoqV5xGfarwEZPgaXTyTOFsrz9usuWlNgdMDdw== X-MS-TrafficTypeDiagnostic: MWHPR03MB2702: X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 31:8Hf524lRq7fokN5ACRrcTV6SR6fOoX7mrof7f0GL6jtmjrRUH1Yxi5y0Bhzqz0zQryCQzlhU2HEHNwwTkY+cqp5aQZL3SGeWiKhtXFayTHY6jUDFxMN1pddckEarzWvNVqjgjdWb6xgaCDYsl3f35+On7HbkvPWYOK59LJl3UeAFW49Vg9MoyyIGGPVamh/OeIu1LLZ/Pe6hAZxRGadrM7Cqi4C0xswlwTzgZxMReK8=; 4:H0vSjieDgYX7qFQZ8LLNTz5j5gh3k/xNgJ5WzkOtmQvSCSZNJH35s0YmKq92L2V+hPfPppBVVWYbYL5KmsLlcBUkbUPKyDGfMgyJsnxEvwWkv4Knvv6mIkOmQMKJi7YwroT9J1JxDNE58lKKBK6DeYHFUUsFzBPM2ZNdMPemTkXeushCTbxOuEBbiC+m2vL46/DzM0ggiuxvXySVIYgmJKUJu6Kkdjj6kqlaF81LTqHs0fZBCDzmkCQXjNGo0b/xA7NNlUGWL8LJuyqGsfd+R4aISs/p0WvmqOvKecPlMRM= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123556025)(20161123563025)(20161123561025)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHPR03MB2702; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHPR03MB2702; X-Forefront-PRVS: 04371797A5 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjAzTUIyNzAyOzIzOmRFcG1oN09lWDMvTzhONmsvZjB3Z3V6NDNL?= =?utf-8?B?bzl0cUZwTlhueDNTMmt6Sm41L25OT2RCV25sOGZObk5OVDkzQ0Q5eG05WnRR?= =?utf-8?B?R2JPN3NJSzdrSE9Bdk5meG5yRUJ0YkM3d3laRU1kQk9EMGlDZUxYVTBsZFNB?= =?utf-8?B?RmR0dHdMUERtMk85NCs4cUowSks2TGhlWE9vTFpXWVBmSmFyWWF4TXdpNWNH?= =?utf-8?B?YWs2eXRZZ1BoWkhpci9ZYllVZmNYWFpFMVlDYzVoRjA3U2p3STYwSEpmbk4z?= =?utf-8?B?VCt6Mm9XTGkxRFVHUituZS9wOWJWVHZqRklWUVpta3lvUktSYzlhRWdBbk1F?= =?utf-8?B?UjZoV2orb2dNNzJ1WkZjcTNhQ2dqR0lwOHFxeFk5Vk42R2xSamR2TWRDb0xz?= =?utf-8?B?dXUxVTRsN3B6cTdGWnNqRU1sVHkyTjdFVUVGUGF5T25TSDRFVGxZSWZqSkpS?= =?utf-8?B?SDhUYkNGWmZlTnVuOUpLUXp3aXdSZkFOL0gzY3Fxd1FjQUZFTWQzak83amdW?= =?utf-8?B?OWx3Qkt4RW1ERzl4a0h5bXBRVk93SSt1UjZQNTRpTlE3T05tRkZaV2Y3WHRE?= =?utf-8?B?MFpyYnJrTGxvcXQ1dE9ScS9kMjlNUmtYUHpwVzQvTkxPdllGNTBqMTNWbnkw?= =?utf-8?B?MzJsTzYyY0hlMEFRS2RYR0JDWlVsT0NJWkV0MndtMlp3Z1RnSzRtOWJlaC94?= =?utf-8?B?WTQwOXNxMjJPU01Yd210V1RnQTVmUFlwNzhlVE92cDcvWExpZklkVk1NVUph?= =?utf-8?B?T1dvcnNrNFlQKy9LNjRrWUc4amRjdXdTUGdOWVExeWxTRUgySGV3QkdJcVVy?= =?utf-8?B?N1R0akxCSTg1akNORFV1d2hwc0ZnalhQYkl5VEtjZ3BHVHViR2lES0ZubnFM?= =?utf-8?B?Mk1Ebi8zU2pBSUwvMmZnZGxId2dWbzhtcUlaYVpYZkV2YWtVMkFlU1owS1I1?= =?utf-8?B?ZWdWNE5rTnE2V3VuWEJWaUUwREhhZko3SlJTZS8zS3dsYTJySXhFMis0NkZ3?= =?utf-8?B?b0poNk1VaWJqMHVWTFB5QW1zNEZaMU9zRzk1bWF0d2V2bGgvVHEvYUhRc2Rn?= =?utf-8?B?NHBpU1hna3FLVkhiUzAzUHkrVGx1Zm9PMGV2TDJHdmpqOHQyYUZFMDlpUmZT?= =?utf-8?B?UVE3WmNhRTVNTDFyQjd3UzNqYXJ4TkRmOS90V1pTMHFqZXQ3WXRpK2ZhN0Uw?= =?utf-8?B?VHFjOHprb0RKazlFekR5WkZsbEZYK20xRkQ2T2gwalhCaEh2VXpyaWl6MWVm?= =?utf-8?B?NDdONFdFM2Z0b2F5YXRObFp0R2VQQ2ozR3EzL0ZuYTNLbGtzcXY0eGI4Y0pi?= =?utf-8?B?VTlkcDZyQkYzY040Wk1KbGVWNm92NWlZakFLSXBULzBrUERTNkRleGNiM0FI?= =?utf-8?B?OS9ydUY0ZTVoNVFNN0tDejRxYkcrVXYwSVBZRE1mcmF5ZDVmSnBhYzk1MW1I?= =?utf-8?B?RXBoSkNja1ZNdlA1RDN0Q1pSbXJiMVhzOXJTdFZDTk1pTXZpczdMazNWNlI3?= =?utf-8?B?VGtoQnpuNHBiWVJDVWVESEE0eHFlUjdXSy83OFExUGlFR3YvN3FJeHNiL3li?= =?utf-8?B?dkwzazFTcG9aclVoR1pkUE1MOVNTbENvL09vamRVSExGL09GQTNXWmFkdlRH?= =?utf-8?B?TDBUdW5lL253RlUxdk1KS0FvZndsalNHbzFtMDRxWUFmOXR5VUpkZElNQnpW?= =?utf-8?B?QkdNTW0vUHl6enBCZDhZcTRQU0JCZ0hRT2d4YmRTaWo1UzhMYzRhYTd4Vzc4?= =?utf-8?B?cVk2QTk3bmpuUGRIU2w4MXU2eWNWOHJOSFAyT05Tem9qbzh5MnlKZlRiWlhl?= =?utf-8?B?bFZWZGxqQ3NPcHZqL3loUTVVcm01anQ3OHhwTDI5UjFKNzNFUjl3TGhScGNw?= =?utf-8?B?MDVwVkhrVEFnQVlVZUtwb0JkZks2ZktYRXFjN2hocG02T09jUnpzL21ESUNL?= =?utf-8?B?YUFpS0dRdDFTRUx5c2dsZkM4NktWSmZJMVdLRm9IcmYzMlZjZ3NXYWk0RVYr?= =?utf-8?Q?5EHYa5?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2702; 6:6Hiku+pOR94Trm7PLwXUJy/agsvt6YYex7OaxKGA9YLZsl0poq/sBhet46hP9nuSxCIZSIX+Vph3Erzr4gTLT6ap0taLdcTr2KNbsiDPLC5kBWW8+FRyFNGvzAZ85WSObhkm7LOnBzmQRP3WxPh4r6f+EyT/yvWKIqanjL/lGvp0NeWOXZRghHwx+3lEGUT7Jf1vlmqDCXDPHX9ovjxEPy1dIUDadTDFOmXf70jez7idW6LmyeKvGzRur/ptmHYbQopwUhoFhWlfDPILfR6cmOPDibYVBxmbUWsoegejubSoz84eV96a5lrGKTdoGIgZaOzZ7/a5hna+6Upr5P04ZA==; 5:feOdOKUvuLgWZxf7jWzRoRpK9/JOOE1IfIMmMnm55YnjLEcJpqOEwbds0yT4xw7FUco2PdFGmJBjSz8uv3EOQwonVcQLBKLgzTCwfLHxyOBGz7nLysHAtpYQICdMQYuMQCkGceQLPmamXtCEGoab4w==; 24:Qe6BJmzp+KgTjWHbMqipEn0rixSUJ75xwOJUU28L0hWguhKKG2KxbQtgsO5D9Wsg3UNuU3sMj+slYc+GPqjiLxvDBWboZrI1z6X4p9trciw=; 7:lGUgwjONMVXiJzhN4y9WzGqrleqyGahOftJjGFoEm+NrCJOvZByr4h3Iujgjkm9rPYo8THce9zGPFX2oDNrtoK7wV4bsHc4KA/qB1hwV+cWoWr2b7TA7PhseQ72qCGUWNuhnAK4hzJBNeUuL3/E+uRaT4YxsK7DOCIjYOm84wiX6yJiQoQm29gIuDyY3NNYgelxqY5Tiz+UtslulsjmPviG6WMpqfCtPc+DOxfe4scQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2017 12:49:56.5043 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2702 Subject: Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 12:49:58 -0000 On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote: > On 9/9/2017 12:21 PM, Shreyansh Jain wrote: >> Signed-off-by: Hemant Agrawal >> Signed-off-by: Shreyansh Jain > > <...> > >> + >> +/* Handle all mbufs on an external pool (non-dpaa2) */ > > minor typo, but is intention dpaa ? Yes, this is 'dpaa'. > >> +static inline uint16_t >> +tx_on_external_pool(struct qman_fq *txq, struct rte_mbuf *mbuf, >> + struct qm_fd *fd_arr) >> +{ > > <...> > >> @@ -185,6 +185,7 @@ endif # CONFIG_RTE_LIBRTE_DPAA2_PMD >> >> ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y) >> _LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD) += -lrte_bus_dpaa >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_DPAA_PMD) += -lrte_mempool_dpaa > > This should go to patch that introduces mempool. My patch splits are not effective it seems. Third issue of incorrect introduction of patch that you have pointed out. I will fix this. > >> endif >> >> endif # !CONFIG_RTE_BUILD_SHARED_LIBS >> > >