From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 34ADE3250
 for <dev@dpdk.org>; Wed, 10 Jan 2018 10:57:22 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 10 Jan 2018 01:57:22 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,339,1511856000"; d="scan'208";a="18104454"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
 ([10.237.220.48])
 by FMSMGA003.fm.intel.com with ESMTP; 10 Jan 2018 01:57:20 -0800
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>
References: <1515140505-38655-1-git-send-email-wenzhuo.lu@intel.com>
 <1515388414-16214-1-git-send-email-wenzhuo.lu@intel.com>
 <1515388414-16214-13-git-send-email-wenzhuo.lu@intel.com>
 <229ca995-575b-21c7-cd83-4163563e7f82@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B70D0E1@shsmsx102.ccr.corp.intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <88a714b6-f780-378e-64c1-3d2f90f7413a@intel.com>
Date: Wed, 10 Jan 2018 09:57:20 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B70D0E1@shsmsx102.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v5 12/14] net/avf: enable sse vector Rx Tx
	func
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jan 2018 09:57:23 -0000

On 1/10/2018 1:38 AM, Lu, Wenzhuo wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, January 10, 2018 1:58 AM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
>> Cc: Wu, Jingjing <jingjing.wu@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v5 12/14] net/avf: enable sse vector Rx Tx
>> func
>>
>> On 1/8/2018 5:13 AM, Wenzhuo Lu wrote:
>>> From: Jingjing Wu <jingjing.wu@intel.com>
>>>
>>> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>>
>> <...>
>>
>>> @@ -31,5 +31,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) +=
>> avf_common.c
>>>  SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_ethdev.c
>>>  SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_vchnl.c
>>>  SRCS-$(CONFIG_RTE_LIBRTE_AVF_PMD) += avf_rxtx.c
>>> +SRCS-$(CONFIG_RTE_LIBRTE_AVF_INC_VECTOR) += avf_rxtx_vec_sse.c
>>
>> You may need to wrap this with an arch check to not break other
>> architecture builds.
> I think we don't need to wrap it because I remember it's said SSE is supported by default.
> For example, before support ARM64 by this patch, 
> 'b20971b6cca0d01c41ff06e161581754810bfeb7 net/ixgbe: implement vector driver for ARM'
> Ixgbe makefile just looks like this.

By default CONFIG_RTE_LIBRTE_AVF_PMD=y and CONFIG_RTE_LIBRTE_AVF_INC_VECTOR=y,
so when you compile DPDK in an arm box, won't is cause a build error?

I think either this PMD or its vector mode should be disabled for other
architecture configs, or wrap the file with architecture check.