From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E446CA0352; Tue, 8 Feb 2022 15:43:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70A67410FD; Tue, 8 Feb 2022 15:43:23 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 77DC4410FC for ; Tue, 8 Feb 2022 15:43:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644331401; x=1675867401; h=message-id:date:from:to:cc:references:subject: in-reply-to:content-transfer-encoding:mime-version; bh=BcPiF+Sh3J/5SII2cfK+8nr1ubxVJkwtZsVKKxfJk78=; b=R5hq4uR5jr3+esXR70pk2h7XegNMZMKSmUk8//1+HDPO5VCmlc7MlW5x yT40FbGXV2Fpoz3KQ0HTc3p0vCSOyKS1qS966u5YdMBF+wN+b0tIf4UEe b4RDoIfCvu6MmcrAEWvY5ZoXr7oKY8DVM9Tp21DIo/yMpIeco01//08LW kgFo100/BH4bLN4R7aLqTNzPm5hVUB/IZmLiwAxsdw4Ae152O78x3qY23 zmFWBo/Wy4nFpyuWd0Q6FCLH+A4Tn+UrIQXhlAn3w4CMgRmHXBtEPWx3l LtXo9SLdDyTe1ngyMnvuyuCjbLsL4TwO+rw6gg2A2zWFA2+tjXlOtzVLk g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="232525533" X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="232525533" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 06:43:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,352,1635231600"; d="scan'208";a="567871975" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 08 Feb 2022 06:43:19 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 06:43:19 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 06:43:19 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 06:43:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KqS2USWmabddQlVpNwOiH2QETjDBmaJPf26ul4zZTAo0gCgamw10ucKjH+y4nITrEPGuhnPA2QjCD41NIDY+xgKJI+Z2vkzjqC/KkP2dYdH+/wyAWNNwCEiQdyxr8JLCWczhz4795JbLwSzjyPojDguXxU8DY8dp/xklX4WwYEtgS2idrK9EsGGHsZYQfGqtLiFkUg6fyS81dG/quUAP+SUEhGNlmmyNvFxAkfVRaxLmaQUw/Z3otShSfv0Dz7WDeOvJfNdlB4X/K/lGVSMEEw7hLEtrHILpxlobbpHcvnsztfUCcHH9FoiUElnOp+QwD1krywN6RDl5jy3ylmuMog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LsU87LlC63fg5O+CTbYEluMkDa9GXvoiSBQKGqLvo9c=; b=CAnXYYcZv2MqRis6h+bClcqyz8AtRG+PV70vTu/DgEhYarDufYLLHgP6Qodi7Hn0cvCAVUNmiummkWuNDR/4oCLGz0DJk8RIyJIfwptCsJ72cS4mDL0Iz3bDZvYndesIMSkX1rPQ6QDh9sCLyRGM61a/mYvHDIRQnv6MGwF0zDRRpAOF8UamcFmpcNMe8xW8kL0EUFOJyhPAUFsqsexCUxxm+rf2NtrfA75eQiR/QD1wf11YkMgZU4SxP0fg8Jn8q2nnOOfuUy51182WqzlqygCgy3Yo0ZUXjehIQXnnSh8QvsdrGpWBa9UvGCZr880sBcHadNNTx4xTbF3griMafQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM4PR11MB5408.namprd11.prod.outlook.com (2603:10b6:5:397::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 14:43:16 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 14:43:16 +0000 Message-ID: <88b3c700-d5f0-1fa8-fd67-6feba4b75944@intel.com> Date: Tue, 8 Feb 2022 14:43:09 +0000 Content-Language: en-US From: Ferruh Yigit To: Jie Wang , CC: , , , , , , , , References: <20220129062434.2455711-1-jie1x.wang@intel.com> <20220208083849.510136-1-jie1x.wang@intel.com> <20220208083849.510136-2-jie1x.wang@intel.com> <907ee151-ae4d-cbab-b491-5afebb3c1871@intel.com> Subject: Re: [PATCH v4 1/6] ethdev: add L2TPv2 RSS offload type X-User: ferruhy In-Reply-To: <907ee151-ae4d-cbab-b491-5afebb3c1871@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0353.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::29) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42eb69a3-b458-4109-a7b2-08d9eb11575e X-MS-TrafficTypeDiagnostic: DM4PR11MB5408:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1303; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +dzy6ikHiq7dED0tcMAZHTdZqOaAYN7a/A2NlU/TJji3G8EsJwWo31oSmUwiKaM+zeJtxcWsLxSaghmzNFRE8tphQffBeIW3m4tLrrR6pGCCsEDQxDhRqZbStC5EJTpWEhkoID86RnRH/T1+ZKstdNNZptRC1+blgd2OlipFMcO4RDPEaCj0IG/EYi7fxUL2+6vPO59a/0Bxr0yJoi8zuUCJmL3Pu4NweKjkql5Odl7prYstSfYTZ1WKQeF0NlxfKFC7iGE+NoYYQdSJiFE3slTHAtOHnN424a03m74KhnPNDZaAzFFlpjonMtkGB5qs5Wkt/Ba8Gudvh9gk6akEtA/hDKW/7dTTSapsByH/3NrWHK70BdpHWaIc+5olBlEs2WnDmHlnOWdcRc9oTYikI9ydagRhFtZSujgyUT0Iy0/dwi7cLoJNcxqH6rqcep2/oS3wtd0I8vQ9RTNtTBUT700rioe61QOsiEipaE8CjZbCwJwK94G0WpU+m/Zqi7GIi59YTkNfV8UKgBlOpCQ4VwFf4jN0ckSZ0nHMbZk00iOfJI4l8v6ypInh+nqGwLIS31JAFt5Atq1hkuARVehPFjwLiTVm4SKr0eRKCMAPnSEmNYwcD0K4HPLGuyNCWvNP+S3ZupWHo7rPDiLv1KG8qC5/HqQFVsyIXXhoZLYplQodWT5/PNfv7tHXyidszp79P5tIn5TcsiCiZSpqH65oqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2906002)(55236004)(6506007)(6512007)(6666004)(83380400001)(53546011)(6486002)(508600001)(36756003)(4326008)(66946007)(8676002)(66556008)(66476007)(8936002)(38100700002)(5660300002)(316002)(31696002)(86362001)(82960400001)(44832011)(26005)(186003)(31686004)(2616005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWZWTlI2YzV6T0xEakh2emcvSmlvdkViTExCNDVrVzBlL3Q0TXZyU2NVV3hy?= =?utf-8?B?UlZybzU4TkNHdkhxTjJPa3l5UkZrMmJMQ3d2OVpCRjI0ZU92T0dvcHFjbzlw?= =?utf-8?B?M2JlZFFaRmRORjhweSt5VHRjNmhyU3pFbnBQaEsrMnBkR0t0cTZ4Zm56aE9O?= =?utf-8?B?MTFJTUo4UFlhd2lBMGxrZWduRXlVTFBkMnQxdHJNeGRZRXhITytraGtwTENl?= =?utf-8?B?cklGNGIrWGhra3cyU2xDYUZjcmNPR2FZeFlGTzZtd2xYY3graHlRbFpidkNP?= =?utf-8?B?UjIwcGFlZUJyM0RVZWxpQlJIVTFwS2hGRHRNb1A3QmJydTBvWlZKdUVRNVhx?= =?utf-8?B?NjJIUGRkd1N2OSttV2xEMHhDUFlZc0J0TDIvb0VFc0R5YXY5ems5a2Qxa3Iz?= =?utf-8?B?VGlIR1NsZlBxcG5jWloyU251NXRTN2hqVGVyd085b2g1SlpNU2FINDN3Vi9l?= =?utf-8?B?RU1jTGxzeXJnR2FyY3ZVRTliVjB6RW9PYXQzczljN0lIdEtlZG4vSFhEdXh1?= =?utf-8?B?SXMvOGw3WHdwWnlMK1VKQzRwM1JiQnZvbXVEbFdHL016a1ErS1l3OFdCTSts?= =?utf-8?B?TmMrUUFxTlRIRWE1UnQyaHU3ZjM4NFRYOGdGaWxzOUl6TCs0eElNWGJSYXFJ?= =?utf-8?B?bTVzRkVRU0loc1pIS1ZBK1BJcmJ6ZThjY2FMRFYxcjZXOC9TRlpzenNsVmtZ?= =?utf-8?B?UCtVQUJHVFZjV3ZJbmhhcTRMN1VyZDVXOG5IZjY5dW9ITHBVem5hK21YOWt0?= =?utf-8?B?L2pEei92WGd4NS80VUphTzBqWEJUbWVYOWFBWFkyQmhFZGI5QkkyK2thekZt?= =?utf-8?B?aWcxcjNXelBEQzloVUMreS9UYzExM0tCV2xWZHkxYWxZOUZnamFyVnIrUXl5?= =?utf-8?B?TWxMcUNjbGJGU0tpSW5wK084NDhyRGt0bmp3SHFvZnRvQklyamVudnNRM2s2?= =?utf-8?B?NTgrRk9hVVdQVUI2NHA1OVBwaThjd09tdFEvQUc0ejZvVHF2d1BkTGV1dWxx?= =?utf-8?B?djJGNGJhYlVVOHNYTlJjK2VEc2lRellmekg3S1BaQ0NEYW9kcHdDcTNsN0lB?= =?utf-8?B?OEdoZFBXa2VHa2thN1hJZjVOMlVLL213MHZJejRuUk16RVV5UVJZSG45QXZI?= =?utf-8?B?VlQ0d2FrRUpYdSsxc1N0eXQ0V1hVTlJxeGF2bTFUOEY2VElTcGNNcFlYTnJ1?= =?utf-8?B?bVRTWXc5R2dJdU16QXpqVXJBcVNWTlZiQXJHaWFrZVdSQ0tOODlTK09iTWM5?= =?utf-8?B?TzBqc3ovckt6bUMvSDZhWGljUFhudlUrbmZ0dnNxY28rSXBJWDFvT2o4QXlR?= =?utf-8?B?RGlHb1RSUVU5WCtlWmUwSFBIYVlrNU1reWtKZ0UySzdZQzZJUWNUMVRLNklr?= =?utf-8?B?UzBqc0VlaUc1ZXJkLzR4bTV4ZGpUdW5zd1BHSExxWG1DT3NtVzByTExuUHFN?= =?utf-8?B?eHEyQjB5UXBUTyt1S0pPNFB6VEdYOTNlK0s4RWN2OHNnemhUakptaDF1WmlU?= =?utf-8?B?Tzcxa0dxM0VCa2FsdC96V0x5T00xclZJVWJtcmczemlBazlLaTNwbmdsQnZs?= =?utf-8?B?ZGdBTXhSQjZNVWRpWEFXSFJiRFFXOUZzckltUFg5eUdzNlNRbjBLQWErMXFR?= =?utf-8?B?c3NFbnBvMGxRaFRONndzRDVGa04zYUlkMXErWERIcDJCbmkrNnF0dFVTLzI3?= =?utf-8?B?K3dqQVNoSjVsdnpEcnRkZUdOZUswZ20yRURFOWZSZ2dHcTJtSTRBdDcwZlFv?= =?utf-8?B?Z1ZVYnJUUkoxN2V4d2xHR054d29TK1ZzMmtTVmNyeGlDS095MTJjVVBBUWQ5?= =?utf-8?B?WHpDQk5wcWx0UjZ2NTROZndxNDVtUWVkNkRzVWFaYTBNOHNGd0dXYkdUWXQ5?= =?utf-8?B?Tk1RUjJKTkhDMzRBVENUdWVzMGxVQTduMkFkcDJKbVlDVUdHYTdCU1o2cmpp?= =?utf-8?B?OHZzbHVxaFZ5VHpNajlINUdBdUtVZ0w4RDdwY0oyZWN5bS9zSjlHckxQdDZP?= =?utf-8?B?OHNKalNCbkZGUE9mTmloYkp1ekR2SWJSQXNNVmp0Z0JQbW84WlMvLzBHd0ZJ?= =?utf-8?B?cnJGQ1Rrc1hrNjYrbHptRmw0TTNaTk1hUzdHM2p2VWlRNXlPZW1lUk5kbEt3?= =?utf-8?B?NWpJbERNWXAyMzNYNGRoT1dLRGNxVUVkSmxoSWJIWWVja0pZQWY5Q3BwUWJ1?= =?utf-8?Q?emkBtTjaL2jyvQ9D0jwpXc0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 42eb69a3-b458-4109-a7b2-08d9eb11575e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 14:43:16.5410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vy2+MNAlZNpFHI1/2mHq3MpzF6yqfggf75gwwePy3qPDZ6vxpjPLzMKs/K2lPR/9Ou5rml3WPH3P6QmNJfHt8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5408 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 1:13 PM, Ferruh Yigit wrote: > On 2/8/2022 8:38 AM, Jie Wang wrote: >> This patch defines new RSS offload type for L2TPv2, which >> is required when users want to distribute packets based on >> the L2TPv2 session ID field. >> >> Signed-off-by: Jie Wang >> --- >>   app/test-pmd/cmdline.c                 | 10 ++++++---- >>   app/test-pmd/config.c                  |  3 ++- >>   doc/guides/rel_notes/release_22_03.rst |  5 +++++ >>   lib/ethdev/rte_ethdev.h                |  6 ++++++ >>   4 files changed, 19 insertions(+), 5 deletions(-) >> >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index e626b1c7d9..d535311f21 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -2178,7 +2178,7 @@ cmd_config_rss_parsed(void *parsed_result, >>               RTE_ETH_RSS_TCP | RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | >>               RTE_ETH_RSS_L2_PAYLOAD | RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | >>               RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP | RTE_ETH_RSS_GTPU | >> -            RTE_ETH_RSS_ECPRI; >> +            RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_L2TPV2; >>       else if (!strcmp(res->value, "eth")) >>           rss_conf.rss_hf = RTE_ETH_RSS_ETH; >>       else if (!strcmp(res->value, "vlan")) >> @@ -2256,6 +2256,8 @@ cmd_config_rss_parsed(void *parsed_result, >>           rss_conf.rss_hf = (rss_hf | RTE_ETH_RSS_LEVEL_INNERMOST); >>       } else if (!strcmp(res->value, "default")) >>           use_default = 1; >> +    else if (!strcmp(res->value, "l2tpv2")) >> +        rss_conf.rss_hf = RTE_ETH_RSS_L2TPV2; I think better to keep 'default' as last check, can you please add new one above the 'default' check? >>       else if (isdigit(res->value[0]) && atoi(res->value) > 0 && >>                           atoi(res->value) < 64) >>           rss_conf.rss_hf = 1ULL << atoi(res->value); >> @@ -2314,7 +2316,7 @@ cmdline_parse_inst_t cmd_config_rss = { >>       .help_str = "port config all rss " >>           "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|" >>           "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|none|level-default|" >> -        "level-outer|level-inner|ipv4-chksum|", >> +        "level-outer|level-inner|ipv4-chksum|l2tpv2|", Can you please update - cmd_help_long_parsed() in same file - documentation, doc/guides/testpmd_app_ug/testpmd_funcs.rst >>       .tokens = { >>           (void *)&cmd_config_rss_port, >>           (void *)&cmd_config_rss_keyword, >> @@ -2429,7 +2431,7 @@ cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type = >>                    "ipv6-tcp-ex#ipv6-udp-ex#" >>                    "l3-src-only#l3-dst-only#l4-src-only#l4-dst-only#" >>                    "l2-src-only#l2-dst-only#s-vlan#c-vlan#" >> -                 "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls"); >> +                 "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls#l2tpv2"); >>   cmdline_parse_token_string_t cmd_config_rss_hash_key_value = >>       TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, NULL); >> @@ -2442,7 +2444,7 @@ cmdline_parse_inst_t cmd_config_rss_hash_key = { >>           "l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|" >>           "l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|" >>           "l2-src-only|l2-dst-only|s-vlan|c-vlan|" >> -        "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls " >> +        "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls|l2tpv2 " Same for this command >>           "", >>       .tokens = { >>           (void *)&cmd_config_rss_hash_key_port, >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >> index 1722d6c8f8..ec922bd304 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -90,7 +90,7 @@ const struct rss_type_info rss_type_table[] = { >>       { "all", RTE_ETH_RSS_ETH | RTE_ETH_RSS_VLAN | RTE_ETH_RSS_IP | RTE_ETH_RSS_TCP | >>           RTE_ETH_RSS_UDP | RTE_ETH_RSS_SCTP | RTE_ETH_RSS_L2_PAYLOAD | >>           RTE_ETH_RSS_L2TPV3 | RTE_ETH_RSS_ESP | RTE_ETH_RSS_AH | RTE_ETH_RSS_PFCP | >> -        RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_MPLS}, >> +        RTE_ETH_RSS_GTPU | RTE_ETH_RSS_ECPRI | RTE_ETH_RSS_MPLS | RTE_ETH_RSS_L2TPV2}, >>       { "none", 0 }, >>       { "eth", RTE_ETH_RSS_ETH }, >>       { "l2-src-only", RTE_ETH_RSS_L2_SRC_ONLY }, >> @@ -143,6 +143,7 @@ const struct rss_type_info rss_type_table[] = { >>       { "mpls", RTE_ETH_RSS_MPLS }, >>       { "ipv4-chksum", RTE_ETH_RSS_IPV4_CHKSUM }, >>       { "l4-chksum", RTE_ETH_RSS_L4_CHKSUM }, >> +    { "l2tpv2", RTE_ETH_RSS_L2TPV2 }, >>       { NULL, 0 }, >>   }; >> diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst >> index 33be3241b9..9a507ab9ea 100644 >> --- a/doc/guides/rel_notes/release_22_03.rst >> +++ b/doc/guides/rel_notes/release_22_03.rst >> @@ -55,6 +55,11 @@ New Features >>        Also, make sure to start the actual text at the margin. >>        ======================================================= >> +* **Added new RSS offload types for L2TPv2 in RSS flow.** >> + >> +  Added macro RTE_ETH_RSS_L2TPV2, now L2TPv2 session ID field can be used as >> +  input set for RSS. >> + >>   * **Updated Cisco enic driver.** >>     * Added rte_flow support for matching GENEVE packets. >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >> index 147cc1ced3..b7e78618c8 100644 >> --- a/lib/ethdev/rte_ethdev.h >> +++ b/lib/ethdev/rte_ethdev.h >> @@ -651,6 +651,12 @@ struct rte_eth_rss_conf { >>   #define RTE_ETH_RSS_L4_CHKSUM          RTE_BIT64(35) >>   #define ETH_RSS_L4_CHKSUM RTE_DEPRECATED(ETH_RSS_L4_CHKSUM) RTE_ETH_RSS_L4_CHKSUM >> +/* >> + * Below macro is defined for RSS offload type, it can be used to >> + * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types. >> + */ > > Why this comment is duplicated here? (There is exact same above, and it is wrong to > have it here.) > Please remove above comment too > If this is the only comment, I can remove it while merging. > >> +#define RTE_ETH_RSS_L2TPV2            RTE_BIT64(36) >> + >>   /* >>    * We use the following macros to combine with above RTE_ETH_RSS_* for >>    * more specific input set selection. These bits are defined starting >