From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 745C246BAE; Fri, 18 Jul 2025 21:27:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0912240B8F; Fri, 18 Jul 2025 21:27:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CE95C40611 for ; Fri, 18 Jul 2025 21:27:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752866863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QXOFZ8d0LP99ZdJasUYd4tGCNwHafpv1V7/l4yHXoCw=; b=NScLfeGvQvT9Kar/aTZesIvo5Y1YQgypqosgWxhybLAu/yehd/OQqwJNuHA8PVKjVQyGpU zwl1DrvZ9tJ43hsXzv/iu+QOcMUje8Gj9YUTVVtIc25b5l+yN9Rx+TjgDmtRvf76OFjkqO 5fjqMduiodm+Z5qmCTBO1zg1p3Nfs/g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-lCEAe9_tOWmRAsMol6ruPQ-1; Fri, 18 Jul 2025 15:27:41 -0400 X-MC-Unique: lCEAe9_tOWmRAsMol6ruPQ-1 X-Mimecast-MFC-AGG-ID: lCEAe9_tOWmRAsMol6ruPQ_1752866860 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a6d90929d6so1009902f8f.2 for ; Fri, 18 Jul 2025 12:27:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752866860; x=1753471660; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QXOFZ8d0LP99ZdJasUYd4tGCNwHafpv1V7/l4yHXoCw=; b=ll78MlZPUvJ7DV0ye4SNiifi5Pe94MKi8FXxNXnF324TKa8ygrJHLY8c+Wm3X78fgS 9H4B813TtkVgQ9w5gvohKsQS18UPtOoPJoVzx01shkfrPUWc7+KVnXPETVmILuzn5/HM +WSSIdGoYZa/nVul2c1hoGOPBiMQxdSr3z92YrAJNzAHDh0eXrTqXfT+gs19S33GcWQD JI7qcW0azb6/5Y0gvQiTU4GEhoxoW6oSvqEHJSniHIvxOllgERzuzQGtsqTBCdnqK6/9 tqdmjwqnDh9faeLVMPk2SIFHQp8c2j8pXSV0RR8GR74VluNlAsBuhRvQ32zgmaMss4Gr Nc1A== X-Forwarded-Encrypted: i=1; AJvYcCW3JPPL5z5j3GAGYpZwaJDPqzLXzS9fkduvtOY8sfp4aAsBMx2Q4Kt6WgGW1QifDhh+y7Q=@dpdk.org X-Gm-Message-State: AOJu0YzVt1Nu5z92/bOhibwp8HCgx9JVTiQa64f69/7wjzlrps9oMFif 28gRge1OXMGeap/fFkGGendwu83WxtpVwf6E7kC7vixf0DfOU1kqoaU+Q86bXPzaOwIVr6X6HuO mzHUY5rXeyn9n354Xp37O0RHBnOW9L+lcfn7bxnNQ8/PI X-Gm-Gg: ASbGncsdQ0UPbAO0B3ZZViEpugUGfCdc6G/EnKTXClMhv2eWeQ/fNLjzGbfcdSmu89L A2alsymbar+pRxlLV+YqF4ARjr4We7Z3taPI08jLSX1XxExWkPppP1P9UY4EwJs9JZfLdl2b4+8 9rbzbUix7YiK/dCe5VAO9m8BMb+RhjzUsP+cFBwugrfXNYzeBHZY/ZQsR0K0YuGeUvEn1Uwa56j opL/eg6JaswrV3F33mGL2kAh2Vix/HLbJ7q/sZFZjhW8Ku2wo3KK6wWNgYHha18dmc8+PHuj7yF VRz7wX5iesmYKP9i1poOUFFwonDuuSD+m+a16aEawQ== X-Received: by 2002:a05:6000:188e:b0:3a4:eed9:755d with SMTP id ffacd0b85a97d-3b60e4d2312mr10293554f8f.3.1752866860066; Fri, 18 Jul 2025 12:27:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNGGAjgQMv6CWJ1vj+WLsvsGjsde6qyTWJ8T1VNQyB5qE+57PU2empfeqtzhhkl48ksvwwiQ== X-Received: by 2002:a05:6000:188e:b0:3a4:eed9:755d with SMTP id ffacd0b85a97d-3b60e4d2312mr10293533f8f.3.1752866859578; Fri, 18 Jul 2025 12:27:39 -0700 (PDT) Received: from [192.168.0.56] ([78.16.130.126]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b61ca253e1sm2689792f8f.5.2025.07.18.12.27.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 12:27:39 -0700 (PDT) Message-ID: <88bde869-bdae-4efe-9d04-c14f3d964d08@redhat.com> Date: Fri, 18 Jul 2025 20:27:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/intel: deprecate some SSE paths To: Bruce Richardson Cc: Ciara Loftus , dev@dpdk.org References: <20250703121624.1050845-1-ciara.loftus@intel.com> <20250703143119.1140097-1-ciara.loftus@intel.com> <0c964d09-7b83-4367-b6cf-6cc05bd64967@redhat.com> <86757a63-6464-4b7b-bd0b-fdd816b40aaa@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zHb2Cya_th4JakXql6PLfxq6HGJvoVUM2mtYa4RI8RA_1752866860 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18/07/2025 17:13, Bruce Richardson wrote: > On Fri, Jul 18, 2025 at 05:05:45PM +0100, Kevin Traynor wrote: >> On 18/07/2025 16:19, Bruce Richardson wrote: >>> On Fri, Jul 18, 2025 at 04:03:17PM +0100, Kevin Traynor wrote: >>>> On 03/07/2025 15:31, Ciara Loftus wrote: >>>>> The SSE rx and tx paths will be removed from the i40e, iavf and ice >>>>> drivers in the 25.11 release. Each of these drivers have faster >>>>> vector paths (AVX2 and AVX-512) which have feature parity with the >>>>> soon to be removed SSE paths. In environments where AVX2 or AVX-512 >>>>> are not supported, the scalar path will still be used, which also has >>>>> feature parity. >>>>> >>>>> Signed-off-by: Ciara Loftus --- >>>>> doc/guides/rel_notes/deprecation.rst | 7 +++++++ 1 file changed, 7 >>>>> insertions(+) >>>>> >>>>> diff --git a/doc/guides/rel_notes/deprecation.rst >>>>> b/doc/guides/rel_notes/deprecation.rst index e2d4125308..0d020c9c1f >>>>> 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ >>>>> b/doc/guides/rel_notes/deprecation.rst @@ -80,6 +80,13 @@ Deprecation >>>>> Notices and the header struct ``rte_vxlan_gpe_hdr`` with the macro >>>>> ``RTE_ETHER_VXLAN_GPE_HLEN`` will be removed in DPDK 25.11. >>>>> >>>>> +* net/intel: drivers that have an SSE vector path alongside other >>>>> vector paths, + namely i40e, iavf and ice, will have their SSE >>>>> vector paths removed in DPDK 25.11. + Modern x86 systems all >>>>> support AVX2, if not AVX-512, so the SSE path is no longer + widely >>>>> used. This change will not result in any feature loss, as the >>>>> fallback + scalar paths which have feature parity with SSE will be >>>>> used in the cases where + the SSE paths would have been used. + * >>>>> ethdev: The flow API matching pattern structures, ``struct >>>>> rte_flow_item_*``, should start with relevant protocol header >>>>> structure from lib/net/. The individual protocol header fields and >>>>> the protocol header struct >>>> >>>> I'm not aware of anyone using hardware that old and relying on SSE, >>>> but it seems a bit short notice for a patch to remove hardware >>>> support. >>>> >>>> Would it hurt much to give it a longer deprecation so anyone who needs >>>> to prepare by upgrade, or taking 25.11 with support etc. can do that ? >>>> >>> Do we think that will make a difference? After all, dropping the SSE >>> path won't break DPDK on older hardware, it will only run a bit slower >>> using the scalar path. Beyond that, it would only affect deployments >>> with new/latest DPDK on old hardware - obviously old hardware running >>> older DPDK would be unaffected. >>> >> >> Don't disagree, and it does seem a bit of mismatch using old hw and new >> DPDK, but I needed to spend a bit of time to try and check if this would >> impact wrt systems used, compile options, product upgrade paths etc. so >> others might be in same boat. >> >> Alternatively, could put the deprecation now and revisit if anyone >> complains before 25.11. >> > Sure. Let's deprecate now and if there are any objections or we decide to > postpone the removal in 25.11 that is fine. > Sounds good. Acked-by: Kevin Traynor > /Bruce >