From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EB2DA0C46; Tue, 14 Sep 2021 13:27:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86712410E0; Tue, 14 Sep 2021 13:27:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A918A4003C for ; Tue, 14 Sep 2021 13:27:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631618840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HD87kGUfC4ommEPhPXxe8KtudatOw7aCEgjVGr12Q2A=; b=BpBiJykj9VPZHqcub+yyduQY0m2zbsbA/WU9tb4O3P4kyxY327Vb+r3zk80hRiF+Dr5wIS OzVIz7Mev8O1bu/BDEoaUYkFkpFkfmctW3J54v1Ez0Ga1purnHO/82SWtDU0vwVT/nJ864 1TtaF7M+3dQiXPmsKd/dWvCVcxib8sc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-192-6M0o2_CINDCLe8DnDUvltQ-1; Tue, 14 Sep 2021 07:27:19 -0400 X-MC-Unique: 6M0o2_CINDCLe8DnDUvltQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F377E1023F57; Tue, 14 Sep 2021 11:27:17 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D507D78433; Tue, 14 Sep 2021 11:27:16 +0000 (UTC) To: Gaoxiang Liu , chenbo.xia@intel.com Cc: dev@dpdk.org, liugaoxiang@huawei.com, stable@dpdk.org References: <20210829085047.95-1-gaoxiangliu0@163.com> <20210831143951.93-1-gaoxiangliu0@163.com> From: Maxime Coquelin Message-ID: <88c02861-d5be-a62e-7f9f-95f7895e47aa@redhat.com> Date: Tue, 14 Sep 2021 13:27:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210831143951.93-1-gaoxiangliu0@163.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] net/virtio: fix repeated memory free of vq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/31/21 4:39 PM, Gaoxiang Liu wrote: > When virtio_init_queue returns error, the memory of vq is freed. > But the value of hw->vqs[queue_idx] does not restore. > If virtio_init_queue returns error, the memory of vq is freed again > in virtio_free_queues. > > Fixes: 69c80d4ef89b ("net/virtio: allocate queue at init stage") > Cc: stable@dpdk.org > > Signed-off-by: Gaoxiang Liu > --- > > v2: > * Fix spelling warning > > v3: > * Add detailed log > > v4: > * Update the email address > --- > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > Applied to dpdk-next-virtio/main. Thanks, Maxime