[dpdk-dev] [PATCH] linux/igb_uio: add Makefile to build the kernel module

[dpdk-dev] [PATCH] linux/igb_uio: add Makefile to build the kernel module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Before building this module, the user is expected to build the
DPDK using meson build system and make sure that the required
libraries are installed in the path /usr/local

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
 linux/igb_uio/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..be39131
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,8 @@
+obj-m += igb_uio.o
+DPDK_INSTALL=/usr/local/include
+
+all:
+		make EXTRA_CFLAGS="-I $(DPDK_INSTALL)" -C /lib/modules/`uname -r`/build/ M=$(PWD)
+
+clean:
+	    make -C /lib/modules/$(shell uname -r)/build M=$(PWD) clean
-- 
2.7.4

Re: [dpdk-dev] [PATCH] linux/igb_uio: add Makefile to build the kernel module

[Ferruh Yigit]

On 10/5/2020 3:47 PM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Before building this module, the user is expected to build the
> DPDK using meson build system and make sure that the required
> libraries are installed in the path /usr/local
> 

Can you please highlight in the commit log that this is for the dpdk-kmods repo:
https://git.dpdk.org/dpdk-kmods/

> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
>   linux/igb_uio/Makefile | 8 ++++++++
>   1 file changed, 8 insertions(+)
>   create mode 100644 linux/igb_uio/Makefile
> 
> diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
> new file mode 100644
> index 0000000..be39131
> --- /dev/null
> +++ b/linux/igb_uio/Makefile
> @@ -0,0 +1,8 @@
> +obj-m += igb_uio.o

I think we can drop this from this makefile, it is in Kbuild

> +DPDK_INSTALL=/usr/local/include

Can we use "?=" assignment to accept user provided value

Also since it points the header folder, what do you think about changing the 
macro name to highlight that it is for headers folder?

> +
> +all:
> +		make EXTRA_CFLAGS="-I $(DPDK_INSTALL)" -C /lib/modules/`uname -r`/build/ M=$(PWD)

Same for the kernel path, can you make it variable to user can override?

> +
> +clean:
> +	    make -C /lib/modules/$(shell uname -r)/build M=$(PWD) clean
> 

[dpdk-dev] [PATCH v2] linux/igb_uio: add Makefile to build the kernel module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Before building this module, the user is expected to build the
DPDK using meson build system and make sure that the required
libraries are installed in the path /usr/local

The source code for igb_uio module is available in this git repository
https://git.dpdk.org/dpdk-kmods/. Once this repository is cloned, the
module can be built using this Makefile

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
 linux/igb_uio/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..fc5cefc
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,8 @@
+DPDK_HEADERS ?= /usr/local/include
+RTE_KERNELDIR ?= `uname -r`
+
+all:
+		make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C /lib/modules/$(RTE_KERNELDIR)/build/ M=$(PWD)
+
+clean:
+	    make -C /lib/modules/$(RTE_KERNELDIR)/build M=$(PWD) clean
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] linux/igb_uio: add Makefile to build the kernel module

[Ferruh Yigit]

On 10/5/2020 5:18 PM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Before building this module, the user is expected to build the
> DPDK using meson build system and make sure that the required
> libraries are installed in the path /usr/local
> 
> The source code for igb_uio module is available in this git repository
> https://git.dpdk.org/dpdk-kmods/. Once this repository is cloned, the
> module can be built using this Makefile

Can you update patch title as [DPDK-KMOD PATCH v#] to highlight the target repo 
is different?

> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
>   linux/igb_uio/Makefile | 8 ++++++++
>   1 file changed, 8 insertions(+)
>   create mode 100644 linux/igb_uio/Makefile
> 
> diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
> new file mode 100644
> index 0000000..fc5cefc
> --- /dev/null
> +++ b/linux/igb_uio/Makefile
> @@ -0,0 +1,8 @@
> +DPDK_HEADERS ?= /usr/local/include
> +RTE_KERNELDIR ?= `uname -r`

Can you please use the variable for full path, so that the user can set a custom 
path for kernel directory. Like:

RTE_KERNELDIR ?= /lib/modules/$(RTE_KERNELDIR)/build/

make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR) M=$(PWD)

> +
> +all:
> +		make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C /lib/modules/$(RTE_KERNELDIR)/build/ M=$(PWD)
> +
> +clean:
> +	    make -C /lib/modules/$(RTE_KERNELDIR)/build M=$(PWD) clean
> 

[dpdk-dev] [DPDK_KMODS v3] linux/igb_uio: add Makefile to build the kernel module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Before building this module, the user is expected to build the
DPDK using meson build system and make sure that the required
libraries are installed in the path /usr/local

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..8be32f0
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,8 @@
+DPDK_HEADERS ?= /usr/local/include
+RTE_KERNELDIR ?= /lib/modules/`uname -r`/build
+
+all:
+		make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD)
+
+clean:
+	    make -C $(RTE_KERNELDIR)/ M=$(PWD) clean
-- 
2.7.4

[dpdk-dev] [DPDK_KMODS v3] linux/igb_uio: add Makefile to build the kernel module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Before building this module, the user is expected to build the
DPDK using meson build system and make sure that the required
libraries are installed in the path /usr/local

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..8be32f0
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,8 @@
+DPDK_HEADERS ?= /usr/local/include
+RTE_KERNELDIR ?= /lib/modules/`uname -r`/build
+
+all:
+		make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD)
+
+clean:
+	    make -C $(RTE_KERNELDIR)/ M=$(PWD) clean
-- 
2.7.4

Re: [dpdk-dev] [PATCH v2] linux/igb_uio: add Makefile to build the kernel module

[Stephen Hemminger]

On Mon,  5 Oct 2020 17:18:28 +0100
Hariprasad Govindharajan <hariprasad.govindharajan@intel.com> wrote:

> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.

Why can't vfio noiommu mode be used for this OvS case?

Re: [dpdk-dev] [DPDK_KMODS v3] linux/igb_uio: add Makefile to build the kernel module

[Ferruh Yigit]

On 10/5/2020 6:57 PM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Before building this module, the user is expected to build the
> DPDK using meson build system and make sure that the required
> libraries are installed in the path /usr/local
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
> This patch will be part of dpdk-kmods repo
> https://git.dpdk.org/dpdk-kmods/
> ---
> v3:
> Edited the commit message and corrected the mistakes in the variable
> definition
> v2:
> Added more information to the commit message
> ---
>   linux/igb_uio/Makefile | 8 ++++++++
>   1 file changed, 8 insertions(+)
>   create mode 100644 linux/igb_uio/Makefile
> 
> diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
> new file mode 100644
> index 0000000..8be32f0
> --- /dev/null
> +++ b/linux/igb_uio/Makefile
> @@ -0,0 +1,8 @@
> +DPDK_HEADERS ?= /usr/local/include
> +RTE_KERNELDIR ?= /lib/modules/`uname -r`/build
> +
> +all:
> +		make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD)
> +
> +clean:
> +	    make -C $(RTE_KERNELDIR)/ M=$(PWD) clean
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [DPDK_KMODS v3] linux/igb_uio: add Makefile to build the kernel module

[Burakov, Anatoly]

On 05-Oct-20 6:57 PM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Before building this module, the user is expected to build the
> DPDK using meson build system and make sure that the required
> libraries are installed in the path /usr/local
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
> This patch will be part of dpdk-kmods repo
> https://git.dpdk.org/dpdk-kmods/
> ---
> v3:
> Edited the commit message and corrected the mistakes in the variable
> definition
> v2:
> Added more information to the commit message
> ---
>   linux/igb_uio/Makefile | 8 ++++++++
>   1 file changed, 8 insertions(+)
>   create mode 100644 linux/igb_uio/Makefile
> 
> diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
> new file mode 100644
> index 0000000..8be32f0
> --- /dev/null
> +++ b/linux/igb_uio/Makefile
> @@ -0,0 +1,8 @@
> +DPDK_HEADERS ?= /usr/local/include
> +RTE_KERNELDIR ?= /lib/modules/`uname -r`/build
> +
> +all:
> +		make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD)
> +
> +clean:
> +	    make -C $(RTE_KERNELDIR)/ M=$(PWD) clean
> 

It seems that indentation is inconsistent - tabs in "all" and spaces in 
"clean". Please enable visible whitespace in your editor :)

-- 
Thanks,
Anatoly

[dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Before building this module, the user is expected to build the
DPDK using meson build system and make sure that the required
libraries are installed in the path /usr/local

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v4:
Corrected the indentation
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..45dbe42
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,8 @@
+DPDK_HEADERS ?= /usr/local/include
+RTE_KERNELDIR ?= /lib/modules/`uname -r`/build
+
+all:
+	make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD)
+
+clean:
+	make -C $(RTE_KERNELDIR)/ M=$(PWD) clean
-- 
2.7.4

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Burakov, Anatoly]

On 08-Oct-20 10:40 AM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Before building this module, the user is expected to build the
> DPDK using meson build system and make sure that the required
> libraries are installed in the path /usr/local
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

-- 
Thanks,
Anatoly

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Ma, LihongX]

> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to igb_uio
> module inside a VM. So, this patch provides a Makefile which can be used to
> build this module and use as needed.
> 
> Before building this module, the user is expected to build the DPDK using
> meson build system and make sure that the required libraries are installed
> in the path /usr/local
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---

Tested-by: Lihong Ma<lihongx.ma@intel.com>

Regards,
Ma,lihong

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Ajit Khaparde]

On Thu, Oct 8, 2020 at 2:43 AM Burakov, Anatoly
<anatoly.burakov@intel.com> wrote:
>
> On 08-Oct-20 10:40 AM, Hariprasad Govindharajan wrote:
> > With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> > There are use cases where this module is required, for example while
> > testing the virtual ports in OvS, the virtual ports are bound to
> > igb_uio module inside a VM. So, this patch provides a Makefile
> > which can be used to build this module and use as needed.
> >
> > Before building this module, the user is expected to build the
> > DPDK using meson build system and make sure that the required
> > libraries are installed in the path /usr/local
> >
> > Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> > ---
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

>
> --
> Thanks,
> Anatoly

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Kalesh Anakkur Purayil]

Hi Thomas/Ferruh,

It looks like this patch is not yet merged to
https://git.dpdk.org/dpdk-kmods/.

This impacts the 20.11-rc1 testing which needs the igb_uio driver. Is there
any reason to not merge this?

Regards,
Kalesh

On Mon, Oct 19, 2020 at 11:38 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:

> On Thu, Oct 8, 2020 at 2:43 AM Burakov, Anatoly
> <anatoly.burakov@intel.com> wrote:
> >
> > On 08-Oct-20 10:40 AM, Hariprasad Govindharajan wrote:
> > > With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> > > There are use cases where this module is required, for example while
> > > testing the virtual ports in OvS, the virtual ports are bound to
> > > igb_uio module inside a VM. So, this patch provides a Makefile
> > > which can be used to build this module and use as needed.
> > >
> > > Before building this module, the user is expected to build the
> > > DPDK using meson build system and make sure that the required
> > > libraries are installed in the path /usr/local
> > >
> > > Signed-off-by: Hariprasad Govindharajan <
> hariprasad.govindharajan@intel.com>
> > > ---
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> >
> > --
> > Thanks,
> > Anatoly
>


-- 
Regards,
Kalesh A P

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Narcisa Ana Maria Vasile]

On Thu, Oct 08, 2020 at 10:40:08AM +0100, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Before building this module, the user is expected to build the
> DPDK using meson build system and make sure that the required
> libraries are installed in the path /usr/local
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
> This patch will be part of dpdk-kmods repo
> https://git.dpdk.org/dpdk-kmods/
> ---
Thanks for the patch!

Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>
Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Luca Boccassi]

On Thu, 2020-10-08 at 10:40 +0100, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Before building this module, the user is expected to build the
> DPDK using meson build system and make sure that the required
> libraries are installed in the path /usr/local
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
> This patch will be part of dpdk-kmods repo
> https://git.dpdk.org/dpdk-kmods/
> ---
> v4:
> Corrected the indentation
> v3:
> Edited the commit message and corrected the mistakes in the variable
> definition
> v2:
> Added more information to the commit message
> ---
>  linux/igb_uio/Makefile | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 linux/igb_uio/Makefile
> 
> diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
> new file mode 100644
> index 0000000..45dbe42
> --- /dev/null
> +++ b/linux/igb_uio/Makefile
> @@ -0,0 +1,8 @@
> +DPDK_HEADERS ?= /usr/local/include

Please don't hard-code values that are provided programmatically. Use
pkgconfing instead:

$(shell pkg-config --variable=includedir libdpdk)

> +RTE_KERNELDIR ?= /lib/modules/`uname -r`/build

This is not a dpdk specific location so it doesn't need an RTE prefix.
While there isn't a unique way of calling this, the most common name I
see being used is KSRC.

> +
> +all:
> +	make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/ M=$(PWD)
> +
> +clean:
> +	make -C $(RTE_KERNELDIR)/ M=$(PWD) clean

-- 
Kind regards,
Luca Boccassi

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

[Govindharajan, Hariprasad]

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Thursday, October 29, 2020 10:16 AM
> To: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>;
> dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to
> build the kernel module
> 
> On Thu, 2020-10-08 at 10:40 +0100, Hariprasad Govindharajan wrote:
> > With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> > There are use cases where this module is required, for example while
> > testing the virtual ports in OvS, the virtual ports are bound to
> > igb_uio module inside a VM. So, this patch provides a Makefile which
> > can be used to build this module and use as needed.
> >
> > Before building this module, the user is expected to build the DPDK
> > using meson build system and make sure that the required libraries are
> > installed in the path /usr/local
> >
> > Signed-off-by: Hariprasad Govindharajan
> > <hariprasad.govindharajan@intel.com>
> > ---
> > This patch will be part of dpdk-kmods repo
> > https://git.dpdk.org/dpdk-kmods/
> > ---
> > v4:
> > Corrected the indentation
> > v3:
> > Edited the commit message and corrected the mistakes in the variable
> > definition
> > v2:
> > Added more information to the commit message
> > ---
> >  linux/igb_uio/Makefile | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >  create mode 100644 linux/igb_uio/Makefile
> >
> > diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile new file
> > mode 100644 index 0000000..45dbe42
> > --- /dev/null
> > +++ b/linux/igb_uio/Makefile
> > @@ -0,0 +1,8 @@
> > +DPDK_HEADERS ?= /usr/local/include
> 
> Please don't hard-code values that are provided programmatically. Use
> pkgconfing instead:
> 
> $(shell pkg-config --variable=includedir libdpdk)
> 
> > +RTE_KERNELDIR ?= /lib/modules/`uname -r`/build
> 
> This is not a dpdk specific location so it doesn't need an RTE prefix.
> While there isn't a unique way of calling this, the most common name I see
> being used is KSRC.
> 
> > +
> > +all:
> > +	make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/
> M=$(PWD)
> > +
> > +clean:
> > +	make -C $(RTE_KERNELDIR)/ M=$(PWD) clean
> 
> --
> Kind regards,
> Luca Boccassi
[Govindharajan, Hariprasad] We are sending another patch by removing the DPDK dependency to build the igb_uio module

Regards,
G Hariprasad

[dpdk-dev] [DPDK_KMODS v5] linux/igb_uio: add Makefile to build the kernel module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Since there is no more dependency on DPDK headers, this module can be
built simply by running make in the source dir

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v5:
Removed the DPDK dependency
v4:
Corrected the indentation
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile  |  7 +++++++
 linux/igb_uio/igb_uio.c | 20 +++++++++++++++++++-
 2 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..09ae5d9
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,7 @@
+KSRC ?= /lib/modules/`uname -r`/build
+
+all:
+	make -C $(KSRC)/ M=$(PWD)
+
+clean:
+	make -C $(KSRC)/ M=$(PWD) clean
diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index 039f5a5..34a605b 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -15,7 +15,25 @@
 #include <linux/version.h>
 #include <linux/slab.h>
 
-#include <rte_pci_dev_features.h>
+/**
+ * These enums and MACRO definitions are copied from the
+ * file rte_pci_dev_features.h
+ */
+
+/* interrupt mode */
+
+enum rte_intr_mode {
+    RTE_INTR_MODE_NONE = 0,
+	RTE_INTR_MODE_LEGACY,
+	RTE_INTR_MODE_MSI,
+	RTE_INTR_MODE_MSIX
+};
+
+#define RTE_INTR_MODE_NONE_NAME "none"
+#define RTE_INTR_MODE_LEGACY_NAME "legacy"
+#define RTE_INTR_MODE_MSI_NAME "msi"
+#define RTE_INTR_MODE_MSIX_NAME "msix"
+
 
 #include "compat.h"
 
-- 
2.7.4

Re: [dpdk-dev] [DPDK_KMODS v5] linux/igb_uio: add Makefile to build the kernel module

[Ferruh Yigit]

On 10/29/2020 7:16 PM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Since there is no more dependency on DPDK headers, this module can be
> built simply by running make in the source dir
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>

Hi Hariprasad,

Can you please make this two patches, first one to move the enum/macro from DPDK 
to igb_uio.c to remove the dependency.

Second on is the Makefile.

<...>

> @@ -15,7 +15,25 @@
>   #include <linux/version.h>
>   #include <linux/slab.h>
>   
> -#include <rte_pci_dev_features.h>
> +/**
> + * These enums and MACRO definitions are copied from the
> + * file rte_pci_dev_features.h
> + */
> +
> +/* interrupt mode */
> +
> +enum rte_intr_mode {
> +    RTE_INTR_MODE_NONE = 0,
> +	RTE_INTR_MODE_LEGACY,
> +	RTE_INTR_MODE_MSI,
> +	RTE_INTR_MODE_MSIX
> +};

Can you please fix the indentation?

> +
> +#define RTE_INTR_MODE_NONE_NAME "none"
> +#define RTE_INTR_MODE_LEGACY_NAME "legacy"
> +#define RTE_INTR_MODE_MSI_NAME "msi"
> +#define RTE_INTR_MODE_MSIX_NAME "msix"
> +
>   
>   #include "compat.h"
>   
> 

[dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Hariprasad Govindharajan]

The igb_uio source code requires interrupt modes defined as
MACROS and enums in the header file rte_pci_dev_features.h.
Now, the definitions are moved to the igb_uio.c file so that
this module can be built without building DPDK

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
 linux/igb_uio/igb_uio.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index 039f5a5..84c3071 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -15,7 +15,25 @@
 #include <linux/version.h>
 #include <linux/slab.h>
 
-#include <rte_pci_dev_features.h>
+/**
+ * These enums and MACRO definitions are copied from the
+ * file rte_pci_dev_features.h
+ */
+
+/* interrupt mode */
+
+enum rte_intr_mode {
+	RTE_INTR_MODE_NONE = 0,
+	RTE_INTR_MODE_LEGACY,
+	RTE_INTR_MODE_MSI,
+	RTE_INTR_MODE_MSIX
+};
+
+#define RTE_INTR_MODE_NONE_NAME "none"
+#define RTE_INTR_MODE_LEGACY_NAME "legacy"
+#define RTE_INTR_MODE_MSI_NAME "msi"
+#define RTE_INTR_MODE_MSIX_NAME "msix"
+
 
 #include "compat.h"
 
-- 
2.7.4

[dpdk-dev] [prefix=DPDK_KMODS v6 2/2] linux/igb_uio: add Makefile to build the igb_uio module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
There are use cases where this module is required, for example while
testing the virtual ports in OvS, the virtual ports are bound to
igb_uio module inside a VM. So, this patch provides a Makefile
which can be used to build this module and use as needed.

Since there is no more dependency on DPDK headers, this module can be
built simply by running make in the source dir

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v6:
split the patch into two patches to create a patchset
v5:
Removed the DPDK dependency
v4:
Corrected the indentation
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..09ae5d9
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,7 @@
+KSRC ?= /lib/modules/`uname -r`/build
+
+all:
+	make -C $(KSRC)/ M=$(PWD)
+
+clean:
+	make -C $(KSRC)/ M=$(PWD) clean
-- 
2.7.4

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Ferruh Yigit]

On 10/29/2020 8:10 PM, Hariprasad Govindharajan wrote:
> The igb_uio source code requires interrupt modes defined as
> MACROS and enums in the header file rte_pci_dev_features.h.
> Now, the definitions are moved to the igb_uio.c file so that
> this module can be built without building DPDK
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 2/2] linux/igb_uio: add Makefile to build the igb_uio module

[Ferruh Yigit]

On 10/29/2020 8:10 PM, Hariprasad Govindharajan wrote:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Since there is no more dependency on DPDK headers, this module can be
> built simply by running make in the source dir
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [DPDK_KMODS v5] linux/igb_uio: add Makefile to build the kernel module

[Thomas Monjalon]

29/10/2020 20:16, Hariprasad Govindharajan:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.
> 
> Since there is no more dependency on DPDK headers, this module can be
> built simply by running make in the source dir
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
> This patch will be part of dpdk-kmods repo
> https://git.dpdk.org/dpdk-kmods/
> ---
> v5:
> Removed the DPDK dependency

I prefer this approach, thanks.

[...]
> -#include <rte_pci_dev_features.h>
> +/**
> + * These enums and MACRO definitions are copied from the
> + * file rte_pci_dev_features.h
> + */
> +
> +/* interrupt mode */
> +
> +enum rte_intr_mode {
> +    RTE_INTR_MODE_NONE = 0,
> +	RTE_INTR_MODE_LEGACY,
> +	RTE_INTR_MODE_MSI,
> +	RTE_INTR_MODE_MSIX
> +};
> +
> +#define RTE_INTR_MODE_NONE_NAME "none"
> +#define RTE_INTR_MODE_LEGACY_NAME "legacy"
> +#define RTE_INTR_MODE_MSI_NAME "msi"
> +#define RTE_INTR_MODE_MSIX_NAME "msix"

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Thomas Monjalon]

29/10/2020 21:10, Hariprasad Govindharajan:
> The igb_uio source code requires interrupt modes defined as
> MACROS and enums in the header file rte_pci_dev_features.h.
> Now, the definitions are moved to the igb_uio.c file so that
> this module can be built without building DPDK
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
>  linux/igb_uio/igb_uio.c | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
> 
> diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
> index 039f5a5..84c3071 100644
> --- a/linux/igb_uio/igb_uio.c
> +++ b/linux/igb_uio/igb_uio.c
> @@ -15,7 +15,25 @@
>  #include <linux/version.h>
>  #include <linux/slab.h>
>  
> -#include <rte_pci_dev_features.h>
> +/**
> + * These enums and MACRO definitions are copied from the

s/These/This/
s/MACRO/macro/

> + * file rte_pci_dev_features.h
> + */
> +
> +/* interrupt mode */

Useless comment, creating a barrier between previous comment
and definitions. Please remove.

> +
> +enum rte_intr_mode {
> +	RTE_INTR_MODE_NONE = 0,
> +	RTE_INTR_MODE_LEGACY,
> +	RTE_INTR_MODE_MSI,
> +	RTE_INTR_MODE_MSIX
> +};
> +
> +#define RTE_INTR_MODE_NONE_NAME "none"
> +#define RTE_INTR_MODE_LEGACY_NAME "legacy"
> +#define RTE_INTR_MODE_MSI_NAME "msi"
> +#define RTE_INTR_MODE_MSIX_NAME "msix"

I would remove the above blank lines to make clear what is from rte_pci_dev_features.h.

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 2/2] linux/igb_uio: add Makefile to build the igb_uio module

[Thomas Monjalon]

29/10/2020 21:10, Hariprasad Govindharajan:
> With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> There are use cases where this module is required, for example while
> testing the virtual ports in OvS, the virtual ports are bound to
> igb_uio module inside a VM. So, this patch provides a Makefile
> which can be used to build this module and use as needed.

Please don't justify the use of igb_uio here.
(and I think it's wrong, you can always use VFIO except on very old kernels)

> Since there is no more dependency on DPDK headers, this module can be
> built simply by running make in the source dir

No need to talk about the old dependency here.

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[David Marchand]

On Thu, Oct 29, 2020 at 9:11 PM Hariprasad Govindharajan
<hariprasad.govindharajan@intel.com> wrote:
>
> The igb_uio source code requires interrupt modes defined as
> MACROS and enums in the header file rte_pci_dev_features.h.
> Now, the definitions are moved to the igb_uio.c file so that
> this module can be built without building DPDK
>
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>

Could we agree on a prefix for dpdk kmods patches?

Something like:
$ git format-patch --subject-prefix 'PATCH dpdk-kmods' ?

This is for my mail filters O:-).
Thanks.


-- 
David Marchand

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Thomas Monjalon]

29/10/2020 22:28, David Marchand:
> On Thu, Oct 29, 2020 at 9:11 PM Hariprasad Govindharajan
> <hariprasad.govindharajan@intel.com> wrote:
> >
> > The igb_uio source code requires interrupt modes defined as
> > MACROS and enums in the header file rte_pci_dev_features.h.
> > Now, the definitions are moved to the igb_uio.c file so that
> > this module can be built without building DPDK
> >
> > Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> 
> Could we agree on a prefix for dpdk kmods patches?
> 
> Something like:
> $ git format-patch --subject-prefix 'PATCH dpdk-kmods' ?

I agree with this syntax.
We can document it but I am afraid it will be hard
to make sure contributors use it.

[dpdk-dev] [PATCH DPDK_KMODS v7 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Hariprasad Govindharajan]

The igb_uio source code requires interrupt modes defined as
MACROS and enums in the header file rte_pci_dev_features.h.
Now, the definitions are moved to the igb_uio.c file so that
this module can be built without building DPDK

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
 linux/igb_uio/igb_uio.c | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index 3cf394b..7ef8170 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -15,7 +15,21 @@
 #include <linux/version.h>
 #include <linux/slab.h>
 
-#include <rte_pci_dev_features.h>
+/**
+ * This enums and macro definitions are copied from the
+ * file rte_pci_dev_features.h
+ */
+enum rte_intr_mode {
+	RTE_INTR_MODE_NONE = 0,
+	RTE_INTR_MODE_LEGACY,
+	RTE_INTR_MODE_MSI,
+	RTE_INTR_MODE_MSIX
+};
+#define RTE_INTR_MODE_NONE_NAME "none"
+#define RTE_INTR_MODE_LEGACY_NAME "legacy"
+#define RTE_INTR_MODE_MSI_NAME "msi"
+#define RTE_INTR_MODE_MSIX_NAME "msix"
+
 
 #include "compat.h"
 
@@ -236,7 +250,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)
 		}
 #endif
 
-	/* fall back to MSI */
+	/* falls through - to MSI */
 	case RTE_INTR_MODE_MSI:
 #ifndef HAVE_ALLOC_IRQ_VECTORS
 		if (pci_enable_msi(udev->pdev) == 0) {
@@ -255,7 +269,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)
 			break;
 		}
 #endif
-	/* fall back to INTX */
+	/* falls through - to INTX */
 	case RTE_INTR_MODE_LEGACY:
 		if (pci_intx_mask_supported(udev->pdev)) {
 			dev_dbg(&udev->pdev->dev, "using INTX");
@@ -265,7 +279,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)
 			break;
 		}
 		dev_notice(&udev->pdev->dev, "PCI INTX mask not supported\n");
-	/* fall back to no IRQ */
+	/* falls through - to no IRQ */
 	case RTE_INTR_MODE_NONE:
 		udev->mode = RTE_INTR_MODE_NONE;
 		udev->info.irq = UIO_IRQ_NONE;
-- 
2.7.4

[dpdk-dev] [PATCH DPDK_KMODS v7 2/2] linux/igb_uio: add Makefile to build the igb_uio module

[Hariprasad Govindharajan]

With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
This patch provides a Makefile to the user, who can build this module
when required by running make inside the source dir.

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v7:
Changed the commit message based on the reviews
v6:
split the patch into two patches to create a patchset
v5:
Removed the DPDK dependency
v4:
Corrected the indentation
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..09ae5d9
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,7 @@
+KSRC ?= /lib/modules/`uname -r`/build
+
+all:
+	make -C $(KSRC)/ M=$(PWD)
+
+clean:
+	make -C $(KSRC)/ M=$(PWD) clean
-- 
2.7.4

Re: [dpdk-dev] [PATCH DPDK_KMODS v7 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Ferruh Yigit]

On 10/29/2020 11:17 PM, Hariprasad Govindharajan wrote:
> The igb_uio source code requires interrupt modes defined as
> MACROS and enums in the header file rte_pci_dev_features.h.
> Now, the definitions are moved to the igb_uio.c file so that
> this module can be built without building DPDK
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> ---
>   linux/igb_uio/igb_uio.c | 22 ++++++++++++++++++----
>   1 file changed, 18 insertions(+), 4 deletions(-)
> 
> diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
> index 3cf394b..7ef8170 100644
> --- a/linux/igb_uio/igb_uio.c
> +++ b/linux/igb_uio/igb_uio.c
> @@ -15,7 +15,21 @@
>   #include <linux/version.h>
>   #include <linux/slab.h>
>   
> -#include <rte_pci_dev_features.h>
> +/**
> + * This enums and macro definitions are copied from the
> + * file rte_pci_dev_features.h
> + */
> +enum rte_intr_mode {
> +	RTE_INTR_MODE_NONE = 0,
> +	RTE_INTR_MODE_LEGACY,
> +	RTE_INTR_MODE_MSI,
> +	RTE_INTR_MODE_MSIX
> +};
> +#define RTE_INTR_MODE_NONE_NAME "none"
> +#define RTE_INTR_MODE_LEGACY_NAME "legacy"
> +#define RTE_INTR_MODE_MSI_NAME "msi"
> +#define RTE_INTR_MODE_MSIX_NAME "msix"
> +
>   
>   #include "compat.h"
>   
> @@ -236,7 +250,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev)
>   		}
>   #endif
>   
> -	/* fall back to MSI */
> +	/* falls through - to MSI */

Patch looks good, but above change is unrelated, let's not mix them, can you 
make a new version without these corrections?

Re: [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Thomas Monjalon]

29/10/2020 22:14, Thomas Monjalon:
> 29/10/2020 21:10, Hariprasad Govindharajan:
> > + * These enums and MACRO definitions are copied from the
> 
> s/These/This/
> s/MACRO/macro/

Sorry, after a second read in your last version,
I think "These" was good because we have enum and macros.
But maybe "enums" should be "enum" because there is only one.

[dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Hariprasad Govindharajan]

The igb_uio source code requires interrupt modes defined as
macros and enums in the header file rte_pci_dev_features.h.
Now, the definitions are moved to the igb_uio.c file so that
this module can be built without building DPDK

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
 linux/igb_uio/igb_uio.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c
index 3cf394b..fe7039c 100644
--- a/linux/igb_uio/igb_uio.c
+++ b/linux/igb_uio/igb_uio.c
@@ -15,7 +15,21 @@
 #include <linux/version.h>
 #include <linux/slab.h>
 
-#include <rte_pci_dev_features.h>
+/**
+ * These enum and macro definitions are copied from the
+ * file rte_pci_dev_features.h
+ */
+enum rte_intr_mode {
+	RTE_INTR_MODE_NONE = 0,
+	RTE_INTR_MODE_LEGACY,
+	RTE_INTR_MODE_MSI,
+	RTE_INTR_MODE_MSIX
+};
+#define RTE_INTR_MODE_NONE_NAME "none"
+#define RTE_INTR_MODE_LEGACY_NAME "legacy"
+#define RTE_INTR_MODE_MSI_NAME "msi"
+#define RTE_INTR_MODE_MSIX_NAME "msix"
+
 
 #include "compat.h"
 
-- 
2.7.4

[dpdk-dev] [PATCH dpdk-kmods v8 2/2] linux/igb_uio: add Makefile to build the igb_uio module

[Hariprasad Govindharajan]

This patch provides a Makefile to the user, to build the igb_uio module
when required by running make inside the source directory

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
This patch will be part of dpdk-kmods repo
https://git.dpdk.org/dpdk-kmods/
---
v8:
Changed the commit message based on the reviews and
minor changes to the comments section
v7:
Changed the commit message based on the reviews
v6:
split the patch into two patches to create a patchset
v5:
Removed the DPDK dependency
v4:
Corrected the indentation
v3:
Edited the commit message and corrected the mistakes in the variable
definition
v2:
Added more information to the commit message
---
 linux/igb_uio/Makefile | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 linux/igb_uio/Makefile

diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile
new file mode 100644
index 0000000..09ae5d9
--- /dev/null
+++ b/linux/igb_uio/Makefile
@@ -0,0 +1,7 @@
+KSRC ?= /lib/modules/`uname -r`/build
+
+all:
+	make -C $(KSRC)/ M=$(PWD)
+
+clean:
+	make -C $(KSRC)/ M=$(PWD) clean
-- 
2.7.4

Re: [dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Ferruh Yigit]

On 10/30/2020 10:52 AM, Hariprasad Govindharajan wrote:
> The igb_uio source code requires interrupt modes defined as
> macros and enums in the header file rte_pci_dev_features.h.
> Now, the definitions are moved to the igb_uio.c file so that
> this module can be built without building DPDK
> 
> Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>

For series,
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio

[Thomas Monjalon]

30/10/2020 12:03, Ferruh Yigit:
> On 10/30/2020 10:52 AM, Hariprasad Govindharajan wrote:
> > The igb_uio source code requires interrupt modes defined as
> > macros and enums in the header file rte_pci_dev_features.h.
> > Now, the definitions are moved to the igb_uio.c file so that
> > this module can be built without building DPDK
> > 
> > Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
> 
> For series,
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

Now we can remove the file
lib/librte_eal/include/rte_pci_dev_features.h
which was used only by igb_uio.

Candidate for the patch?