From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4843A04FF; Tue, 24 May 2022 08:46:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E2B24014F; Tue, 24 May 2022 08:46:39 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id EEC38400D6 for ; Tue, 24 May 2022 08:46:37 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6DA0292; Tue, 24 May 2022 09:46:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6DA0292 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1653374797; bh=Po77BSw8bYfvrTHYy1e6OesVr12G4/5D6D1ws9EF0F0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dlqJbHF1kOM8enYs59pdazuDCNoKdR4IrHsyW4yGb5gpXhk1dC9+h7UAo1V36iGQZ mZ3GBO+taCoFmO8Tp3Fq7XVubi2MPvaRsKPHLw/DIDyocmESrSFBTNAs7g3nQXBFTB CkEaIVxHYumRM7KKFOGJbS9UFTiHI9qlpPvsgWm4= Message-ID: <891f25c7-4145-9d34-7af3-bae8451cb5a5@oktetlabs.ru> Date: Tue, 24 May 2022 09:46:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Content-Language: en-US To: Pankaj Gupta , Jochen Behrens Cc: "dev@dpdk.org" References: <20220503042257.15626-1-pagupta@vmware.com> <20220519080415.1577680-1-andrew.rybchenko@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Pankai, I'd consider a patch which adds RETA controls as well. IMHO it is a major feature which could be interesting to end users. Regards, Andrew. On 5/23/22 23:56, Pankaj Gupta wrote: > Hi Andrew, > > New features were introduced in following two patches so I will update > release_22_07.rst for these two patches. > > [PATCH v6 1/9] net/vmxnet3: add version 5 support > > [PATCH v6 6/9] net/vmxnet3: add version 6 support > > Let me know if I am missing anything. > > Thanks, > > Pankaj > > *From: *Andrew Rybchenko > *Date: *Thursday, May 19, 2022 at 1:07 AM > *To: *Pankaj Gupta , Jochen Behrens > > *Cc: *dev@dpdk.org > *Subject: *Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 > > ⚠External Email > > Hi Pankaj, > > I did final cleanup before applying the patch series, but > realized that release notes update is missing. > Please, pick up my changes and amend patches which support > new features with release notes update in the documentation. > > Everything else LGTM now. > > Thanks, > Andrew. > > On 5/19/22 11:04, Andrew Rybchenko wrote: >> v6 (Andrew Rybchenko): >>      Minor style changes in patches description >>      Split FW version get patch to have callbacks reorder seperately >>      Minor fix in FW version get patch to put callback definition, >>      assignment and implementation just after device info get >> >> v5: >>      Use RTE_MIN instead of defining MIN in drivers/net/vmxnet3/vmxnet3_ethdev.c >>      User RETA instead of reta in commit message >>      Fix the issue thrown by checkpatches.sh in file drivers/net/vmxnet3/vmxnet3_ethdev.c >> >> v4: >>      Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error >>      in initialization for rxDataRing feature" to >>      "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" >> >> v3: >>      adding Reviewed-by info in all the patches >> >> v2: >>      address review comments from Andrew Rybchenko andrew.rybchenko@oktetlabs.ru >> >> Pankaj Gupta (9): >>    net/vmxnet3: add version 5 support >>    net/vmxnet3: implement RETA query and RETA update >>    net/vmxnet3: add Rx queue usage count utility >>    net/vmxnet3: fix ethdev callbacks init order >>    net/vmxnet3: report HW version on FW version get >>    net/vmxnet3: add version 6 support >>    net/vmxnet3: advertise RETA size in device info >>    net/vmxnet3: set packet type for fragmented packet >>    net/vmxnet3: fix merge error in Rx data ring initialization >> >>   drivers/net/vmxnet3/base/vmxnet3_defs.h |  73 ++++- >>   drivers/net/vmxnet3/vmxnet3_ethdev.c    | 339 +++++++++++++++++++----- >>   drivers/net/vmxnet3/vmxnet3_ethdev.h    |  15 +- >>   drivers/net/vmxnet3/vmxnet3_rxtx.c      |  49 +++- >>   4 files changed, 388 insertions(+), 88 deletions(-) >> > > > ________________________________ > > ⚠External Email: This email originated from outside of the organization. > Do not click links or open attachments unless you recognize the sender. >