From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57BCEA0A05; Wed, 20 Jan 2021 16:29:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17C7C140DA1; Wed, 20 Jan 2021 16:29:15 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 15673140D98; Wed, 20 Jan 2021 16:29:12 +0100 (CET) IronPort-SDR: qxVfN++2JO3IO1NPAFg8VRAwn6u2NLQh1Ecxxi/bXRkD343J6Q4Xw5bH8F48j9QhYhgJCqap1w VqdRfsYgSilw== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="197850666" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="197850666" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 07:29:12 -0800 IronPort-SDR: 7v1WFZfffkdk0aKQp9u20H3h58EDBs0jauvBW3yxqFwouvHA1ilE/Gy1pzG1lEl5aPeobPSU6P aStVAudgxRgg== X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="356082048" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.196.25]) ([10.213.196.25]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 07:29:11 -0800 To: "Burakov, Anatoly" , Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org References: <20210108143048.23755-2-david.hunt@intel.com> <20210120135556.33763-1-david.hunt@intel.com> <20210120135556.33763-6-david.hunt@intel.com> <3f6ec5a3-74d5-c2da-3838-31427930088d@intel.com> <20210120150812.GF1406@bricha3-MOBL.ger.corp.intel.com> <67e229ae-4596-3c7d-793f-aa910c527cf1@intel.com> From: David Hunt Message-ID: <891f9158-3b7e-bff1-552f-06f85e0c06a8@intel.com> Date: Wed, 20 Jan 2021 15:29:09 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <67e229ae-4596-3c7d-793f-aa910c527cf1@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v3 5/6] power: add new header file to export list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 20/1/2021 3:18 PM, Burakov, Anatoly wrote: > On 20-Jan-21 3:08 PM, Bruce Richardson wrote: >> On Wed, Jan 20, 2021 at 02:28:59PM +0000, Burakov, Anatoly wrote: >>> On 20-Jan-21 1:55 PM, David Hunt wrote: >>>> From: Bruce Richardson >>>> >>>> Adjust meson.build so that 'ninja install' copies the new header >>>> file into the installation directory. >>>> >>>> Fixes: 210c383e247b ("power: packet format for vm power management") >>>> Fixes: cd0d5547e873 ("power: vm communication channels in guest") >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Bruce Richardson >>>> Signed-off-by: David Hunt >>>> --- >>> >>> IMO this should be part of the first patch, otherwise the build could >>> (will?) be broken until this patch. >>> >> Since things were already broken before the set, I'm not sure this >> really >> matters. >> > > If they can be *un*broken sooner, that's a win in my book :) I'll keep that in mind for future patch sets. For this one, the effort to change far outweighs the benefits, so I'll leave as is. OK with you?