From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88535A00C2; Thu, 6 Oct 2022 11:39:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7D2AB42BDC; Thu, 6 Oct 2022 11:39:45 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by mails.dpdk.org (Postfix) with ESMTP id 6D18442BCC for ; Thu, 6 Oct 2022 11:39:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RMie5AI1NRT8eDp/KYLqjFJOcEUMZuM8PC7XS2Zja8FLKEYr2+T18/NxjjGtCE1x5/h0lcJU6a0751mM6GvmB/Xv7N74XOUGjhN9dUnRKMMkTGdYc2r8qeZxIPVrCOL6VhsugoPgNar1ObkdaMuZ8Dzi1gHf3FSI3eMmhVydlFy1Y6PhYH8lxxpxU25bIsV4HYU7YynqSh27ybaX+LctfSchpf7hYPBoTIWLlnsFxbkiXQuVkCDCbDAIXhkhUAF+K9WbrQuj5S1ALUWR3eRoezcbh3yDd4q9wIheTI5B5weyx9GWlecAigU3rR2YBzun4tdAB0TcwM98fmHWnXna8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nJOqoq4RZ4s1n4weWADYp/VoYirzQwDMLPPF7Pqe1WQ=; b=nLEjdUWRbS7dNu1gFyyxneYba1xV8mjiFOJlVYqaN4SXHMtamqfNdeKOKGkvUrHY9clgbaQwOVvN+VpqTes6JvIbhgNqa83QYLnGK99p89ebQtQ79xBfgqmict/LhWYuc4BW0cmob6ojAZcBDtUSSwEDFy3qDZSPZA48sneZ/3boX4ud3Dw2M4v3/eurF1rrk3sGVLoJctg8K+cGt9dHLKrr+d9X5y+O5MMaDqcTwkVIMbageEyHv8Ogr4hPuy6OI8RYnBOlO3gwOaCfpUwD+ovZjxxefWX43ZQ89WLZqXnx8BT0Od7Ps53C59eWIjbZvop7jiaZU3u2Y5L6dkh2uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nJOqoq4RZ4s1n4weWADYp/VoYirzQwDMLPPF7Pqe1WQ=; b=DyPSV4tET9k9v9nlp2T9voo6gDzk3PSiWkLDX8M1C9P6rpdC6joghB5yvnhPz16FZXeKL2I5oy0DTouOTiwG+3Ju4+tbtgVamMTwhGpukX8BDV7bK9+bhbiwaM51T9M7QGvS2zJXMmXLCPBzq8JCwQCCAR00cpXy7PJ1uUcl6+k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB6946.namprd12.prod.outlook.com (2603:10b6:806:24d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.20; Thu, 6 Oct 2022 09:39:40 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.036; Thu, 6 Oct 2022 09:39:40 +0000 Message-ID: <8924d23c-92bb-a2e4-4c1b-7a2c1fd2c7e3@amd.com> Date: Thu, 6 Oct 2022 10:39:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead of pointer Content-Language: en-US To: Gagandeep Singh , "dev@dpdk.org" Cc: Rohit Raj References: <20220928052516.1279442-1-g.singh@nxp.com> <20220928052516.1279442-12-g.singh@nxp.com> <5386c035-1114-1366-7820-f7f73b78c3f8@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0306.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB6946:EE_ X-MS-Office365-Filtering-Correlation-Id: 079deb0b-b046-4294-e1ce-08daa77eb10b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3EabNeqkw9M/4H1bP5cPojVfgdS2Tdi8VqzvOVZeeqJNr0Md/1mREB6UZiR32ta2aUIOU1a2wly5Qe1p+lmXhulr31W56nhsH6ZBXaZeBep9Zk4lf97fvuf+8AsqGJu7fo4skQmQTE25TW51CVypjtYDx/iMsFs2u3uHIkI1GcZe5VjMXHzz7JEGwpuA2Oalns62Rb75zyEJ9tSEXhMOqRB7NKMPhc82IR2KJAhWzaCjPfn/7J6Nhceq4YjxvKh0kL9X9Q1ge4JjzkHqEvo44B+Gm2Ct33lTQRKCk4Xj1Zyy+vv79QCAagoReEKGzb9g1cg0eB378FaMAKQGWUHnjGbXmM5dsrvWrowgdbQH/MseGrh4u8Hve5Rtg2HDe8kRgk5uWS7SkSc0u9h6xcYDMrV4alDVFiaCH/nAjsopLMLz0/tTmT/MK/s9F/1WlXvsCo9N/nhnXgZfO5kVFjwJGP9jN5JxQo3dPc5SaFPt8xYcfqM3rmq1wMGCJvXE3tieqn2OPNqOF74+6YtLrlai5pbK1+GaGW0I0ng7Km9km3B5QCvqi5bJiJnG7DNs+ryVrbsh2zG5HiFhiRRUIhc9Dh88/ksGXJXRJVyVmqA4XKU6g38yiJJkW9WDsRuXif6m+wurR+Spt9B4s7sFRrWQU6kL3qsr8yiz19/fOipVNjUKfOAeorVvj2tPPsqTXqPMhEWXFjnrxygnKnLysymEo4M2+V7HNta4ytz6MmpXHuWlkk1f5sBO5pZPOCBHo2WDG6jVfqd060YmDhRlFMz/8aGPGBSpA7MA6QF2pLckcAA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(366004)(376002)(136003)(39860400002)(346002)(451199015)(38100700002)(31696002)(86362001)(5660300002)(66946007)(66556008)(4326008)(8676002)(66476007)(316002)(110136005)(44832011)(2906002)(2616005)(41300700001)(8936002)(186003)(83380400001)(6486002)(478600001)(6666004)(6512007)(26005)(6506007)(31686004)(53546011)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2hSa0JSSjY0RGxicnFrWUQvc2lHQVpyZ05SSjgwRlpzVmtURHJFcUVOZU5H?= =?utf-8?B?bmZMdW5WU1F3Z0YrL2tVK1BRRHR3dVBENXRlVEtJL2FlWExhUFZpZlJZQnEv?= =?utf-8?B?MFhlS1RkOFpPS0FYUVBtRHVrYzIzQk5NdGZwbXFtZk5WRDVEL0I3Q0tTTDQ1?= =?utf-8?B?T3djaUd4bE9iejc4UE10N25uaktEZlJsTTY0ZlVuOHVtOVVuSW9tV0lNVUlx?= =?utf-8?B?RmkycXIrSnBqSVJjVTJjbGFaY2RJcnNzTWpUWG5GQWJtZUhGWm5OZUphVWdq?= =?utf-8?B?ZzI5REFUd3lMRCtmSG9YSTRoUWNOQTBMeW1nclIvdHhtRTN0ZlMrZHYvVGNR?= =?utf-8?B?dmR6d3pTYzJ6SFBYRGd0cGprNjNFS1dOVTRhZGs2VzVxZ2p4WEsycXBzZjdh?= =?utf-8?B?MnJnb0c0ZHJyRmY4eFR4bm9QYlZpc256aDZFNG5BYzlmWCtEcS9naWdIdHdo?= =?utf-8?B?cmhycVlQWi95VEVzeDBJNWN6UVB6Ni8xMlkyaVYyQklqeDBiQmJDT0NGSlJJ?= =?utf-8?B?QWtDeUEzdnlOdGNHMU94Y0M2Yk1zQUh4cG93Tjl5MkF2VXhEVTRieVFGTWQv?= =?utf-8?B?dytBVUUwdE1uZE14Zk5LakdjZitMaVhLSDVuMDZEOFEzWkpOVGNoZjVBdnY5?= =?utf-8?B?M0ZEVGplV2pNelBhaTJNbEVTTmgzeW5SREJKejB2bWZIUjVWQ0daKzVQdFE4?= =?utf-8?B?Uk9Bc1VxRnRVcmJtVW81NkVtOUZEekJMS250Mmg3L0ZGZUlndTkzQmJDa00x?= =?utf-8?B?Mm0xbmZRbkZ2ak0yV0lKU1lyTFJsM253Y3VqU3l6OXdaNnVMdlFlZ0FXTTI0?= =?utf-8?B?K3l5cG0wTWo3SGhsNTBDZ2laS3Z6REtwZmp4YkNXSXUrMm1SZm1oVGgxSEd1?= =?utf-8?B?ZUUwcldiZEwrQjhiMzNqckd6UzJ6c09CbFUxM01UTjhzdUx2TmlEZ2wrZ05l?= =?utf-8?B?RGRRbFRlTnVhU3cwQW9MK2ZNcWd6R0kzNXBnM2ZxaGJEQTVEa0RaSHlSVitW?= =?utf-8?B?cmxmd2dYenFMNXdZRnhCQXJxQ2p0MVBvbzhnSWdwYnpJajZkOXBNc2ExMitM?= =?utf-8?B?cU5DcUU0OE56MXJhcjJkTzNGNXF3bmcySHlsWjRUcDVrazF6SlhyOEtWbjlP?= =?utf-8?B?bWlET2NvZHQ2emtoallCSS9BeEFXYXFyZm9IVGk0QTBiV0x3UXpjbytZY2RG?= =?utf-8?B?dTdlWW5kYUc2bHZiT2ViV0dnajJhOVNDeUZVTFNIYjFjdHd4Q2ZmWWF3R21p?= =?utf-8?B?WWhBdlFLVFAraG5nb3NYQTVnSVUvQUdPK2ZkN2ozT3J0TXVWdzhlYnBWdUhL?= =?utf-8?B?SW1xRGNJWFdkYW9qOUg3TWNWcmdyc0VqTm4ycmQwTGhieUE5c3lSWjJPbktB?= =?utf-8?B?b2FZM0I5RGIzV3FGRkNXYmd0NVFwakwxOFJoaWd1aEp2UzFGRVhTZURaanVT?= =?utf-8?B?L0lncGlxczlaYnBuRjBVNVBTcExRWUFNd2hmYiszUkFHZmp2Z011WDE0MHA1?= =?utf-8?B?NU4vMFl4bmttRDJuRGpZdnBDUm0zYkVka3hQWEJ5ZWw0UkhYei9sNGtBK0hY?= =?utf-8?B?N25hdTlBR2tYc1VJU0lka3RibE5JcVRYSGdXSzFqVEFZVDB4Z0d4b084Ylhx?= =?utf-8?B?Z2QyWnZMTXBQVXZHTEdScFlhRXRmODlLUUtoOHFma3FPd3IyQmFZbTc4S0Nj?= =?utf-8?B?cDA0bS9YbUhlcEk3ZytxZ3NDdlJDa01FRi9oUXIzRlhSVEx5V1RDclFBZGhB?= =?utf-8?B?M2hTY1FIQzl6WHRyRGkxUXo2L3dJYWFieWt2b25vd00xSllkZDZhckFHUEdH?= =?utf-8?B?L214QzAvYk9TUDFhWWI4UHhaeWxQUVpBSzBPVzJRQ2ZpdWxKNzRTZVFiU3BL?= =?utf-8?B?L1Bjc1RrcmJNZlFWUWhyRGdFWnF6NGFDWE5VQTAwb0dWeVZUZ0VURHdHY3Fi?= =?utf-8?B?Y0FkN2hNZjFrNjlnNS8vQUloc21tVjI2bzRSVjdERG9LMEpzWGN6UlJWdFF5?= =?utf-8?B?cWVIcjdrUGpFYnNsRVZqRGtKZWV2L0RrcUV5aHRPNjc5ejFGREJ3a3QxeCsw?= =?utf-8?B?MU5QRDdmQlJ5VUpwOXZmaGFOS0tyVk9MU3VxckFWUTdyZ290OFhseWxMMnVS?= =?utf-8?Q?kxTkhWHGuNxDJ0jvJ+LJiwLVi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 079deb0b-b046-4294-e1ce-08daa77eb10b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2022 09:39:40.6441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hgtt8Pwq7NEsQzARDqiXOxxefM54pzaC1ekQ7sEIy3/EOAnwWRAZgHRmx3Je9Vba X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6946 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/6/2022 9:51 AM, Gagandeep Singh wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, October 5, 2022 7:52 PM >> To: Gagandeep Singh ; dev@dpdk.org >> Cc: Rohit Raj >> Subject: Re: [PATCH 11/15] bus/dpaa: pass interface name as a string instead >> of pointer >> >> On 9/28/2022 6:25 AM, Gagandeep Singh wrote: >>> From: Rohit Raj >>> >>> Due to change in latest kernel, passing the interface name to kernel >>> through IOCTL as string instead of character pointer. >>> >> >> This kernel component is the one that is delivered part of SDK I assume, >> instead of an upstreamed one. >> >> What is the way for user match kernel code and DPDK driver, like is there any >> matching version information documented? >> > We share the version compatible information in our internal SDK release document. > That is what I thought, does it make sense to link to that information from DPDK documentation? >>> Signed-off-by: Rohit Raj >>> --- >>> drivers/bus/dpaa/base/qbman/process.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/bus/dpaa/base/qbman/process.c >>> b/drivers/bus/dpaa/base/qbman/process.c >>> index 9bc92681cd..3504ec97db 100644 >>> --- a/drivers/bus/dpaa/base/qbman/process.c >>> +++ b/drivers/bus/dpaa/base/qbman/process.c >>> @@ -302,7 +302,7 @@ int bman_free_raw_portal(struct dpaa_raw_portal >> *portal) >>> _IOW(DPAA_IOCTL_MAGIC, 0x0E, struct usdpaa_ioctl_link_status) >>> >>> #define DPAA_IOCTL_DISABLE_LINK_STATUS_INTERRUPT \ >>> - _IOW(DPAA_IOCTL_MAGIC, 0x0F, char*) >>> + _IOW(DPAA_IOCTL_MAGIC, 0x0F, char[IF_NAME_MAX_LEN]) >>> >>> int dpaa_intr_enable(char *if_name, int efd) >>> { >>> @@ -330,7 +330,7 @@ int dpaa_intr_disable(char *if_name) >>> if (ret) >>> return ret; >>> >>> - ret = ioctl(fd, DPAA_IOCTL_DISABLE_LINK_STATUS_INTERRUPT, >> &if_name); >>> + ret = ioctl(fd, DPAA_IOCTL_DISABLE_LINK_STATUS_INTERRUPT, >> if_name); >>> if (ret) { >>> if (errno == EINVAL) >>> printf("Failed to disable interrupt: Not Supported\n"); >> @@ -472,7 >>> +472,7 @@ int dpaa_update_link_speed(char *if_name, int link_speed, int >> link_duplex) >>> } >>> >>> #define DPAA_IOCTL_RESTART_LINK_AUTONEG \ >>> - _IOW(DPAA_IOCTL_MAGIC, 0x13, char *) >>> + _IOW(DPAA_IOCTL_MAGIC, 0x13, char[IF_NAME_MAX_LEN]) >>> >>> int dpaa_restart_link_autoneg(char *if_name) >>> { >>> @@ -481,7 +481,7 @@ int dpaa_restart_link_autoneg(char *if_name) >>> if (ret) >>> return ret; >>> >>> - ret = ioctl(fd, DPAA_IOCTL_RESTART_LINK_AUTONEG, &if_name); >>> + ret = ioctl(fd, DPAA_IOCTL_RESTART_LINK_AUTONEG, if_name); >>> if (ret) { >>> if (errno == EINVAL) >>> printf("Failed to restart autoneg: Not Supported\n"); >