From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B6BDCA0556;
	Mon, 17 Oct 2022 10:29:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 772CD40143;
	Mon, 17 Oct 2022 10:29:01 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id AB83E400D7
 for <dev@dpdk.org>; Mon, 17 Oct 2022 10:28:59 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 3A11D83;
 Mon, 17 Oct 2022 11:28:59 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3A11D83
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1665995339;
 bh=z126FS2nbD+30e7yTJ/U8qBLSrdZ0JMBErc9730oKsQ=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=tQ8wvwPNfLM6BA6HblheAgXm+/hv7xCambYH51+RNUrU/62Wsf6uYiK1bvQO1X+LY
 LdjPWLps8YSQGF9A7lggNwXUWGairu3DMflwb88EaenVMrWfcg9hWaVqU/TaY+jidf
 3/u3vDzcXRnqS/QkF/sNqIruTQ0wAlo6cRnbvESo=
Message-ID: <892a310a-d80a-cf7f-3f8b-3ae421575137@oktetlabs.ru>
Date: Mon, 17 Oct 2022 11:28:59 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2] net/bonding: fix error in bonding mode 4 with
 dedicated queues enabled
Content-Language: en-US
To: Chas Williams <3chas3@gmail.com>, Usman Tanveer
 <usman.tanveer@emumba.com>, chas3@att.com, humin29@huawei.com
Cc: dev@dpdk.org
References: <20220929040551.120717-1-usman.tanveer@emumba.com>
 <567bc309-c475-25c2-d9ed-f8ef3b47db2f@gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <567bc309-c475-25c2-d9ed-f8ef3b47db2f@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/15/22 18:28, Chas Williams wrote:
> Thanks for making the change, IMHO this is much clearer.
> 
> Signed-off-by: Chas Williams <3chas3@gmail.com>

Taking above sentence into account I treat it as:
Acked-by: Chas Williams <3chas3@gmail.com>

> 
> On 9/29/22 00:05, Usman Tanveer wrote:
>> when dedicated queues are enable with bonding mode 4 (mlx5), the
>> application sets the flow, which cannot be set if the device is not
>> started. This fixed the issue by starting the device just before
>> setting the flow. Because device should be started to set the flow.
>> Also it does not effect other driver codes (I have tried on ixgbe).
>>
>> Bugzilla ID: 759
>>
>> Signed-off-by: Usman Tanveer <usman.tanveer@emumba.com>

Applied to dpdk-next-net/main, thanks.