From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 237E1A04B7; Wed, 14 Oct 2020 08:25:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9564B1DC4F; Wed, 14 Oct 2020 08:25:27 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by dpdk.org (Postfix) with ESMTP id 46EDE1DC32 for ; Wed, 14 Oct 2020 08:25:26 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id AE23B7F541; Wed, 14 Oct 2020 09:25:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru AE23B7F541 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1602656724; bh=Lb/bbl+NNVMALDtNZVCg9hHKVEIDGv/a4JWRqpR13eQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=CaSwF/CWaRR6Qw3muTNoEHL7+gssaZI5xEnNeKLux5sejEmNT1/ukM3tS+qeZnVmG pvj4weI2XpSddP6n2xxjG5zUYlkst5iVO9fEONOGNcwPWidaMhoHL+CYaAsDgHvlws DbzyeXzcnE3mOGRKn6jq/7lBckyEST9QvSeQzwpg= To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org References: <20201013165658.638760-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <8933daaf-b285-3f91-d087-c92d576626a4@oktetlabs.ru> Date: Wed, 14 Oct 2020 09:25:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201013165658.638760-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] ethdev: unify prefix for static function and variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/20 7:56 PM, Ferruh Yigit wrote: > Prefix static function and variables with 'eth_dev'. > > For some 'rte_' prefix dropped, and for others 'eth_dev' added. > This is useful to differentiate public and static function/variables. > > The cleanup is good to for having consistent naming to help new > additions naming. > > No functional change, only naming. > > Signed-off-by: Ferruh Yigit > --- > I think this renaming is good idea but not sure if it worth the noise > it creates in the git history, since the change is mostly cosmetic. I like the idea and say yes. Noise on git history is not the main problem here. Fixes backporting will be a problem. Anyway we should do it one day and I see no single reason why not now. Acked-by: Andrew Rybchenko