From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
dev@dpdk.org,
Christian Ehrhardt <christian.ehrhardt@canonical.com>,
Markos Chandras <mchandras@suse.de>,
Panu Matilainen <pmatilai@redhat.com>
Subject: Re: [dpdk-dev] RFC: DPDK Long Term Support
Date: Mon, 06 Jun 2016 16:23:22 +0200 [thread overview]
Message-ID: <8934963.xif5dsyFi0@xps13> (raw)
In-Reply-To: <20160606141407.GE10038@yliu-dev.sh.intel.com>
2016-06-06 22:14, Yuanhan Liu:
> On Mon, Jun 06, 2016 at 03:31:09PM +0200, Thomas Monjalon wrote:
> > 2016-06-06 19:49, Yuanhan Liu:
> > > On Fri, Jun 03, 2016 at 06:05:15PM +0200, Thomas Monjalon wrote:
> > > > 2016-06-03 15:07, Mcnamara, John:
> > > > > Developers submitting fixes to the mainline should also CC the maintainer so
> > > > > that they can evaluate the patch. A <stable@dpdk.org> email address could be
> > > > > provided for this so that it can be included as a CC in the commit messages
> > > > > and documented in the Code Contribution Guidelines.
[...]
> > Why put a CC tag in the commit? For automatic processing?
> > Maybe it is too early to run before walking ;)
>
> It's a tip/trick used a lot in kernel community. Assume you have made
> a patchset, that just one of them fixes a bug that you hope this patch
> could also be cc'ed to the original author that introduces the bug.
> You could achieve that by adding him to the cc list from cli. However,
> in such way, all patches are cc'ed to him. The alternative is to add
> a line "Cc: some.one <some@one.com>" in the commit log so that he will
> get that patch only.
>
> If you look at a small micro optimization patchset I sent out last
> month [0], you will find that I used this trick for the 1st patch,
> as it touches the core part of virtio-net vring operation, that I
> hope I can get some comments from the virtio guru/maintainer, Michael.
> Therefore, he is cc'ed. However, for the 2 other patches in the same
> set, it's basically DPDK vhost-user stuff, so that I didn't cc him
> to not bother him.
>
> This rule, of course, also applies to the stable branch (for bug
> fixing patches in a set). It doesn't matter which way you take if
> it's just a patch set of one bug fixing patch though.
>
> [0]: http://dpdk.org/ml/archives/dev/2016-May/038246.html
OK
next prev parent reply other threads:[~2016-06-06 14:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 15:07 Mcnamara, John
2016-06-03 16:05 ` Thomas Monjalon
2016-06-06 11:49 ` Yuanhan Liu
2016-06-06 13:31 ` Thomas Monjalon
2016-06-06 14:14 ` Yuanhan Liu
2016-06-06 14:23 ` Thomas Monjalon [this message]
2016-06-07 13:17 ` Mcnamara, John
2016-06-03 18:17 ` Matthew Hall
2016-06-07 12:53 ` Mcnamara, John
2016-06-05 18:15 ` Neil Horman
2016-06-06 9:27 ` Thomas Monjalon
2016-06-06 13:47 ` Neil Horman
2016-06-06 14:21 ` Thomas Monjalon
2016-06-06 15:07 ` Neil Horman
2016-06-07 16:21 ` Mcnamara, John
2016-06-07 15:55 ` Mcnamara, John
2016-06-06 13:44 ` Nirmoy Das
2016-06-06 14:16 ` Yuanhan Liu
2016-06-07 12:36 ` Christian Ehrhardt
2016-06-07 19:39 ` Martinx - ジェームズ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8934963.xif5dsyFi0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=mchandras@suse.de \
--cc=pmatilai@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).