From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bus/fslmc: use PRIu64 instead of llX in format specifier
Date: Fri, 13 Apr 2018 14:26:24 +0530 [thread overview]
Message-ID: <893c8705-858c-336d-c600-c4a23e8fea5b@nxp.com> (raw)
In-Reply-To: <4074558.oWdUdNoPZr@xps>
On Friday 13 April 2018 01:11 PM, Thomas Monjalon wrote:
> 13/04/2018 07:04, Gowrishankar:
>> - DPAA2_BUS_DEBUG("--> Map address: %llX, size: 0x%llX",
>> + DPAA2_BUS_DEBUG("--> Map address: %"PRIu64", size: 0x%"PRIu64"",
>
> You cannot replace hexadecimal by decimal.
> You need to use PRIx64.
>
>
Now that Thomas has pointed out, I think the log message can be
improved. Len as hex is not helpful and is out of sync with other
messages in this file.
While on this, I think it should be corrected.
I will fix this.
@gowrishankar, I will post a patch in reply to your patch - can you
please help me with ppc64le check? I will take care of Hemant's comment.
-
Shreyansh
next prev parent reply other threads:[~2018-04-13 8:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 5:04 Gowrishankar
2018-04-13 7:10 ` Shreyansh Jain
2018-04-13 7:09 ` Hemant Agrawal
2018-04-13 7:37 ` Hemant Agrawal
2018-04-13 7:41 ` Thomas Monjalon
2018-04-13 8:56 ` Shreyansh Jain [this message]
2018-04-13 8:43 ` gowrishankar muthukrishnan
2018-04-13 10:37 ` Shreyansh Jain
2018-04-13 10:40 ` [dpdk-dev] [PATCH v2] " Gowrishankar
2018-04-13 10:47 ` gowrishankar muthukrishnan
2018-04-13 10:55 ` Gowrishankar
2018-04-13 11:17 ` Shreyansh Jain
2018-04-13 11:22 ` [dpdk-dev] [PATCH v3] " Gowrishankar
2018-04-13 12:44 ` Hemant Agrawal
2018-04-15 12:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=893c8705-858c-336d-c600-c4a23e8fea5b@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=hemant.agrawal@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).