From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35B18A034C; Fri, 25 Feb 2022 16:31:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C993F4115C; Fri, 25 Feb 2022 16:31:53 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 7FE5B4068B for ; Fri, 25 Feb 2022 16:31:52 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id E664D5C0152; Fri, 25 Feb 2022 10:31:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 25 Feb 2022 10:31:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=uLkS8UXBZj7qk+ +itpsFjl9JP6Uzm0SK95BGyajO4JQ=; b=BRPJ2wZKX2esjTB50ux0sCvZ5Jdfm0 st2rX8nHRQHdTXRnEPRNk1Y6iiGFeWEAPkF+gTQUFw5HnQrE3rEPXNwgwY5to/tA TF2U8fQseJnP4tZgo4ZaIcI0ljZvhovNQlWYpydh1niqWIgUUlDQ7mMz+jIL6tcg 9Xi5MOFnGw/XjXlExw1Ze1yWSAt7CmKXmkiLAKqnELpSRmnF1wQOR2lTxllwlPMs 3x0KiZB2Nc6G3beEpgTzknMPNHPIVRlwWojgDz5pqEoMuCpYXOP1taLgEhYRYKV0 Oa4m4hgTXES4JrOPbHWhqKwfKLveq3R52oqaLrP0DNrRw+UTc9l/nN3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=uLkS8UXBZj7qk++itpsFjl9JP6Uzm0SK95BGyajO4 JQ=; b=Ai3Da/0AGj07XSnQ7H3EUqPDP3L7YGa+DY+1ndVc5DwN32FjCkiMXIHUN LcIi3QoBivPaSJIA9gVoS6Ozwqe0RNN4zDAjLLpzNAzccEmK5XkWgMP3OMJ4Vq02 S1Ns3caIZB6duqv2dZ/9qwnn7OxCDaQ22nZLhGp2Xspi706GSSYAq0HZAr/iGA5N VVkuawxoLDcZ4KEdn8u8PwLkwixQx62EmG0Wy735O7OknC2UUdbd6qYmDGdoSiAc nVZglfYIjtjv01nQxnIESXPA2g5DxYIfEoP6bl/mhjLDONCXwypgPjyCM8HwM0mC 3Fdt61EOUEVfmiDXlag92RNQAiKnw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleeggdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 25 Feb 2022 10:31:51 -0500 (EST) From: Thomas Monjalon To: "Sean Zhang (Networking SW)" Cc: Matan Azrad , Slava Ovsiienko , dev@dpdk.org, asafp@nvidia.com Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE Date: Fri, 25 Feb 2022 16:31:49 +0100 Message-ID: <8946654.rMLUfLXkoz@thomas> In-Reply-To: References: <20220211014530.77711-5-xiazhang@nvidia.com> <1972215.kUgFBCI4xA@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/02/2022 04:00, Sean Zhang (Networking SW): > Hi Thomas, > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Thursday, February 17, 2022 4:34 PM > > To: Matan Azrad ; Slava Ovsiienko > > ; Sean Zhang (Networking SW) > > > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] net/mlx5: support matching optional fields of GRE > > > > External email: Use caution opening links or attachments > > > > > > 17/02/2022 07:27, Sean Zhang: > > > This patch adds matching on the optional fields > > > (checksum/key/sequence) of GRE header. The matching on checksum and > > > sequence fields requests support from rdma-core with the capability of > > misc5 and tunnel_header 0-3. > > > > > > For patterns without checksum and sequence specified, keep using misc > > > for matching as before, but for patterns with checksum or sequence, > > > validate capability first and then use misc5 for the matching. > > > > > > Signed-off-by: Sean Zhang > > > Acked-by: Slava Ovsiienko > > > > > > --- > > > v3 - some code style change > > > v2 - replace default mask with nic mask > > > --- > > > doc/guides/nics/mlx5.rst | 10 +++ > > > drivers/common/mlx5/mlx5_devx_cmds.c | 3 + > > > drivers/net/mlx5/linux/mlx5_os.c | 2 + > > > drivers/net/mlx5/mlx5.h | 1 + > > > drivers/net/mlx5/mlx5_flow.c | 101 > > +++++++++++++++++++++++++++++ > > > drivers/net/mlx5/mlx5_flow.h | 6 ++ > > > drivers/net/mlx5/mlx5_flow_dv.c | 121 > > +++++++++++++++++++++++++++++++++++ > > > 7 files changed, 244 insertions(+) > > > > Should we add a line in the release notes? > > > > This patch is v3 of the forth patch of patch set: https://patches.dpdk.org/project/dpdk/cover/20220211014530.77711-1-xiazhang@nvidia.com/ > The release notes changed in the second patch of the patch set and applied in v2. > > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -87,6 +87,11 @@ New Features > > The new API ``rte_event_eth_rx_adapter_event_port_get()`` was added. > > +* **Added rte_flow support for matching GRE optional fields.** > + > + * Added ``gre_option`` item in rte_flow to support checksum/key/sequence > + matching in GRE packets. > + OK but it is missing a line for mlx5 features. I'm adding it while merging.