From: "Chauskin, Igor" <igorch@amazon.com>
To: Vladislav Zolotarov <vladz@scylladb.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Schmeilin, Evgeny" <evgenys@amazon.com>
Subject: Re: [dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided queue length value
Date: Mon, 9 Mar 2020 10:07:48 +0000 [thread overview]
Message-ID: <895623d153b7461b8750eb2524f8d8b6@EX13D12EUA003.ant.amazon.com> (raw)
In-Reply-To: <a9d21398-1e8f-3d55-ab32-01619492aa4b@scylladb.com>
Acked inline
From: Vladislav Zolotarov <vladz@scylladb.com>
Sent: Friday, March 6, 2020 12:28 AM
To: dev@dpdk.org; Schmeilin, Evgeny <evgenys@amazon.com>; Chauskin, Igor <igorch@amazon.com>
Subject: RE: [EXTERNAL][dpdk-dev] [PATCH v1] ena_ethdev: don't override the user provided queue length value
Igor, Evgeny,
Please, review.
On 3/5/20 5:23 PM, Vlad Zolotarov wrote:
There is a funny logic that seems to be outdated which tries to detect
a situation when a user requests a default size of the queue and
configures a device specific default value.
This seems to be not in line with the DPDK current design that expects
the user to go via the rte_eth_dev_info_get() in order to get device
specific values.
And if the user doesn't care it should pass 0 as a queue length and this
case is also being taken care of on the rte_eth level.
Signed-off-by: Vlad Zolotarov <vladz@scylladb.com><mailto:vladz@scylladb.com>
Acked-by: Igor Chauskin igorch@amazon.com<mailto:igorch@amazon.com>
---
drivers/net/ena/ena_ethdev.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 665afee4f..bf632dee0 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -1221,9 +1221,6 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,
return -EINVAL;
}
- if (nb_desc == RTE_ETH_DEV_FALLBACK_TX_RINGSIZE)
- nb_desc = adapter->tx_ring_size;
-
txq->port_id = dev->data->port_id;
txq->next_to_clean = 0;
txq->next_to_use = 0;
@@ -1292,9 +1289,6 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,
return ENA_COM_FAULT;
}
- if (nb_desc == RTE_ETH_DEV_FALLBACK_RX_RINGSIZE)
- nb_desc = adapter->rx_ring_size;
-
if (!rte_is_power_of_2(nb_desc)) {
PMD_DRV_LOG(ERR,
"Unsupported size of RX queue: %d is not a power of 2.\n",
next prev parent reply other threads:[~2020-03-10 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 22:23 Vlad Zolotarov
2020-03-05 22:28 ` Vladislav Zolotarov
2020-03-09 10:07 ` Chauskin, Igor [this message]
2020-03-11 13:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=895623d153b7461b8750eb2524f8d8b6@EX13D12EUA003.ant.amazon.com \
--to=igorch@amazon.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=vladz@scylladb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).