From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC3EB457A0; Mon, 12 Aug 2024 13:16:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9873C402C3; Mon, 12 Aug 2024 13:16:21 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 9AF604029C for ; Mon, 12 Aug 2024 13:16:19 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 973C8FEC; Mon, 12 Aug 2024 04:16:44 -0700 (PDT) Received: from [10.1.38.158] (e132843.arm.com [10.1.38.158]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 633213F6A8; Mon, 12 Aug 2024 04:16:17 -0700 (PDT) Message-ID: <89576b74-e45c-4363-abd3-a50480d7aea9@foss.arm.com> Date: Mon, 12 Aug 2024 12:16:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] eal: extend bit manipulation functionality To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org Cc: hofors@lysator.liu.se, Heng Wang , Stephen Hemminger , Joyce Kong , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= References: <20240809090439.589295-2-mattias.ronnblom@ericsson.com> <20240809095829.589396-1-mattias.ronnblom@ericsson.com> <20240809095829.589396-2-mattias.ronnblom@ericsson.com> Content-Language: en-GB From: Jack Bond-Preston In-Reply-To: <20240809095829.589396-2-mattias.ronnblom@ericsson.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 09/08/2024 10:58, Mattias Rönnblom wrote: > + > +__RTE_GEN_BIT_TEST(, test,, 32) > +__RTE_GEN_BIT_SET(, set,, 32) > +__RTE_GEN_BIT_CLEAR(, clear,, 32) > +__RTE_GEN_BIT_ASSIGN(, assign,, 32) > +__RTE_GEN_BIT_FLIP(, flip,, 32) > + > +__RTE_GEN_BIT_TEST(, test,, 64) > +__RTE_GEN_BIT_SET(, set,, 64) > +__RTE_GEN_BIT_CLEAR(, clear,, 64) > +__RTE_GEN_BIT_ASSIGN(, assign,, 64) > +__RTE_GEN_BIT_FLIP(, flip,, 64) What is the purpose of the `fun` argument? As opposed to just having these written out in the macro definitions. I notice the atomic equivalents don't have this. > /*------------------------ 32-bit relaxed operations ------------------------*/ > > /** >