From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 5D0E22B89 for ; Mon, 11 Apr 2016 12:00:07 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id a140so5709662wma.0 for ; Mon, 11 Apr 2016 03:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=rV2UB0DG1DO6f+27oLg3OJQQKzI1jcr6Iw/BdQEZh54=; b=XMUDBKOde6nHdbaXGD321EVIO0ox9W3zrLtfmyZgWCxY0n5F7+w3c081J/tUZ148+B 6QDwnhoBDZmiR50Bf31NcJjTUyZITx/TYAVrt9jzIE3Q63dxzg6kcyh37s6kxNtB33p+ eBLIYMdYsLbXfHdW1LvV2Li7up27dRJgFyrY++riB+kWv2wjJlEGMjQJ3pkCB1pVdrjE eVDDrOgb0/IY86TZ0gcwoEx2Bl0gQkMm/eQjlwRAeT4ZVhVJZMKXMcc5FUR6N4Daosb8 F18Pz3ewp5sH9KpFsdAqhPQIY2nWQk96FJXTm7HMLfRThTGbN9+pINQdlfcVeU7C7MSI VJjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=rV2UB0DG1DO6f+27oLg3OJQQKzI1jcr6Iw/BdQEZh54=; b=m1XzPP4SbBkchcBnlqN+ufxCA3eA3ZT5GiOxmFb5A+ccb6TUM3kPel5ynJgGaERnG+ X7Y42YnNWLjXfQ2a1uXLbL0F2rywHS0kS/GJPEb9Nkps48z79d+Vgse2lEe1gVw25Cqz VPB0qU1CwxFkBhGAX/Zjq9uETuaLgVSu/RLc6YOEiUuaqZ2vVWwP3/eFWkkOR1FIORUE yon9fACZaK2zlv2sfI8cnfwCl8z8jWrzvOSaAP6WWAM4zntQzOk1eowcTt0KqFneladj dz+ww/aMm5exMXlM7y00H1wGgdYr3Z3he2sdaUKGFinlAVKwTY8jOqzCkYw4Kyh7YbHU +dOQ== X-Gm-Message-State: AOPr4FWoljwwLwSVtNbnbO0TS/SIiNIKzPiRSBqw0TAXErcYYmIxhdXcEfSwYnkKuQ7LUeeN X-Received: by 10.28.212.71 with SMTP id l68mr6878639wmg.22.1460368807200; Mon, 11 Apr 2016 03:00:07 -0700 (PDT) Received: from xps13.localnet (245.111.75.86.rev.sfr.net. [86.75.111.245]) by smtp.gmail.com with ESMTPSA id lh1sm26967026wjb.20.2016.04.11.03.00.06 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Apr 2016 03:00:06 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson , Yuanhan Liu Cc: dev@dpdk.org Date: Mon, 11 Apr 2016 12:00:05 +0200 Message-ID: <8960252.5hA2CMWBcp@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160330142740.GB21156@bricha3-MOBL3> References: <1459286986-31148-1-git-send-email-thomas.monjalon@6wind.com> <20160330014634.GC3080@yliu-dev.sh.intel.com> <20160330142740.GB21156@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] scripts: check commit formatting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2016 10:00:07 -0000 2016-03-30 15:27, Bruce Richardson: > On Wed, Mar 30, 2016 at 09:46:34AM +0800, Yuanhan Liu wrote: > > On Tue, Mar 29, 2016 at 11:29:46PM +0200, Thomas Monjalon wrote: > > > The git messages have three parts: > > > 1/ the headline > > > 2/ the explanations > > > 3/ the footer tags > > > > > > The headline helps to quickly browse an history or catch instantly the > > > purpose of a commit. Making it short with some consistent wording > > > allows to easily parse it or match some patterns. > > > > > > The explanations must give some keys like the reason of the change. > > > Nothing can be automatically checked for this part. > > > > Actually, I think we might be able to do 2 tests here: > > > > - space line between paragraphs. > > > > - lines over 80 chars. > > 75 chars for commit messages, and 50 for commit titles :-) The 75 chars limit is already checked by checkpatch.pl. But yes we can have our own check in this script. For the title, I think we can accept 60 chars and exceptionnaly more. To see the history of title length: git log --format='%s' | awk '{lens[length($0)]++;} END {for (len in lens) print len, lens[len] }' | sort -g