From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4D6911B82B for ; Tue, 10 Apr 2018 17:07:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF7BA20E75; Tue, 10 Apr 2018 11:07:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 10 Apr 2018 11:07:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=qDHymPFnUKZuSCahsFe7AfpUE6 cNIqlvrd4g5Zq0YAQ=; b=qhLygWYDd/uqt8r8GHYgYsUqJxCXFepL4k7N2Bdc+O JObugv9a69NdTJqyF4nVii6RsScyrU9z5V0v9Em/OSzW5C2stROT+QoCZnzyexGW G5FYoPCxjmLZjAmciyQo+LWHPQV/nKRXHTLB7LyNfxkiCMdYkxcZEQDnoeOf7+Nw 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=qDHymP FnUKZuSCahsFe7AfpUE6cNIqlvrd4g5Zq0YAQ=; b=MSsrTEUXYpJ6kdMUFaG219 TV1pQtQsvdsZBkQAgdxu2o7Ncn+Xuv85nVnVJ+YsfxslX/YCp68y8fguj6LRF9K4 Ptk492Nhf+QDvRjDgwx6H7SqLs0wSeeg/OweN8JzU6Roy14TvROh6x9exHYROAnE eW2NY7iegYB30+IrLt5zo3GdrLUmu0SrXkfW03hNovbpGVF+4aHoUpQnqjxbPkfR e8iT7c5oG6Eg9vFhDXpKlb/HXPRYK3p1x132y550xPbgxSfPrAmiMyY0uKXYMcuw Fjf6gIPqX1AgbZ9anos6A1M3phyRRaOqmCN45nuHLCwAzbpvT3ypucP5bC966FcQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CA877E43C8; Tue, 10 Apr 2018 11:07:16 -0400 (EDT) From: Thomas Monjalon To: Pavan Nikhilesh Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, stephen@networkplumber.org, konstantin.ananyev@intel.com Date: Tue, 10 Apr 2018 17:07:15 +0200 Message-ID: <8961764.He0omIczL0@xps> In-Reply-To: <20180406182516.GA13313@ltp-pvn> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <1655998.KI4tD34sB9@xps> <20180406182516.GA13313@ltp-pvn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 15:07:18 -0000 06/04/2018 20:25, Pavan Nikhilesh: > On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > > 06/04/2018 13:01, Pavan Nikhilesh: > > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > > > Please, could you provide a log of the error? > > CC eal.o > In file included from /root/dpdk/lib/librte_eal/linuxapp/eal/eal.c:33: > In file included from /root/dpdk/build/include/rte_eal_memconfig.h:13: > In file included from /root/dpdk/build/include/rte_rwlock.h:10: > In file included from /root/dpdk/build/include/generic/rte_rwlock.h:25: > In file included from /root/dpdk/build/include/rte_atomic.h:37: > In file included from /root/dpdk/build/include/rte_atomic_64.h:16: > /root/dpdk/build/include/generic/rte_atomic.h:215:9: error: implicit declaration of function '__atomic_exchange_2' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > return __atomic_exchange_2(dst, val, __ATOMIC_SEQ_CST); > ^ > /root/dpdk/build/include/generic/rte_atomic.h:215:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > /root/dpdk/build/include/generic/rte_atomic.h:494:9: error: implicit declaration of function '__atomic_exchange_4' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > return __atomic_exchange_4(dst, val, __ATOMIC_SEQ_CST); > ^ > /root/dpdk/build/include/generic/rte_atomic.h:494:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > /root/dpdk/build/include/generic/rte_atomic.h:772:9: error: implicit declaration of function '__atomic_exchange_8' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > return __atomic_exchange_8(dst, val, __ATOMIC_SEQ_CST); > ^ > /root/dpdk/build/include/generic/rte_atomic.h:772:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] > 6 errors generated. > make[5]: *** [/root/dpdk/mk/internal/rte.compile-pre.mk:116: eal.o] Error 1 > > > > > > Why __atomic_exchange_n is fixing the compilation? > > I guess __atomic_exchange_2/5/8 fall under c++11 standard? > https://llvm.org/docs/Atomics.html Applied (with error log), thanks