From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51626433E2; Mon, 27 Nov 2023 16:44:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 192A640648; Mon, 27 Nov 2023 16:44:10 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id 1B05C402A3 for ; Mon, 27 Nov 2023 16:44:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JE5GwS1U5HqXs6hKGxp0Yi9ZDOcm3dn7fde/av6s0SNce9apyKQLSngkCYg821QEfpoSlJ/qLFuDvQhfxJyq+7cY43PArXObZaW0uKtiqnmWISBbQ3f/D4xhr4QYtyZREN9mk4qpT1wPVJWl0fH3d5/4kJeybSe7uD38vCdVejkupx15ozXdHPP5wm4nchyJA3YdzNHk3NvA2Mggv/9V3CarfmWTIfI9ucp2vy33ff24js/nFmhGGk1MjtTx+kWnA4ohF1JvyMqMhynFQsuQ4xhb5RpmChQy0vkn5LFLrHZyeWdarVm8i6pDYZ8nUhbREap7VcnJ0oWXzoqlchkpHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XScwx9tDIUv1kHi9NtllN4BMeRsdxaRSBYAMIY2rzB4=; b=l7lzeccklviOioBILdJCbv4MrrdgSgXc27HgwEz/m8YAZ80lwMb7KfY3Z5SnVlQs9BHv+lONvBWT228G6Bcs/Zav+n8C9Bw4LHI5LmqGTtlEBCd03ksSXZjC9qlqjnRv1uvpP9ZhpV3VeInwPuRqD23LbGJ2Hw+KXRB9P9gWJJp2Ei2/6D0uah84KmXWPsT4CacqJrZpWhfZG8VZh/rnAeBl2rYrS3kOYwfshiDZyL/oH+fqJ9gxZhSFW+Wv8nfM9ohwjP6oqnp6SFFMsIw8g2WOlxNXkV469yUAbjgxeRFsGuIwMPzvzQHAWYcwV9rDls8dd9uRu2lWVODCxrrahw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XScwx9tDIUv1kHi9NtllN4BMeRsdxaRSBYAMIY2rzB4=; b=M1cd8X0oNIss9YJ9Mewrl5cRq8mJ82sWaYfvAWmjdjVvodhbpf9jwcVfWdp0IVg4FU0+ofyanYwlFqPkUEXZr7upzvP9DVoTsH+Q+iKI0v6mAbimyjCpQ2tzYIdF4oZIRXvR9B9T2qOHDbp0Sz7X0iOy0HV8Lm2lPesHZz1X07Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5986.namprd12.prod.outlook.com (2603:10b6:8:69::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.28; Mon, 27 Nov 2023 15:44:01 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 15:44:01 +0000 Message-ID: <8968ac41-bf19-40ac-a057-aad7b46b7ca8@amd.com> Date: Mon, 27 Nov 2023 15:43:55 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature Content-Language: en-US To: "lihuisong (C)" , dev@dpdk.org Cc: liuyonglong@huawei.com, thomas@monjalon.net, Chengwen Feng , Dongdong Liu , Jie Hai References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> <20231125014745.61348-2-lihuisong@huawei.com> <89b73632-8a7a-e54c-2957-04c347027c2e@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <89b73632-8a7a-e54c-2957-04c347027c2e@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0414.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:d0::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5986:EE_ X-MS-Office365-Filtering-Correlation-Id: bb2b2188-3003-4e74-bbf5-08dbef5fad30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EUw31TQR9YG/KzKKNeLnDVkZypy8Wn5rp3ttqYVHiq6lo+y3pxuncPGEMq19lpocCLKeDLCVXlpzg3Ws0FDjtPDi335fSpWr2QDb7G/rsGvR6pWLkoEIYL5qwily6TaRADRum4ajwEm8x2Vbws+Qh12T5C6sW+lcXZ3rpMcDykRWFpcbrhuLATv9rdd24WnBusWN8w0pmP1puQNrEqDGKQ+sQykDktgZ28MjuXxLDZyicINU+skiMkR+uqgB+l7mmnujKrvyLieugYmjO5LsdiEpLfXLCfKi54nNgJoF9hSpc+ShySEPTTLPWtC02WBGSZ7yQzCTyArKhyOfuybOrjVTt6WW8Z5UxrqA4n0hPzLgLrJ8P+dtulaJ221XR5Hh2+ZFfwgldYF+1A0dfAkMIJj97W2RbT2oIrPN8f1FFEuY+EVuTkHGnx0ds7yqdKwc7CxyC3WjBlcPsKxGSgUGg5JPdEy5fv6Qx0VK4xWUhNUHtEYdQwdimfWzp8kLjHbFHRCTACkG1uhkhd3AVqwa3vO0WP0wpF++iixDONhn+U9UriwHiHxpZd/NFvBcSjOs9GNHXLcq66c9Ighf2XhFycHN86Cp/YZ2CPl67PZQCvvFnxrj0WQobFn6aKUerJxH9oOGr2ZmdGELR4Rf9qFXIw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(230922051799003)(186009)(451199024)(1800799012)(6666004)(4326008)(31696002)(8676002)(8936002)(6512007)(53546011)(6506007)(54906003)(66946007)(66556008)(66476007)(6486002)(498600001)(36756003)(38100700002)(31686004)(86362001)(26005)(44832011)(2906002)(2616005)(83380400001)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXJDOVBCcGVCRzI0SmZYbzFFVmw2UVc4RktlaEE2YythWG1DQ2N2ZkowQ1oz?= =?utf-8?B?ckRqdFJrTUJDOTJZaXRMTVliY3loWUtCcjBOOWI1bWlHZitjSnJOOUdCQlNG?= =?utf-8?B?eU8zczNRQ2FvM3puZ0ZlamZ1NitKeDVHK2VpUDVtY21vY21LKzR3NkVkZlJa?= =?utf-8?B?ZERabEw4SU9sazJiRXljMDM5eXhWZ2ZDczFjOVJEVDV5dFlFK3MyKy9wVy9k?= =?utf-8?B?Z2lIMzZ3WXc4c1N4NDRLZ3RJUVRvTjNGc2F6bDNhanhQSVJWN3lmZ2Y2ZFla?= =?utf-8?B?d0JIUisyampieDBXTndGRFR2QzU2MG9zeVRPUW9RVTNNMXMzN0J4THY4Vmdl?= =?utf-8?B?VFZ1MWZRU3FsN3ZVZkIxczRpbGZHaGsxRGdUMDZST1QxSytzSW9qWE90cHhZ?= =?utf-8?B?ZC8wZk1PdnR0U2c5RzlSaGxJSlM3QW1mZE5jRFVXSGZJaG9SUUJOWGhYdGZ3?= =?utf-8?B?aG82Vk53SWlIRjRIVU1aYXJQUGxxWWMrYzVEV2VqWG81NnVMVDVJL3BZZEpZ?= =?utf-8?B?TTYrcHkyUyt6ZDFxK01wZFJ1Sk9OZ214S2IvS1Nya0d1RkNXUzhDTlBzNGI4?= =?utf-8?B?U0xmVWcwa3R3THJIWitLQjREbWx3M3pjbE9Rb29LeEc0WGpUVzZZOTVzcjY3?= =?utf-8?B?NXJsZFFFOCtWczBEdW1yeVZxeEQxMXZaNGFWTm02U2lpaCtPT0k0OTVDajQy?= =?utf-8?B?aUlEakZSMkM4WmZlK0dYNUVXMUcwUXBNaWpqMEtxQTlITmVnTzIvVkxudDUr?= =?utf-8?B?VTdVY3lKaG10Tjh4YW00dVI2NEF3ME9zZVhlcElVTWZMeG5QcVFpaFNFVllr?= =?utf-8?B?U2Zna0pOUk0yaG1Yem5VcGlaYzB1TVdTS2NtS0FRS0MvbkcwcW1zUVhZZHNZ?= =?utf-8?B?cFJqZUU2WWV2cWNqcjJQWjNYcVVGaFFaNjFUTjBhMTVCZVBDOFVKWUgyQ1BQ?= =?utf-8?B?YWJ0Vy9xZldMSFBhRFdHZ0tMZlYrN1l2WmdxOUsyTFFMRThrc1JLc1AxKzM0?= =?utf-8?B?MUVvc1NBTHowZ1RXa0JodXdIK1NyM1ljM3BDanR0YXpWY2NjemVKTmQrU1l1?= =?utf-8?B?RmFDeVU0U0t3RG0rQmJWQnlIQ0owZGhFcjRHU3dabU1jNnRuVWhYMVlIWE9x?= =?utf-8?B?UXQwNUwwTUJoSkhOcDRJR3l5Sy9oREZnM3pQaUVPUEp3NzdwZHZvL0NWSWJQ?= =?utf-8?B?QUNtSG5xMmd0RnovSXdWKzd1SWFJYy84S2NJWlUzeUVlWXhxd1ZCRytKSVds?= =?utf-8?B?cXh5Y2VjMWVQczFvWUdtaFhHdjJHcllUQS9RWDFiMlNPdi82b3RQSGF6WE9t?= =?utf-8?B?RmFCZDBVL3A2aFhWVDQ3ZmNoUk4xd1cxWXNSRkZSNDVxcEdkN2FYU0RoeFdS?= =?utf-8?B?SHVncWpYMkR1OEI5NEVRUDhQL0p6S0hlUzdnYUYzbkp0cWZDclNEcmV2VktW?= =?utf-8?B?WnVOUlV0L0NRNjUreSsyMVI1TEpZVUhKTy9JTk43dE1pdFVLMXZrS2hKU2Fz?= =?utf-8?B?b25oZzF0ZlVPL2g0MHE0SVhWa2JJa0k5VzdKM092S29wdXlPQ1RqbUhwY0gw?= =?utf-8?B?cWc4a1dDbUY2YWd1N2hPR0xIbDczUHpaMnhJc0JTSXJRWnh1ZjZRczF6bGh2?= =?utf-8?B?eG5yQ3FTOHRDWTVXb2gxWjdoN21wWmFDakJFM28vWG13YWMyRysveGRIOFNz?= =?utf-8?B?WmF4a25tWWNoZmEzb3psTisrQ1pOL1k4K0cwM2o3L1J0T28xSldrbG0wK0dm?= =?utf-8?B?SDVlNGlxckRxdUhuc3F0RFZ4Sjk5V3hVbEEyejI1aTNhQjJhaTlGZXI1S2or?= =?utf-8?B?OUhMTklGL3A0eEFXZWNScGxtR01VWFlXSWFIQjdpa29iTGdPenZBc29DeDJC?= =?utf-8?B?K2szanJoSU5kTmp4NWF1ekx3OVZrRSt6TjdKU3Z0OUNGeC9GWFQ4UzFVcjNv?= =?utf-8?B?QlVseitMeDhNakpTY3BOMzhLNGVlRlJYd0JDbVE5Vmo3S3BzT2g0Tk9WN3FY?= =?utf-8?B?QzJ5VXBHUXFWb1pNQTBwL3hMM05mVitvMUZaVmZIYjAxZXNGRmtLWEV2S09v?= =?utf-8?B?d2VDUGoyOWE3SjRMaEdXUkVTRys4MTB5a2VqZWlCVDZZVUVyTDhxUi9xWTd5?= =?utf-8?Q?JKrE=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb2b2188-3003-4e74-bbf5-08dbef5fad30 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 15:44:01.3106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XWT4nYYtMdOyAbnQ5N6DhI8rioefN4XQCIRegdzk0yBgytD9r/XJm8p50mD0DmuO X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5986 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/27/2023 1:12 PM, lihuisong (C) wrote: > > 在 2023/11/27 20:19, Ferruh Yigit 写道: >> On 11/25/2023 1:47 AM, Huisong Li wrote: >>> Add hash algorithm feature introduced by 23.11 and fix some RSS features >>> description. >>> >>> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") >>> >>> Signed-off-by: Huisong Li >>> Acked-by: Chengwen Feng >>> --- >>>   doc/guides/nics/features.rst | 26 ++++++++++++++++++++++---- >>>   1 file changed, 22 insertions(+), 4 deletions(-) >>> >>> diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst >>> index 1a1dc16c1e..0d38c5c525 100644 >>> --- a/doc/guides/nics/features.rst >>> +++ b/doc/guides/nics/features.rst >>> @@ -277,10 +277,12 @@ RSS hash >>>   Supports RSS hashing on RX. >>>     * **[uses]     user config**: ``dev_conf.rxmode.mq_mode`` = >>> ``RTE_ETH_MQ_RX_RSS_FLAG``. >>> -* **[uses]     user config**: ``dev_conf.rx_adv_conf.rss_conf``. >>> +* **[uses]     user config**: ``rss_conf.rss_hf``. >>> >> Feature title is "RSS hash", it can be two things, >> 1. "Receive Side Scaling" support >> 2. Provide RSS hash to application >> >> When this document first prepared RSS hash value was always provided to >> the application when RSS enabled. >> So intention with this feature was "Receive Side Scaling" support, hence >> 'RTE_ETH_MQ_RX_RSS_FLAG' added. >> >> Later providing RSS has to the application separated as optimization, >> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for this >> support. > What should I do for above two comments？ > To tell application how to use it? > Just tried to give some context. >> >> As the intention of this feature is "Receive Side Scaling" support, we >> shouldn't reduce configuration struct to 'rss_conf.rss_hf'. >> >> Instead perhaps can expand to: >> 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf' > >  I just pick their common part.😁 > > ok, will fix it. > >> >> >>>   * **[uses]     rte_eth_rxconf,rte_eth_rxmode**: >>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>   * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``. >>>   * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, >>> ``mbuf.rss``. >>> +* **[related]  API**: ``rte_eth_dev_configure``, >>> ``rte_eth_dev_rss_hash_update`` >>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>   >> ack >> >>>     .. _nic_features_inner_rss: >>> @@ -288,7 +290,7 @@ Supports RSS hashing on RX. >>>   Inner RSS >>>   --------- >>>   -Supports RX RSS hashing on Inner headers. >>> +Supports RX RSS hashing on Inner headers by rte_flow API. >>>   >> This should be clarified with details below, not sure if it required to >> limit description to rte_flow. > But this block like rte_flow_action_rss is from rte_flow. > And ethdev ops doesn't support inner RSS. > So I think it is ok. > Yes it is supported by rte_flow, and '[uses]' information should already clarify it. >> >> >> And I guess similar confusion exist with the providing hash to user. >> Need to check if rte_flow implementation puts hash to mbuf along with >> doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload, >> and update below items accordingly. > Do we need to tell user how to use it here? > I feel this document is a little simple and main to list interface for > user. > In addition, it is better that the more detail about RSS should be > presented  in rte_flow features. > No, I am not suggesting to add more detail. My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be correct, ethdev APIs checks offload flags, but does rte_flow implementation check it? My suggestion is double check that piece of information and fix it if required. >> >> >>>   * **[uses]    rte_flow_action_rss**: ``level``. >>>   * **[uses]    rte_eth_rxconf,rte_eth_rxmode**: >>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>> @@ -303,9 +305,25 @@ RSS key update >>>   Supports configuration of Receive Side Scaling (RSS) hash >>> computation. Updating >>>   Receive Side Scaling (RSS) hash key. >>>   -* **[implements] eth_dev_ops**: ``rss_hash_update``, >>> ``rss_hash_conf_get``. >>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>> ``rss_hash_update``, ``rss_hash_conf_get``. >>> +* **[uses]     user config**: ``rss_conf.rss_key``, >>> ``rss_conf.rss_key_len`` >>>   * **[provides]   rte_eth_dev_info**: ``hash_key_size``. >>> -* **[related]    API**: ``rte_eth_dev_rss_hash_update()``, >>> +* **[related]    API**: ``rte_eth_dev_configure``, >>> ``rte_eth_dev_rss_hash_update()``, >>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>> + >> ack >> >> There is an inconsistency in the documentation but I think it is good to >> use '()' when documenting API, like: 'rte_eth_dev_configure()' > +1 will fix it. >> >> >>> + >>> +.. _nic_features_rss_hash_algo_update: >>> + >>> +RSS hash algorithm update >>> +------------------------- >>> + >>> +Supports configuration of Receive Side Scaling (RSS) hash algorithm. >>> Updating >>> +RSS hash algorithm. >>> + >>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>> ``rss_hash_update``, ``rss_hash_conf_get``. >>> +* **[uses]     user config**: ``rss_conf.algorithm`` >>> +* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``. >>> +* **[related]    API**: ``rte_eth_dev_configure``, >>> ``rte_eth_dev_rss_hash_update()``, >>>     ``rte_eth_dev_rss_hash_conf_get()``. >>>     >> >> This document describes features listed in the 'default.ini', so we >> shouldn't have above. >> >> And I don't think RSS hash algorithm update is a big enough feature to >> list in the feature list, perhaps it can be embedded in the RSS support >> block, what do you think? > Yes it is not a bit feature. > so put it to RSS hash, right? > Yes please.