From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E72CA00C3; Wed, 7 Dec 2022 18:21:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51B19410D7; Wed, 7 Dec 2022 18:21:51 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 580D240156 for ; Wed, 7 Dec 2022 18:21:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SEaytMl8YFrmWSapza8n34VEX9ahzspjYmXo1tnHqlIh1lroLVVwQnYnCU2icP2mPgsp2AZC0NRzbQ7xbQJlliLJ2KcgCpnYPzn5MHFWg3YkvDR/J+mJew4cd8427i2OMes4M/rEgKW79Qf6rYy9rUi4caYvrjqqtlEDyq0qp/kjtWuhgxvjLu3TKdNjuQfSZ4yeiw6h3VnoCjbBmqYoF5piFzNJEAzE34JXyNhHgUPv+7BN6cRXjLXjInZxo9ljNMXkNQTAZ4dvF7kOnR+F5xH+dETuLTCpzeq1rsjEj0JosHelmNxdoPEC/x3V5u1GEsFTDADzd3ewGr2qcjqYgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z8i0cKGtSGhjjjL3LMnEJWo4PvQ6bE2UyB/VMBSdg8A=; b=MzI/bIU+f5IJbXneJz/FB0bQ5kUOXaOXN1eNbeca2jxAnr+lsUbEHA1L3v8MO5H4GOBs9rWY6HOeLd86F/bTAJrW17GY11FXTNJ/0f7JoRzOMLDtjnzqjFrAk37GduvvDmppXfbUYmbLPIAUBB5JNPWzIMSUGE0w6/HdZcPyxAd/cr95NI6+mYZYe3hlunmuW4E6NZxKbUOG2TTqJtxez0/q4XKkeLIMvSUvO9XKLDcmyjLY+n9W2dDbTapFycecGrKN6yqLUVMzb3DtnhdYPlQdhPO7XTdQvQ3RuZwGOsDiVgDD6NkDqQqSeOGTCTfKXLBhLaGkvnva/n5HSqO/rw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z8i0cKGtSGhjjjL3LMnEJWo4PvQ6bE2UyB/VMBSdg8A=; b=brBkgbpBr2lxEAOmDeqr2MCI/fSosQGMV6vsQBMXn2089gzRcYUlwKiQwfijsj/WwmxHdWyMfUpEbKX06xKOaXzkkDPzM14owj4O4FV2Nu88QB1YG6CoHuCdoV4rz4BvY+QkZJRZQFAVXnadlmbt8Fsj09wf3stsbNnSH6bSTOo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4054.namprd12.prod.outlook.com (2603:10b6:610:a6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 17:21:47 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%8]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 17:21:47 +0000 Message-ID: <8971e9a0-e9d0-4da8-1cc3-a1ffbf6ad8f0@amd.com> Date: Wed, 7 Dec 2022 17:21:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] net/failsafe: Fix crash due to in-valid sub-device port id Content-Language: en-US To: madhuker.mythri@oracle.com, grive@u256.net Cc: dev@dpdk.org References: <20221116121121.1969-1-madhuker.mythri@oracle.com> From: Ferruh Yigit In-Reply-To: <20221116121121.1969-1-madhuker.mythri@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0154.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4054:EE_ X-MS-Office365-Filtering-Correlation-Id: ee1e175b-3d30-491a-81b4-08dad8778530 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 81FkCxuYov4EpLNxdwkPVgtGF3KhUl9BpcIKOBosNGi6ovkrhB+BT6aiiE8C+tw/LY4Qa1EVh8bhwDZWI/nHqMD26Sjw6ZecXekJ4NQVORClgWjzpVwscV1m826+A2uUrlkBQcc0NYL+3S0lQibPwM3cM+pM0gXoWLCCewkT1BI715Fqw7ZtQECRpK0ewbmZMvLQhk/h6sKlDDnz5p10vWuwQq5wlkzExtQbNxbFPaDLmQrkK3lwq9nlyUh2ha0xeh3g/jjDGM1N/Jl9R4QGgQAAYQg7xP7WmfnVCukZFbDaTc/EB10vQ2G0s613CYG3ouin6iTZV4MB9lFx6nZfShimRRTnU++3avrzGqCGr+6o86tBc/exvCOqWaUS7LXWY87fq5nWNqijQ+gAo07qEzzEvoiwqTpSHPB1aLIhnZdYsWwDb5XdRw0HTXxnnfJ97YjRU5RoihV7CXH9MRzjBOxCjNE6gYxPPr9uIHH+pHE6sh8ruiDdpaqBBfa92KWebFvl67d2hytgVYD7dEpv3UQJvBC7iblqcCgXhejtvpoYFTZzxmyccm5sS+MXBQHDz883da2nLbX1PLiqPAh5GJM4ATvGkC/QlWBKU1UgiV8RZes0N6lRukLqFN+mpxsWAh/Xx8ADQjw4uVh99kqSwzW8SmuP7nW3f1pGvwsb6R32UvKt0jVtg1r0a4IzJUBuPlSkqPdGaLaOg2JQ3SJl7QVdGQrM0yccyyQ6tfppKUk= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(376002)(366004)(396003)(136003)(451199015)(83380400001)(6506007)(2906002)(186003)(86362001)(26005)(31696002)(41300700001)(6512007)(316002)(44832011)(2616005)(53546011)(8936002)(36756003)(5660300002)(66556008)(31686004)(66946007)(66476007)(478600001)(6666004)(4326008)(6486002)(38100700002)(8676002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2RMQnA2Zyt4cGpaMWszaHNnMXZiYW5tVU42Z0p1a0pJRjcwcGc4dllObU83?= =?utf-8?B?MHN5ZDlrQ2NtbmhxY25EaEZUQWJ6MHJWUkZpY1ZqV0Q1amM3eWZOZG03VmRE?= =?utf-8?B?eTZuZmgxSWsvS0lwVnFGOTFVQ2ZSbWFkWkVVWnFzMzJxcHJNZlkvR3ViQ3Yr?= =?utf-8?B?Wjh5S3hKNE9EUnJpV05ReWEzWmRqa2hqd3VlRmZZNHRjcXAwVlExUFI0MDlr?= =?utf-8?B?aElCSW85R2EydE85Vm1MamlaTWtZZ2I3VGVPdGxMb2tJNmI3czJiclhkUDFs?= =?utf-8?B?dkEwVVhPTUxBMEFYbXZvSXF6REhlN25zYWZhZ1JRMk1GNS82b29QS3BBaVZJ?= =?utf-8?B?RkN0d3V3aENxd0M4Q2hYeGlxTC9RQVUwam5wR2grQTlPQXdHL3dxTjNGNFI2?= =?utf-8?B?eHYzNE9Xczl5VlBrbFl5RldUY05FaUtVUStWRy96a0k0UnN0ZXdBdDJwRUk2?= =?utf-8?B?bzRhbHJqdU5CeE1iMzNjSjNicVA2N3VPN05rNnR3MVNyaXJKY2EwbXFHTE95?= =?utf-8?B?RS9TUytvOURYY0QwZnBFYzNWMWJmK3Bka1pablNtR0VDYWtpWXZWZTZzMnhW?= =?utf-8?B?VWMxcmIxVkZ5UGJOMDVpdmNQV3FEZ2VQdmVTYTNnTlZXOFcyN3FsZmpHWExE?= =?utf-8?B?NEdmU0tlR04zVWUvR0ljWVJJckVMeGtseE5nQnNlVDJvZlFvMURDQmRLWWVu?= =?utf-8?B?U2x4TVJCMlNocnZ0em44VGp4c01RYTc1bGFPMEtDSG9RTjh3THFlRHNBdGdI?= =?utf-8?B?UkUzQWl4Tm9oYjJHZUVBa0NaQkJSTUo3UEtJd25JbmZiT1doOVlqWjg4MnNs?= =?utf-8?B?bEJXUVlxQUZSY1loY0F4WCtVc014K1NrWURVT2xXdUdTZy90dnpQc1J1eGRH?= =?utf-8?B?Q1hGcFJSaTdSUWs2endmdTdkYVhyZzI4OW5TZTh6WjFCQkNCZlNZUnRlbmo5?= =?utf-8?B?dllJNWZjYTBIaDczbHZoY2FEMG5MZ2Rvc1dxcjVmMGZlemptT1dES3FIdktp?= =?utf-8?B?YlRFYVNCdUNuL2crVHVlUmc3SERFWHpIOXFXeXFtY2h6Y0lUT2ViU01PRWd4?= =?utf-8?B?ZjFvSG1nRGlydFFBdFh4dGZ1b1piRmtVdjRUZVp4L2RocTV4TVdSTWtOY2hQ?= =?utf-8?B?MkYrYVQ0OStSNVY3Ty9rSHRORkhBTmdMUm90S3JKSnFPa2FJWDVwU1RXZHZX?= =?utf-8?B?YmFvdkREWldIRXlQS1QybFVzUEgxYk5QdWpNM2lpQ2ljOVMxYkJVNVluam5H?= =?utf-8?B?MkVlTm81bkUrSlg2eXRsYnY2Y3dyMFpLL21DYUttaTUzTVQ5OUhORHJXamgx?= =?utf-8?B?VnkwY3ZxNCtsYk5YYTd0cGtrWWw1Nk9SdTMxQ3dMcitmMUtiSWJZOUtvV21k?= =?utf-8?B?bXhZL3pDNXJSSzhmQzhCSmhMUkY1MnRtOWVYSndMSDJod0lhVzR5MGN2Y01j?= =?utf-8?B?Q0M0QVM1WlJvOU00NTlrVERqVS81WUVCWnJGb3M3TWFDOHI0YzV4Tm44SWVu?= =?utf-8?B?RXc0eGFXMkozWlFuRGxPdmpmNDdKSzN3UXVmSnRDN0JLUlh2YzFva1F1Rkc4?= =?utf-8?B?RnpJYVVwdlJmSUZ2QzB0Nk13RGdmRXNvUlIxSGFYM0xOYWppMWVrMFpqTC9H?= =?utf-8?B?N3dEQzh6cURiOXdIMFFVaWZyUlZ1NEZYdUM5b085b3grOGFmVTlZZXB4enRx?= =?utf-8?B?OWVjNXhzdllaQ00rQ3hrcjM1MFJqRDNVWFRkSGp2b09yL0FpaXd2Y1dmUGdh?= =?utf-8?B?K3gvNVZ2QzcyY0plZFNNR2xDb3JGWUZrUmgxVkJjZGFGdlpVMm5qWTJUTGZp?= =?utf-8?B?akF5Ni9XUExBR1ROWjZ5NHhnNG1scjlFVTdQUGVJcTZvYm5LdE1sc0QvRFgw?= =?utf-8?B?QkVLS2MwYmE0cTRoVnVUS0EzMDdPNkF6TmErelRjTWpDdUlZODU3STFmb2pT?= =?utf-8?B?bEpBWkpVMVkrd2ZrbmdYK3lNOHhtTTcvenBOYmJydHBZSmZzeThnNFJIK1lx?= =?utf-8?B?U0p3bnlXZWNMUW9kSWJNc24zdURLY01PY1FsZzJtdjMrWHdxR3BYYVRLT2Fi?= =?utf-8?B?NmZDT21oQkJnQXU3ZUN4Qlk0RGNtQkxQSVQ3L215MnUraTFJWnNYUHN4ZHFB?= =?utf-8?Q?lYq0l74i5O5KwrN6yJGx4fSIa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee1e175b-3d30-491a-81b4-08dad8778530 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 17:21:47.6414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i3+ClAFWeJ6fFQNs6QCVPr6vz0VyT4oi9TSkdqHs5uHaEUN1I0pNLZseBu9JiSYi X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4054 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/16/2022 12:11 PM, madhuker.mythri@oracle.com wrote: > From: Madhuker Mythri > > Crash occurring while the DPDK secondary processes trying to probe the > tap-device, where tap-device is a sub-device of Fail-safe device. > Some-times we get in-valid sub-devices(with the in-valid port-id's), > due to which the IPC communication does not get response and causes the > communication failures b/w primary/secondary process. > So, need to validate the sub-device(tap) while secondary process probe in > the Fail-safe PMD, to avoid such issues. > > Bugzilla Id: 1116 > > Signed-off-by: Madhuker Mythri > --- > drivers/net/failsafe/failsafe.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c > index 32811403b4..51d4440ac7 100644 > --- a/drivers/net/failsafe/failsafe.c > +++ b/drivers/net/failsafe/failsafe.c > @@ -361,6 +361,9 @@ rte_pmd_failsafe_probe(struct rte_vdev_device *vdev) > if (sdev->devargs.name[0] == '\0') > continue; > > + if (!rte_eth_dev_is_valid_port(PORT_ID(sdev))) > + continue; > + This is in the 'FOREACH_SUBDEV()' block, why an invalid subdevice provided by the macro? Instead of invalid port check, should we fix the macro? Overall I am not clear why this defect occurs, bugzilla report also don't have much detail. Can you please provide more details why this defect happens?