From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 801215323 for ; Mon, 1 Apr 2019 18:23:41 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id k11so12880407wro.5 for ; Mon, 01 Apr 2019 09:23:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=EvYbLxWgMaAubeZw2dsxV18j5t9EyLTe+KvGm02aYKA=; b=KmEO2lSP7zbImKD5/lgPYDkgPnVtq3yG5Agynz7aRaSherBOPzgj3rDf/lXzkI+PSe 4RAntyhtfQ0a4Daarx/QBipbWZPoydPBZqALJlEkKg30msCsR4xxgiz7Ve4O0RloJsbH WGaBzp9hmafMtEQIBO39FKNT6TMC15StAwjVi3tXW84OstNKiTpfQiYmuxW64ECxsFNK CJae0oEjI3h5qONLSHhZRpr9hBR4GYUd6L7xPsfnbtgcEEYNE1eVKJLLRY8Jd8VAy8SL dVC0L52fuXJlrAp0ratoOlTmpielbqdICzV/kwlv7kt1optngcQnbKGzljo3jA+spMAc GW/g== X-Gm-Message-State: APjAAAX9jwvAVuyhrMteUDFMHFQJbUzHPySzC9QcVX2X3IZ0n+la/4bV EBkHZ8FjbGqTHbaQY3XZBtw= X-Google-Smtp-Source: APXvYqx/E0MZtjfAnXwuKEKEBO6sPa8y923ZIsbFv1mSnEdBsH/PWnHBVXnJIKXbdPgw7mFtCNcBHw== X-Received: by 2002:a05:6000:1209:: with SMTP id e9mr22067802wrx.35.1554135821105; Mon, 01 Apr 2019 09:23:41 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id z17sm6708485wmc.7.2019.04.01.09.23.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 09:23:40 -0700 (PDT) Message-ID: <8977f5e0dc0fa4c5ecf9e973c6d751b797458d9f.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , thomas@monjalon.net Cc: dev@dpdk.org Date: Mon, 01 Apr 2019 17:23:39 +0100 In-Reply-To: <20190401160833.38213-1-bruce.richardson@intel.com> References: <20190401160833.38213-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 16:23:41 -0000 On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote: > The test-meson-builds.sh script correctly detects the source > directory and > builds the native builds successfully in a directory outside of the > source > tree. However, the paths to the cross-files are not prefixed with the > source directory path, so the cross-builds all fail. Fix this by > prepending > the source directory path appropriately. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > devtools/test-meson-builds.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh > index e3f19a01a..b3b5cfbb5 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then > # compile the general v8a also for clang to increase coverage > export CC=3D"ccache clang" > build build-arm64-host-clang $use_shared \ > - --cross-file config/arm/arm64_armv8_linux_gcc > + --cross-file $srcdir/config/arm/arm64_armv8_linux_gcc > =20 > - for f in config/arm/arm*gcc ; do > + for f in $srcdir/config/arm/arm*gcc ; do > export CC=3D"ccache gcc" > build build-$(basename $f | tr '_' '-' | cut -d'-' -f- > 2) \ > $use_shared --cross-file $f >=20 Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0AFFFA0679 for ; Mon, 1 Apr 2019 18:23:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4DD55681; Mon, 1 Apr 2019 18:23:42 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 801215323 for ; Mon, 1 Apr 2019 18:23:41 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id k11so12880407wro.5 for ; Mon, 01 Apr 2019 09:23:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=EvYbLxWgMaAubeZw2dsxV18j5t9EyLTe+KvGm02aYKA=; b=KmEO2lSP7zbImKD5/lgPYDkgPnVtq3yG5Agynz7aRaSherBOPzgj3rDf/lXzkI+PSe 4RAntyhtfQ0a4Daarx/QBipbWZPoydPBZqALJlEkKg30msCsR4xxgiz7Ve4O0RloJsbH WGaBzp9hmafMtEQIBO39FKNT6TMC15StAwjVi3tXW84OstNKiTpfQiYmuxW64ECxsFNK CJae0oEjI3h5qONLSHhZRpr9hBR4GYUd6L7xPsfnbtgcEEYNE1eVKJLLRY8Jd8VAy8SL dVC0L52fuXJlrAp0ratoOlTmpielbqdICzV/kwlv7kt1optngcQnbKGzljo3jA+spMAc GW/g== X-Gm-Message-State: APjAAAX9jwvAVuyhrMteUDFMHFQJbUzHPySzC9QcVX2X3IZ0n+la/4bV EBkHZ8FjbGqTHbaQY3XZBtw= X-Google-Smtp-Source: APXvYqx/E0MZtjfAnXwuKEKEBO6sPa8y923ZIsbFv1mSnEdBsH/PWnHBVXnJIKXbdPgw7mFtCNcBHw== X-Received: by 2002:a05:6000:1209:: with SMTP id e9mr22067802wrx.35.1554135821105; Mon, 01 Apr 2019 09:23:41 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id z17sm6708485wmc.7.2019.04.01.09.23.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Apr 2019 09:23:40 -0700 (PDT) Message-ID: <8977f5e0dc0fa4c5ecf9e973c6d751b797458d9f.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , thomas@monjalon.net Cc: dev@dpdk.org Date: Mon, 01 Apr 2019 17:23:39 +0100 In-Reply-To: <20190401160833.38213-1-bruce.richardson@intel.com> References: <20190401160833.38213-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: allow building outside source dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401162339.kWF3hgVylxuu78m9RpnkbwLJX2BKqYsTB5Ir17DJPR4@z> On Mon, 2019-04-01 at 17:08 +0100, Bruce Richardson wrote: > The test-meson-builds.sh script correctly detects the source > directory and > builds the native builds successfully in a directory outside of the > source > tree. However, the paths to the cross-files are not prefixed with the > source directory path, so the cross-builds all fail. Fix this by > prepending > the source directory path appropriately. >=20 > Signed-off-by: Bruce Richardson < > bruce.richardson@intel.com > > > --- > devtools/test-meson-builds.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh > index e3f19a01a..b3b5cfbb5 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -69,9 +69,9 @@ if command -v $c >/dev/null 2>&1 ; then > # compile the general v8a also for clang to increase coverage > export CC=3D"ccache clang" > build build-arm64-host-clang $use_shared \ > - --cross-file config/arm/arm64_armv8_linux_gcc > + --cross-file $srcdir/config/arm/arm64_armv8_linux_gcc > =20 > - for f in config/arm/arm*gcc ; do > + for f in $srcdir/config/arm/arm*gcc ; do > export CC=3D"ccache gcc" > build build-$(basename $f | tr '_' '-' | cut -d'-' -f- > 2) \ > $use_shared --cross-file $f >=20 Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi