From: Thomas Monjalon <thomas@monjalon.net>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH 5/6] net/ngbe: add log type and error type
Date: Thu, 18 Mar 2021 13:04:03 +0100 [thread overview]
Message-ID: <8979253.LjAW1eiC8C@thomas> (raw)
In-Reply-To: <20210318093208.17824-6-jiawenwu@trustnetic.com>
18/03/2021 10:32, Jiawen Wu:
> +#ifdef RTE_LIBRTE_NGBE_DEBUG_RX
> +extern int ngbe_logtype_rx;
> +#define PMD_RX_LOG(level, fmt, args...) \
> + rte_log(RTE_LOG_ ## level, ngbe_logtype_rx, \
> + "%s(): " fmt "\n", __func__, ##args)
> +#else
> +#define PMD_RX_LOG(level, fmt, args...) do { } while (0)
> +#endif
> +
> +#ifdef RTE_LIBRTE_NGBE_DEBUG_TX
> +extern int ngbe_logtype_tx;
> +#define PMD_TX_LOG(level, fmt, args...) \
> + rte_log(RTE_LOG_ ## level, ngbe_logtype_tx, \
> + "%s(): " fmt "\n", __func__, ##args)
> +#else
> +#define PMD_TX_LOG(level, fmt, args...) do { } while (0)
> +#endif
There is a discussion about using ethdev debug flags in PMDs.
Please check the mailing list:
https://inbox.dpdk.org/dev/20210318014234.2255366-2-qi.z.zhang@intel.com/
next prev parent reply other threads:[~2021-03-18 12:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 9:32 [dpdk-dev] [PATCH 0/6] net: ngbe PMD Jiawen Wu
2021-03-18 9:32 ` [dpdk-dev] [PATCH 1/6] net/ngbe: add build and doc infrastructure Jiawen Wu
2021-03-18 12:04 ` Thomas Monjalon
2021-03-19 1:45 ` Jiawen Wu
2021-03-18 9:32 ` [dpdk-dev] [PATCH 2/6] net/ngbe: add device IDs Jiawen Wu
2021-03-18 9:32 ` [dpdk-dev] [PATCH 3/6] net/ngbe: support probe and remove Jiawen Wu
2021-03-18 9:32 ` [dpdk-dev] [PATCH 4/6] net/ngbe: add device init and uninit Jiawen Wu
2021-03-18 9:32 ` [dpdk-dev] [PATCH 5/6] net/ngbe: add log type and error type Jiawen Wu
2021-03-18 12:04 ` Thomas Monjalon [this message]
2021-03-18 9:32 ` [dpdk-dev] [PATCH 6/6] net/ngbe: define registers Jiawen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8979253.LjAW1eiC8C@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jiawenwu@trustnetic.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).