From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E45C4A0561; Thu, 18 Mar 2021 13:04:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 969CD140E93; Thu, 18 Mar 2021 13:04:08 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 1E284406B4 for ; Thu, 18 Mar 2021 13:04:07 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7C8FF5C00FD; Thu, 18 Mar 2021 08:04:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 18 Mar 2021 08:04:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= NOKpMYWr7JSDsqUrsJowXXg2OaySG7oChkFB9pqeKSc=; b=3MZKpOKGLIEuhBjj S9JwN4LVuwOMQ7L0WJW9GG3SKo+hHmjPPOEDbCGtzWGecyVtXFLf47ieFtrTFtiD 1a6i0AmDmF0CrLC9evSqSpgrvIoOKi5zaS5Novxf6nFzjIaVjo+TZGV2UaWhOsJJ F8HXrE4TD5DZl2ulS1sbTQ6J2scsEGpk94V95m68eB+mM3YgYQCaumt/fcHggyfT xcMHTffhjYPWEQe0Eu94hhaIEciR0UjyN71Wo3+DMWzkZgXxe+dR8ROyeQOf/EHm JuzbSbI92bhKJ53zQwaTBaP1bPs3vL9zPYhnFLHUEFsLtJGhCobs0vu/l9sXwESm JyAItQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=NOKpMYWr7JSDsqUrsJowXXg2OaySG7oChkFB9pqeK Sc=; b=GIyBr2+LZbzwZgUIwX3Xog/AR69rK8/773YZVo5fgaar0wEeGc8eabN++ 0LsDuT0Iat5ElT23lOjHUZSUBcHM8dcujdG9uHvnV+vvms1/S4JHkITny48+IX18 OGKxN23o5J5WerVnGXra/StuFuEGUwOEZII5y/gJu/peMpDD+kw/+yCM+idR/8Wb 1xYJ4m+tuKkzrDygFfu5ZGG9I+pMoBGG3q8UG902rBbtjBfgs+EBldLfiQHMnm8c ueqU2G7jBVoXxIiEebNO+idUP9GE4O6JNBPPqezTYL9Pw2wrGqDJ04MBLTkKnGBZ pMU4t5uFEbPGNS6vQ+4U5Zr3T0fvg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudefiedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 41AF3108005C; Thu, 18 Mar 2021 08:04:05 -0400 (EDT) From: Thomas Monjalon To: Jiawen Wu Cc: dev@dpdk.org, ferruh.yigit@intel.com, qi.z.zhang@intel.com Date: Thu, 18 Mar 2021 13:04:03 +0100 Message-ID: <8979253.LjAW1eiC8C@thomas> In-Reply-To: <20210318093208.17824-6-jiawenwu@trustnetic.com> References: <20210318093208.17824-1-jiawenwu@trustnetic.com> <20210318093208.17824-6-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 5/6] net/ngbe: add log type and error type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/03/2021 10:32, Jiawen Wu: > +#ifdef RTE_LIBRTE_NGBE_DEBUG_RX > +extern int ngbe_logtype_rx; > +#define PMD_RX_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, ngbe_logtype_rx, \ > + "%s(): " fmt "\n", __func__, ##args) > +#else > +#define PMD_RX_LOG(level, fmt, args...) do { } while (0) > +#endif > + > +#ifdef RTE_LIBRTE_NGBE_DEBUG_TX > +extern int ngbe_logtype_tx; > +#define PMD_TX_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, ngbe_logtype_tx, \ > + "%s(): " fmt "\n", __func__, ##args) > +#else > +#define PMD_TX_LOG(level, fmt, args...) do { } while (0) > +#endif There is a discussion about using ethdev debug flags in PMDs. Please check the mailing list: https://inbox.dpdk.org/dev/20210318014234.2255366-2-qi.z.zhang@intel.com/