From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "Liu, Yong" <yong.liu@intel.com>, "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "Wang, Zhihong" <zhihong.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Ding, Xuan" <xuan.ding@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting
Date: Fri, 17 Apr 2020 17:17:59 +0200 [thread overview]
Message-ID: <898c34d3-f6fc-9695-3e7e-26221726a741@redhat.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E635351F0@SHSMSX103.ccr.corp.intel.com>
Hi Marvin,
On 4/15/20 9:30 AM, Liu, Yong wrote:
>> @@ -2120,7 +2119,7 @@ virtio_dev_configure(struct rte_eth_dev *dev)
>>
>> /* if request features changed, reinit the device */
>> if (req_features != hw->req_guest_features) {
>> - ret = virtio_init_device(dev, req_features);
>> + ret = virtio_negotiate_features(hw, req_features);
> Why do we need to change virtio_init_device to virtio_negotiate_features
> here?
You missed to reply to that question from Xiaolong.
Regards,
Maxime
next prev parent reply other threads:[~2020-04-17 15:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 12:55 Marvin Liu
2020-04-15 1:06 ` Wang, Yinan
2020-04-15 7:24 ` Ye Xiaolong
2020-04-15 7:30 ` Liu, Yong
2020-04-17 15:17 ` Maxime Coquelin [this message]
2020-04-19 1:35 ` Liu, Yong
2020-04-19 3:08 ` Ye Xiaolong
2020-05-06 15:07 ` [dpdk-dev] [PATCH v2] " Marvin Liu
2020-05-07 10:53 ` Maxime Coquelin
2020-05-07 14:18 ` Maxime Coquelin
2020-05-08 1:54 ` Wang, Yinan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=898c34d3-f6fc-9695-3e7e-26221726a741@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=xuan.ding@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).