From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 7EAEF214A for ; Thu, 11 Feb 2016 12:48:01 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id p63so64697788wmp.1 for ; Thu, 11 Feb 2016 03:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=hqMvVDUvED01vE4MssupWQg0wR3g0cz9IFWAbiEOJ/o=; b=c/zGwo8q6ob6uScSU6orrjyyq+JDbH5pE9Es5HbXYtWjHG5dBRpiLh1c9xYvDpXVyj /iRMnbJp8fRMnteLRgb51TKyTndPrkTMc9+4HAzFKtdbaUBfMeU8C6MtiTvX/35pygkd 6F3vlNxCMbFqGrc9gXMY5Q1WhZCdIuV+SSMPOXYsL/P+Cw5B1+BLEj2Yzwny1TeK1CnH +yh21TScrMDt9R1TQGYhUwSb0gLZ0FLOutQ6KYJel3orsKve4FvBn8xr9lU9aMy/bFuL Q+NO+SKvalVQmnJylpHu4UmaDFs/WNHYCv+Uga9T6GvoHbQJXRmDG9vAeH4fik5bY4s4 SGnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hqMvVDUvED01vE4MssupWQg0wR3g0cz9IFWAbiEOJ/o=; b=ANHUNxwC5rAZDk+mPp6fn2/Bju1ohVcMdJf/R3LB57gLx2olbp1atkKuIcM9N0aJFu j3wntH7QY111tlHHFbtdhMhdCAsfFXfge66jCoOF9UqxQ7Zn1LwTBeSxSXm6fyUV6RH0 v9h1FFRYjLtDoN5sZg62Ura90wv86/S5si2aUOdpD9G8zFct6QhkYQve4EI9VmZMXZDq Q6xmRaQLSZFDveP83YWnphOw98BoVmZREUGNg+0QakVPk75T9ratKMNHFFa+dLds9G8B i68H5BgGUJHXzSfeZnOAN9//u3wX7qkpPbt/ewOv3sRDkQyfnfv2R7Kx/STKyYA5wALd cbVA== X-Gm-Message-State: AG10YOQg4oESjTRQJf1hFyuTssPwYZIpmILI6qcK+ehbcsx7kcseKFma3VxbaDAhdWsu95yU X-Received: by 10.28.46.84 with SMTP id u81mr18109882wmu.102.1455191281318; Thu, 11 Feb 2016 03:48:01 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id ka7sm7201518wjb.8.2016.02.11.03.48.00 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 11 Feb 2016 03:48:00 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob , konstantin.ananyev@intel.com Date: Thu, 11 Feb 2016 12:46:33 +0100 Message-ID: <8996069.HySAWEmhf4@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1454040645-23864-3-git-send-email-jerin.jacob@caviumnetworks.com> References: <1449242086-19051-1-git-send-email-jerin.jacob@caviumnetworks.com> <1454040645-23864-1-git-send-email-jerin.jacob@caviumnetworks.com> <1454040645-23864-3-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH v3 2/3] lpm: add support for NEON X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 11:48:01 -0000 2016-01-29 09:40, Jerin Jacob: > --- a/app/test/test_xmmt_ops.h > +++ b/app/test/test_xmmt_ops.h > +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) [...] > +#else [...] > --- a/lib/librte_lpm/Makefile > +++ b/lib/librte_lpm/Makefile > +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > +SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_neon.h > +else > SYMLINK-$(CONFIG_RTE_LIBRTE_LPM)-include += rte_lpm_sse.h > +endif [...] > --- a/lib/librte_lpm/rte_lpm.h > +++ b/lib/librte_lpm/rte_lpm.h > +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64) > +#include "rte_lpm_neon.h" > +#else > #include "rte_lpm_sse.h" > +#endif Instead of defaulting to x86 SSE, it would be better to replace "else" by "elif X86/SSE". I suggest using RTE_ARCH_X86 or RTE_CPUFLAG_SSEx. By the way, what is the minimum SSE version required?