From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 975F858FE for ; Wed, 1 Aug 2018 10:08:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 01:08:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,431,1526367600"; d="scan'208";a="69156953" Received: from mmaksimo-mobl.ccr.corp.intel.com (HELO [10.252.3.157]) ([10.252.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 01 Aug 2018 01:08:18 -0700 To: "Eads, Gage" , "dev@dpdk.org" References: <9184057F7FC11744A2107296B6B8EB1E446F5E4D@FMSMSX108.amr.corp.intel.com> <71fb8cbc-cdc2-f1c7-dca9-ecbfac42e453@intel.com> From: "Burakov, Anatoly" Message-ID: <8998f634-3b26-17dd-b840-285f2d0833ab@intel.com> Date: Wed, 1 Aug 2018 09:08:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <71fb8cbc-cdc2-f1c7-dca9-ecbfac42e453@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] Cleanup of secondary proc fbarray files? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 08:08:21 -0000 On 01-Aug-18 9:01 AM, Burakov, Anatoly wrote: > On 31-Jul-18 5:36 PM, Eads, Gage wrote: >> As far as I can tell, DPDK does not destroy secondary process fbarray >> files – i.e. those whose names end with “_”. With enough >> secondary processes and memory usage per application, and after enough >> repeat executions, these can take up a significant amount of space. Is >> the user expected to clean these up themselves, or is this a bug in DPDK? >> >> Perhaps this is a good candidate for including in rte_eal_cleanup()? >> >> Thanks, >> >> Gage >> > > Good point, this was my omission. This should be done in eal_cleaup(). > Actually, it should probably be done at fbarray allocation :) We put a lock on those files, so those that are unlocked we know can be removed safely. We do the same for hugetlbfs files at init. I will submit a patch for this for 18.11 some time later. -- Thanks, Anatoly