From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D73DA426AE; Tue, 3 Oct 2023 12:59:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61EEB402CC; Tue, 3 Oct 2023 12:59:12 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 1020E4026B for ; Tue, 3 Oct 2023 12:59:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GDhqkCG3wIX7A7voQuHaU7CinrJ036fR7rR8DJNTeIfhGx860JwFTO3S75jfFoKdZwZ0P6Evh260cTStZ+gQxcIHGJXd+qTxtwza/+T6LtNACB1LPInvRfeahPEht+Oc647OrRcijd2ZVaKwPxoofWgod609w2k8vYNGwAkXchcc2tozl8Kf2SE4B+Lwbte1PdDtZ8/MhIissj9eHRdSEU16uyp831RBTml1KblwPqlaV6Bq6oX61IMdDo913mkxU4GK3isco7kzgr5gff661s72R4Lja0/uNfVLYWxbSxNjUf2sPR7hNflS4OGczijsuhU2t3XawPTE9HmkzmTRMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8eg+0c19uP7+5rcsD+5lcvRU1rBT74aly2HJmKHQAmI=; b=UnF9lFJwfgR9uz8mNM4ofeWqzylZhrq3whzNGxV8bPFjm1KaMtktE/DVPsXIsDDZDAEh9KGejUh/1I2jV6yfYDaSnzwiU1xmbn9fj3B6wBzB7KfFbKWVz+KXL+YD5pi7Ufs47GBbzzEUHEg9v25kiViAvAup0t2ZntgOltgF+2THGW3MHcc8L3808wv0dauejSgDqJdyle/xnXLmT2YisMT0xS0zJcqD7ewfaNT1H24GptKb+ZsMd8MhBkXz/bHSk166rsu8ENlT//KVMqNj368S+QrxGh76Yp8flR4SjuE5vJ6Pxhho3UEvVB0ZOe1oHmQxUSuRHhKbWf/Uy5rEsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8eg+0c19uP7+5rcsD+5lcvRU1rBT74aly2HJmKHQAmI=; b=0uSSG4xY33rnSNsKhTDTLe7SpymWmgwz3Dcx4+KEdotFufLZdCxx2KdMh+HKYD8sQfqthEOQnbmCP2/IBgJZDUFQIHFLenYuQ16RmEKJBBqUEsFHkgyXUv9dkJYts3V6urBlK7phIe1ztLVo0L5R2ov89LD4Xtk5XXGLNEZmsVQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4256.namprd12.prod.outlook.com (2603:10b6:208:1d2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Tue, 3 Oct 2023 10:59:09 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.024; Tue, 3 Oct 2023 10:59:09 +0000 Message-ID: <89a6ef0b-1cbf-4ebf-b0d8-c900271152da@amd.com> Date: Tue, 3 Oct 2023 11:59:04 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests Content-Language: en-US From: Ferruh Yigit To: Stephen Hemminger , dev@dpdk.org References: <20230929163611.62691-1-stephen@networkplumber.org> <20231002183730.301163-1-stephen@networkplumber.org> <20231002183730.301163-2-stephen@networkplumber.org> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0030.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4256:EE_ X-MS-Office365-Filtering-Correlation-Id: 43aae4d6-533e-473d-255e-08dbc3ffc4e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vm/PDKJ2ysBd7kAJnAaF10NAvTgL3eq9/c3TN1F20dYE9FpbpWyB25yYbudZrCtCO6ek3dyru0Vo5RHKGj1YxbVeSu7D+ia69OVNIqh/TVhTT2H3/XVAnUW3JZv/TAJzYZDtGulsmAdAKghotI7d4Wh2s3jx2XUDb2Q7MMCAqq4Aqm2HmqrE8SVHqSxlc9UNJnD9ic1kG9Y0hrET6U9zgpnlYJ1+964aTq/crxR1JH9dBicUm8hqcS1yDeeBf3RbiPkS1Z0+NQoxLRsO3Qt6/ZgTD0dQg3fGyHgV9Z9SVaDfCpyFbKSQCjDQscynKhSmkt4vVahBzYca66ZjA/gXk7v9eHMNZxBKNawQsi8ZcBnsuHR/iQrAbmjSeOU7R4j7m3TSuOjHFIzl59F5LNDnhu1Z14eLZ9Id7KGypyYq2dbEr6urrjEJGF88Z4GpW7GAl7vYaj8kM0Sj4qGG0NpNAOR+c6gjr7nGpI/2//UgPLW0nfZK9d+2ipERVxrMG2R6eQudS3ZEvNV/Om0AgRsId+hUk5v5ObkBi9Fxg/0tWoMzHROXN+R/3lj77VOwL2OgMiciHyTIVx/zv4oshVemfKlnaCLIfzYoKicXdpDT61JSczwbNK2MPN4yRXYPtR3ek1EEX7UaM28zYi1yz/1VwA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(366004)(136003)(346002)(376002)(230922051799003)(186009)(64100799003)(451199024)(1800799009)(4744005)(2906002)(86362001)(31696002)(36756003)(38100700002)(53546011)(316002)(66946007)(66476007)(66556008)(6512007)(6506007)(41300700001)(6486002)(2616005)(478600001)(6666004)(31686004)(8676002)(44832011)(5660300002)(26005)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1kyRVhoTUhiNFVNRExERTNpaVVTRGlYOFVBZTM5d1pjMEo4ckF3cmdkTUV0?= =?utf-8?B?dFJFNEdIaklxbmdtMHBjZWxsVDNTWStXbDIyYWVLdnp1ZjRYSHJPVUNBaTRW?= =?utf-8?B?NTdtZ0M5Mks2NjZDTWdHUW1SYWcyb1pTWWpqSExKWmxiOXN3NG41bnYra1BB?= =?utf-8?B?c1lHN3lyWkQvRUtnMGhscWFLMW45T2ZVUTU5SXhzS2t3NDMra0lEbmVkbWRM?= =?utf-8?B?RjhDN2tNcS9pUDBFbFFHcXlGcjFPa1QxNzV5Z0tjMXd5MHE4R1dSOHJpejda?= =?utf-8?B?SDFFb2hKUVFnbjE0QUZyVGkyY2pGSDRxdE1KZXFBSnNJUnVndUNYMEZ6Rlda?= =?utf-8?B?Tys5RGtBOWV1VFlUbXhqV0V5SWpFWk5XcWp2T1lmZ0VxajNtRmNtbGw0TGdw?= =?utf-8?B?eGQ0bzNYY3duMmxCMHRJaEZGYWxHYXY3UjloUzU1Y1A0NHJEQldCUVpDb0Z1?= =?utf-8?B?Y0diY3dZeWV0VnVpQjlkbU5sNGl0QmpiaEM4UTBTbXllZmhheVlyRUx4Vjhs?= =?utf-8?B?ay9hZnUwM2h2eFJwL1M4cUlUQTJ1RTUxbUg1OFRPUTFPWHNXN3drYTZoaWty?= =?utf-8?B?cGltYzFwVUozT3FZUTBLbEJIMnF0NUcvTkxjVnFVMUlFcmhKWVErd1pxYlh6?= =?utf-8?B?UDM5UmoxeC9CbnZPQmkwS3pEV05IQ09GUGdGVG1YUlhDVllwNmRRODNJSVdI?= =?utf-8?B?WGliWkRsRDYxekdIekd4WVY3MUtLbDVveHBHSzIxamNXN1YyWmVlWjg5Rkdl?= =?utf-8?B?SU1rYWF0M3lyUkd3bUZ2U3ZEUXhZUkowbkpGampZSkZybkkyK2xEcGZtL2lS?= =?utf-8?B?MXlIVU9wcVdCQWJtbHY0T0ovZEdWbFdWQlZWcWJFUk85aFhyMlh3YURZWW9X?= =?utf-8?B?SFNYMXdibHZPZFFySlJrVHRaRm1tcVVzMjYzVS9Rd1dqdjJ2VGlJbDlCVGdR?= =?utf-8?B?cjFTS1FNd3VpS2hNM1NySnk2c2gvaTBKbjhZNk5DZUlCN2UyZmpoc0JKTmYx?= =?utf-8?B?eXB6QXpvK0t4Y0MyNktOMVAxYnVaNWdEWDRXY0ptR3AxYVpRM1R6cDB3V0cv?= =?utf-8?B?aE9pV2JyZFptSUZOcSs3aXgvbGlvNEJ1Ty9ZaHdGNmkzQVBYUmI2YUwycFFQ?= =?utf-8?B?SjBhV0h3dU42K0h2clppd3BFUWZ6K21kTVlzNm55dHFtQVZZRk9ZTncvalBu?= =?utf-8?B?Rllwa1Zod1loekxTdXJ3Z1lFZXpBbnBLd1I4ck8wN3poQ3BLTXBuTUxqd1ky?= =?utf-8?B?a1BtTXJWWWo3YXlEQzJkSzJhVlorb09jamtJUUdoVytIN21FQUZVakRsbDI5?= =?utf-8?B?b01aZ1JHbXpMSlVFSEEveGlBMVpXT3pvcXhWWC9KVlMrSDN5RmVIWEk3aFp4?= =?utf-8?B?RC9qVWRQQlNaK0tKUjRYUHQrc2NOWmxaaUZTTzAvb2RiclVQcXFKaGtnTm9L?= =?utf-8?B?N1U4c1hjTHZiZUJJZi8yM0EwdDVKOGExTW14VVJobmswc0FrVnlnVHVQQkd4?= =?utf-8?B?c3ZRYkhpMTNKYWNibjdTYzlwY3Zqc3lQaHF3MW4wcDJwUWJtb3o2eDhLV1c0?= =?utf-8?B?eVlVMFJpQ0ZQZzJTTXZRRlZHZWp6WkVYOHVXa1JyYUtBK2RBMkwrRjFkZmlu?= =?utf-8?B?aDFQQVI0RHdkNElBNmpFVUo5QUswc0ZTa2ozTkFzakNsMnIyMm9XcVBJWVh6?= =?utf-8?B?Njk4TFErait6U2FBa2JQRTNsK2hQQk85K2RmZGRUNXVaSUNaUUlyZWdFYzBC?= =?utf-8?B?UFlxbXBtRlFMNXBmeWZvMnl5OExoWWU4b3lRTE1uSkpBM0dZdWRSVUFWdFlJ?= =?utf-8?B?OHoxbmpXRFB1bWdqUStqWEtZZjk0aWprTXFPYWZ3QjAxcVI3SEZMUDB4Nncx?= =?utf-8?B?OGMrd2RmcmNVMWYzbU40MHpIaE5MSVdId0NwNUVQUVZ1VExLaENURVRFbXlp?= =?utf-8?B?ZnRjb09CUlpQcncyVE1TV24xVVpDRVIzd1dVeWUwNlpkLzhxei93Y3ltQ05U?= =?utf-8?B?cmIyOVVpdEJHNUlVdTRHUy91ekpoZEo0MWZsQ0hVSTZzK0VZWjN3czcrTXNv?= =?utf-8?B?OFcwcmxXODljbGp4cUhXZFNoOEFTZlZsT21VVlAyQ01obTNIUHVuQ1NZY2xW?= =?utf-8?Q?h2tIPopN4toYdc+uhr01FmMYq?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43aae4d6-533e-473d-255e-08dbc3ffc4e3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 10:59:09.2232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RR9kc/1PCCZ1HPs0zNezZIzjBumvPJ5Ikju14Y7OWnsJu5k03Y152B2VcrZ3a/zm X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4256 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/3/2023 11:47 AM, Ferruh Yigit wrote: > On 10/2/2023 7:37 PM, Stephen Hemminger wrote: >> Some of the ethernet address formats which were invalid will >> now become valid inputs when rte_ether_unformat_addr is modified >> to allow leading zeros. >> >> Also, make local variables static. >> >> Signed-off-by: Stephen Hemminger >> > > <...> > >> @@ -61,10 +60,8 @@ const char * ether_addr_invalid_strs[] = { >> "INVA:LIDC:HARS", >> /* misc */ >> "01 23 45 67 89 AB", >> - "01.23.45.67.89.AB", >> "01,23,45,67,89,AB", >> - "01:23:45\0:67:89:AB", >> - "01:23:45#:67:89:AB", >> > > Why these two are valid now? > > And I guess second one is still not valid, but first one is parsed as > [1], is this expected? > > [1] 00:01:00:23:00:45 > > Ah, I guess it is taken as "XXXX:XXXX:XXXX" format, but number of digit is not enforced, so "1:2:3" is a valid format, should we add this to API documentation as example format? Or is this unintended side effect?