From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 40D7E2BA7; Thu, 21 Feb 2019 12:05:15 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 71D68307EAB3; Thu, 21 Feb 2019 11:05:13 +0000 (UTC) Received: from [10.36.112.16] (ovpn-112-16.ams2.redhat.com [10.36.112.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E7AA41001DD0; Thu, 21 Feb 2019 11:05:11 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: stable@dpdk.org References: <20190219105951.31046-1-tiwei.bie@intel.com> <20190219105951.31046-2-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <89a85a96-5922-4829-4634-75ecc78c2ec9@redhat.com> Date: Thu, 21 Feb 2019 12:05:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190219105951.31046-2-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Thu, 21 Feb 2019 11:05:14 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 1/5] net/virtio: fix Tx desc cleanup for packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 11:05:15 -0000 On 2/19/19 11:59 AM, Tiwei Bie wrote: > We should try to cleanup at least the 'need' number of descs. > > Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_rxtx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c > index 4c701c514..b07ceac6d 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -1943,7 +1943,6 @@ virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts, > > /* Positive value indicates it need free vring descriptors */ > if (unlikely(need > 0)) { > - need = RTE_MIN(need, (int)nb_pkts); > virtio_xmit_cleanup_packed(vq, need); > need = slots - vq->vq_free_cnt; > if (unlikely(need > 0)) { > Reviewed-by: Maxime Coquelin Thanks, Maxime