From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3A29A00C3; Thu, 12 May 2022 16:13:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4841410F2; Thu, 12 May 2022 16:13:53 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2046.outbound.protection.outlook.com [40.107.220.46]) by mails.dpdk.org (Postfix) with ESMTP id C552840DDD for ; Thu, 12 May 2022 16:13:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PmXBTl6LEn9xTUCdlCBU8o56PWixlLc4wJvXlVQhumHkwxV0iiBeT3TwqmOLDILA6ugtUqpu9dxL1x5KrHI7g6LWe6EFsPLWtbM9TFOyCBKUf1r7rX0P6slbM3K5zfk8hIgVQWoW8xbyZ0I8dW6BDILXaEbVsgJdxuh9ZmIaxRSm6T6OoWBr11UXbbVUFBGAKT8PYuO+xK5A4hZ8dH0OgUb8JU6a58keK94Uho0a02GGitEAU1D7nB1MeklXCaO4ZYSMmssZA4XJHoQ4tM2I89oOdvDhVfIqwdh68nkZJeg3Qyy2LTaEdA1xMF6BE+a4LDb52L7bmmrm67t1F7Dv9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=knEsoEIXoBqXo/IODRqJTMNw++Yi+nyo+7UWsjjaPPg=; b=H4x81UM2zil08i9TBluHLrf2jK6yNmOBq9/YPA47tJiEISSr27a07Gs3ZPvw5NiwQQy2zjKGeyCpdFNeazjlCKsVWBEBiPbKcToMDV163LJCrImhy0vM3oCei8s8oEPNTQCycPOB74gp6/zqDocDe/t37ceqPbu717I7Dk14TMMX4iNpeRVTR/VQyjGFC9Ig1Qv61JYaOOMxmj8O3LifQhPRvt1fXc73NbX+Y6tlvE7RbL3LHZdsFD6F3+ZAbMy3r0H88UY5wsuQAdJx/Gg0Duc852db0DQPW+HAAy0NmsVs4Zy0ETyz0DoUL9WvI5GwbIc4An4j3oEVbVKmj6HRkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=knEsoEIXoBqXo/IODRqJTMNw++Yi+nyo+7UWsjjaPPg=; b=LowdtGWcQ3mXi9Sh82qrGHq2+aiecWM6IbCdsdUkcBf3vpt1ieS3gytJeYCloCvHh57tL7t4x/Ljk1eeXpNlLbhMi6/MACdFxxhSzCLJlLXUj3jT0+yAhUVfyKTANtmJPPwsxmjv1Pb1mNHfNWfr+/I8AlY+H1KamHwhq3GZt+A= Received: from BN0PR02CA0013.namprd02.prod.outlook.com (2603:10b6:408:e4::18) by DM5PR02MB2649.namprd02.prod.outlook.com (2603:10b6:3:46::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Thu, 12 May 2022 14:13:50 +0000 Received: from BN1NAM02FT038.eop-nam02.prod.protection.outlook.com (2603:10b6:408:e4:cafe::91) by BN0PR02CA0013.outlook.office365.com (2603:10b6:408:e4::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 14:13:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT038.mail.protection.outlook.com (10.13.2.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5250.13 via Frontend Transport; Thu, 12 May 2022 14:13:50 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 12 May 2022 15:13:49 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 12 May 2022 15:13:48 +0100 Envelope-to: humin29@huawei.com, dev@dpdk.org, thomas@monjalon.net Received: from [10.71.116.223] (port=57023) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1np9Zc-00026H-Te; Thu, 12 May 2022 15:13:48 +0100 Message-ID: <89b75780-dfd3-06b1-cceb-4980eacb533f@xilinx.com> Date: Thu, 12 May 2022 15:13:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/2] ethdev: fix enabling RSS behavior inconsistent Content-Language: en-US To: "Min Hu (Connor)" , CC: References: <20220228032146.37407-1-humin29@huawei.com> <20220406065701.27738-1-humin29@huawei.com> <20220406065701.27738-2-humin29@huawei.com> From: Ferruh Yigit In-Reply-To: <20220406065701.27738-2-humin29@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2d02d7a-80a6-4600-d2dd-08da3421a32a X-MS-TrafficTypeDiagnostic: DM5PR02MB2649:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iTjGaZFWRrmoQO01qsAHwMcDPz0SFRdGGTIr5+0WpsbACK8gt70sEtoLr8d8UmYdQuC3lVXHGHeXENr8zZFiJs8a16kwgvAVtQZV114pZFWcufs6ucHL8vWVhHezBshAR1UbM9oZMTpHnSykKuIcF4AZt2jldinD3WVIeFEMRYRkyAXTb5PwGGxnXgMhhTcqSqZDkG+Ad49o7rZcwfYwv3VBGtWQtlYVrp+yDWqgi/CEzpD4/wQHcXY569/LhIbv/c/gUZFHq9tOhq+JvgYxbtZX0WrXP+beVk6TmDFLE+Hdi1ZPiFD1BXBlZera6/TsajxDDLv446kPO5oMfX2v06F0J/LsTB4bo4bTMky4sWB9NV450KQyZ0tshcwnFH5sB537iKPOmE8v1ea9oqfdon6omZVf4FghWFCVH39bDvOonDt2wBEkm+BG8w0liI0OArex8BBw4U1/lIVOwPHA3hvHrGVC4dQToVm0sRSmPCNfPx5Ht0knDOKEX9c/IYCiNyDhy2bbt+MpZEUNRcssbYnFcDx44lTLkTGnz5VEIhUV337j4bdlHAob+0jNJQmhuvxUw6Y5YZy8iv/Oskw8PBKRoP2e2J9A/P/N90qB/IzmSpQeCZxNDu3YkUwAD9co//m5Peei3O/DFSgA9xqFjMvYUOq1aC1fS48OJS8x00jULQ7LuPp37PEFLpft6aVTJ68r2Vdvypt15BLAS5nASLm8sndogjLKTyrNzyyAmTQ= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(356005)(186003)(36860700001)(508600001)(31686004)(2906002)(2616005)(44832011)(4744005)(26005)(36756003)(336012)(426003)(82310400005)(47076005)(40460700003)(110136005)(9786002)(5660300002)(31696002)(8936002)(7636003)(70206006)(70586007)(8676002)(4326008)(53546011)(316002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 14:13:50.0685 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2d02d7a-80a6-4600-d2dd-08da3421a32a X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT038.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR02MB2649 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/6/2022 7:57 AM, Min Hu (Connor) wrote: > From: Huisong Li > > The RTE_ETH_MQ_RX_RSS_FLAG flag is a switch to enable RSS. If the flag is > not set in dev_configure, RSS will be not configured and enabled. However, > RSS hash and reta can still be configured by ethdev ops to enable RSS if > the flag isn't set. The behavior is inconsistent. > > Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") > Cc:stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) Reviewed-by: Ferruh Yigit