From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 570241B00C
for <dev@dpdk.org>; Thu, 25 Jan 2018 14:45:56 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
25 Jan 2018 05:45:54 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,412,1511856000"; d="scan'208";a="22495815"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
([10.237.220.48])
by FMSMGA003.fm.intel.com with ESMTP; 25 Jan 2018 05:45:53 -0800
To: Neil Horman <nhorman@tuxdriver.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
References: <20180122235458.28562-1-stephen@networkplumber.org>
<20180122235458.28562-9-stephen@networkplumber.org>
<20180123122706.GB22398@hmswarspite.think-freely.org>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <89c33483-d9c0-a07e-53af-fdd1de1886e1@intel.com>
Date: Thu, 25 Jan 2018 13:45:53 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20180123122706.GB22398@hmswarspite.think-freely.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v7 08/15] net/ixgbe: use rte_eth_linkstatus
functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jan 2018 13:45:57 -0000
On 1/23/2018 12:27 PM, Neil Horman wrote:
> On Mon, Jan 22, 2018 at 03:54:51PM -0800, Stephen Hemminger wrote:
>> Use the new helper functions from eth_dev for
>> handling atomic link_info update.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> ---
>> drivers/net/ixgbe/ixgbe_ethdev.c | 96 +++++++---------------------------------
>> 1 file changed, 17 insertions(+), 79 deletions(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index 58217680c29c..7b74cbe92c0d 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> @@ -20,7 +20,6 @@
>> #include <rte_debug.h>
>> #include <rte_pci.h>
>> #include <rte_bus_pci.h>
>> -#include <rte_atomic.h>
>> #include <rte_branch_prediction.h>
>> #include <rte_memory.h>
>> #include <rte_eal.h>
>> @@ -787,58 +786,6 @@ static const struct rte_ixgbe_xstats_name_off rte_ixgbevf_stats_strings[] = {
>> #define IXGBEVF_NB_XSTATS (sizeof(rte_ixgbevf_stats_strings) / \
>> sizeof(rte_ixgbevf_stats_strings[0]))
>>
> Getting some build errors here:
>
> CC igb_ethdev.o
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c: In function ‘eth_igb_stop’:
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:1510:2: error: implicit declaration of function ‘rte_eth_linkstatus_set’; did you mean ‘rte_eth_xstats_get’? [-Werror=implicit-function-declaration]
> rte_eth_linkstatus_set(dev, &link);
> ^~~~~~~~~~~~~~~~~~~~~~
> rte_eth_xstats_get
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:1510:2: error: nested extern declaration of ‘rte_eth_linkstatus_set’ [-Werror=nested-externs]
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c: In function ‘eth_igb_interrupt_action’:
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:2831:3: error: implicit declaration of function ‘rte_eth_linkstatus_get’; did you mean ‘rte_eth_xstats_get’? [-Werror=implicit-function-declaration]
> rte_eth_linkstatus_get(dev, &link);
>
Compiles fine for me, any change that you are using old version of dpdk that
driver doesn't use rte_ethdev_driver.h yet which these functions are implemented in?