From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07863A04FF; Wed, 4 May 2022 16:27:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C17F40E2D; Wed, 4 May 2022 16:27:38 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 15D594069F for ; Wed, 4 May 2022 16:27:37 +0200 (CEST) Received: from [192.168.108.214] (unknown [188.170.87.12]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 08D6A82; Wed, 4 May 2022 17:27:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 08D6A82 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1651674456; bh=avrPwxWHSaW6/2E3ZPFCREOCsbWgKdDV7UOj+Rh02o0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=f5SFyvc++oOanHzmcmXEOQzRAx0pgTmz/42etUdb06j4YkAvnNi3d6OnlCz3P1Tuz iT+pldkLeoYGsM1sQ0Ou5WNjWZHxu0121jfgCVJzDSOm+duL5y3+I6UAPbqIfn/Clq NSp056qnn1jyt+u5qSeaU6vWjF0189Z8LXBEW0h0= Message-ID: <89c8d22f-6a44-030a-f813-fc7c25882a35@oktetlabs.ru> Date: Wed, 4 May 2022 17:27:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH 3/8] vmxnet3: add rx queue usage count utility Content-Language: en-US To: Pankaj Gupta , jbehrens@vmware.com, yongwang@vmware.com Cc: dev@dpdk.org References: <20220503042257.15626-1-pagupta@vmware.com> <20220503042257.15626-4-pagupta@vmware.com> From: Andrew Rybchenko In-Reply-To: <20220503042257.15626-4-pagupta@vmware.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org rx -> Rx in summary in accordance with spelling in DPDK On 5/3/22 07:22, Pankaj Gupta wrote: > Count the number of entries in the rx queue for debugging. rx -> Rx As I understand debugging is not the only purpose of the API. > > Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2 > > Signed-off-by: Pankaj Gupta > --- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 +++ > drivers/net/vmxnet3/vmxnet3_rxtx.c | 30 ++++++++++++++++++++++++++++ > 3 files changed, 34 insertions(+) > > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c b/drivers/net/vmxnet3/vmxnet3_ethdev.c > index eb65499cf2..a76796716b 100644 > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c > @@ -294,6 +294,7 @@ eth_vmxnet3_dev_init(struct rte_eth_dev *eth_dev) > eth_dev->rx_pkt_burst = &vmxnet3_recv_pkts; > eth_dev->tx_pkt_burst = &vmxnet3_xmit_pkts; > eth_dev->tx_pkt_prepare = vmxnet3_prep_pkts; > + eth_dev->rx_queue_count = vmxnet3_dev_rx_queue_count, Please, put it just after rx_pkt_burst to preserve the same order as in structure. > pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev); > > /* extra mbuf field is required to guess MSS */ [snip]