From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D064BA0C44; Mon, 12 Apr 2021 10:04:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7826D4068E; Mon, 12 Apr 2021 10:04:43 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 457264014E for ; Mon, 12 Apr 2021 10:04:42 +0200 (CEST) IronPort-SDR: cKHixLkdOXq0/L+swKUOtOOIHZYUa29/uSw2Kmrir7hvY3AcuBz5LzMjEnr2iVGP7D8ilJ3c72 WAFEnGiAlVPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9951"; a="258110637" X-IronPort-AV: E=Sophos;i="5.82,214,1613462400"; d="scan'208";a="258110637" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 01:04:40 -0700 IronPort-SDR: S7cgxLKHFGyWktzB2PkxIhnv3vlIayGKluqYSRoN7Ntv9eeOZFNmNiD7+0XungU56iDaH3fDn3 S1k2nupF0bTw== X-IronPort-AV: E=Sophos;i="5.82,214,1613462400"; d="scan'208";a="460069585" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.203.254]) ([10.213.203.254]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 01:04:39 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: kirill.rybalchenko@intel.com References: <1616830586-46672-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <89cedfc0-9a44-43ea-2390-7eeb65c1b4ab@intel.com> Date: Mon, 12 Apr 2021 09:04:35 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] examples/ptpclient: delete wrong comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/10/2021 10:11 AM, Min Hu (Connor) wrote: > Hi, Ferruh, kirill and all, >     Any comments about this patch? > > 在 2021/3/27 15:36, Min Hu (Connor) 写道: >> This patch deletes the comments which are wrong and unnecessary. >> >> Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) >> --- >>   examples/ptpclient/ptpclient.c | 4 ---- >>   1 file changed, 4 deletions(-) >> >> diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c >> index 33b297e..878d1a0 100644 >> --- a/examples/ptpclient/ptpclient.c >> +++ b/examples/ptpclient/ptpclient.c >> @@ -606,10 +606,6 @@ lcore_main(void) >>       unsigned nb_rx; >>       struct rte_mbuf *m; >> -    /* >> -     * Check that the port is on the same NUMA node as the polling thread >> -     * for best performance. >> -     */ >>       printf("\nCore %u Waiting for SYNC packets. [Ctrl+C to quit]\n", >>               rte_lcore_id()); >> Acked-by: Ferruh Yigit The comment seems left over from the example this example cloned from..