From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 846B8A0C45;
	Wed, 20 Oct 2021 09:50:49 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 157C6411AE;
	Wed, 20 Oct 2021 09:50:48 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 0C2A9411A5
 for <dev@dpdk.org>; Wed, 20 Oct 2021 09:50:45 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 96CBA7F504;
 Wed, 20 Oct 2021 10:50:44 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 96CBA7F504
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634716244;
 bh=VjrpVp2m7U/VrxNTw0PA9OxACUIdnR9QNWxqs8SJk5w=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=QkDgVeYogKMCq6TJuPJQvMwjzZpJnUYpTNnBXT7ngWcznsZ7SnOXIGanv22QFk25i
 RcUTAPs5NfDeUaXPy6rehzHNYqNLYDtRU1PdKELN/LALjyZmRNZTdkERzFs68Qv7U7
 wVdwUWd2oWTj7Q+WCYmE8bE2sPF98/tj7ZbbodwM=
To: David Marchand <david.marchand@redhat.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
 Maryam Tahhan <maryam.tahhan@intel.com>,
 Reshma Pattan <reshma.pattan@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>,
 Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko
 <viacheslavo@nvidia.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>,
 Shijith Thotton <sthotton@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 "Artem V. Andreev" <artem.andreev@oktetlabs.ru>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, Maciej Czekaj
 <mczekaj@marvell.com>, Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, dev <dev@dpdk.org>
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru>
 <20211019174022.2036272-3-andrew.rybchenko@oktetlabs.ru>
 <CAJFAV8xaZ0zkRvdS-nRwzoK2+ZrBkpRx=Kge7hCJ=aXT-jp-mQ@mail.gmail.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <89d439c3-8a4d-7954-73dc-ae7cd97e1fb2@oktetlabs.ru>
Date: Wed, 20 Oct 2021 10:50:44 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <CAJFAV8xaZ0zkRvdS-nRwzoK2+ZrBkpRx=Kge7hCJ=aXT-jp-mQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 2/6] mempool: add namespace prefix to flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/21 11:03 PM, David Marchand wrote:
> On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko
> <andrew.rybchenko@oktetlabs.ru> wrote:
>> @@ -752,7 +752,7 @@ test_mempool_flag_non_io_set_when_no_iova_contig_set(void)
>>         ret = rte_mempool_populate_default(mp);
>>         RTE_TEST_ASSERT(ret > 0, "Failed to populate mempool: %s",
>>                         rte_strerror(-ret));
>> -       RTE_TEST_ASSERT(mp->flags & MEMPOOL_F_NON_IO,
>> +       RTE_TEST_ASSERT(mp->flags & RTE_MEMPOOL_F_NON_IO,
>>                         "NON_IO flag is not set when NO_IOVA_CONTIG is set");
>>         ret = TEST_SUCCESS;
>>  exit:
> 
> There is one more flag, hunk fixed adding missing:
> 
> @@ -745,14 +745,14 @@ test_mempool_flag_non_io_set_when_no_iova_contig_set(void)
> 
>      mp = rte_mempool_create_empty("empty", MEMPOOL_SIZE,
>                        MEMPOOL_ELT_SIZE, 0, 0,
> -                      SOCKET_ID_ANY, MEMPOOL_F_NO_IOVA_CONTIG);
> +                      SOCKET_ID_ANY, RTE_MEMPOOL_F_NO_IOVA_CONTIG);
>      RTE_TEST_ASSERT_NOT_NULL(mp, "Cannot create mempool: %s",
>                   rte_strerror(rte_errno));
>      rte_mempool_set_ops_byname(mp, rte_mbuf_best_mempool_ops(), NULL);
>      ret = rte_mempool_populate_default(mp);
>      RTE_TEST_ASSERT(ret > 0, "Failed to populate mempool: %s",
>              rte_strerror(-ret));
> -    RTE_TEST_ASSERT(mp->flags & MEMPOOL_F_NON_IO,
> +    RTE_TEST_ASSERT(mp->flags & RTE_MEMPOOL_F_NON_IO,
>              "NON_IO flag is not set when NO_IOVA_CONTIG is set");
>      ret = TEST_SUCCESS;
>  exit:
> 

Thanks, sorry that I've overlooked it on rebase.