From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0049.outbound.protection.outlook.com [104.47.37.49]) by dpdk.org (Postfix) with ESMTP id E73A31B1C3 for ; Wed, 11 Oct 2017 13:08:53 +0200 (CEST) Received: from BLUPR0301CA0032.namprd03.prod.outlook.com (10.162.113.170) by CY4PR03MB2694.namprd03.prod.outlook.com (10.173.43.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Wed, 11 Oct 2017 11:08:52 +0000 Received: from BN1BFFO11FD004.protection.gbl (2a01:111:f400:7c10::1:167) by BLUPR0301CA0032.outlook.office365.com (2a01:111:e400:5259::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7 via Frontend Transport; Wed, 11 Oct 2017 11:08:52 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1BFFO11FD004.mail.protection.outlook.com (10.58.144.67) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Wed, 11 Oct 2017 11:08:51 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v9BB8fwd026038; Wed, 11 Oct 2017 04:08:42 -0700 To: "Tan, Jianfeng" CC: , , , , , , , , , References: <1507519229-80692-1-git-send-email-jianfeng.tan@intel.com> <1507548444-33959-1-git-send-email-jianfeng.tan@intel.com> <1507548444-33959-4-git-send-email-jianfeng.tan@intel.com> <7732f195-64fd-308c-8faf-c1b0e37d3453@nxp.com> <4883d822-9aa0-4b88-048c-35d7e9da9c1c@intel.com> From: Shreyansh Jain Message-ID: <89d68ff6-9eca-185f-c7c0-8aaaf9e514b0@nxp.com> Date: Wed, 11 Oct 2017 16:50:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <4883d822-9aa0-4b88-048c-35d7e9da9c1c@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131521937317369913; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(346002)(39860400002)(376002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(189002)(199003)(377454003)(24454002)(54356999)(53936002)(31686004)(105606002)(50986999)(76176999)(58126008)(8676002)(54906003)(2870700001)(356003)(316002)(81156014)(81166006)(104016004)(53546010)(8936002)(966005)(305945005)(93886005)(2906002)(77096006)(498600001)(83506001)(64126003)(85426001)(50466002)(6916009)(2950100002)(229853002)(53376002)(39060400002)(189998001)(6666003)(6306002)(23676002)(65956001)(65806001)(31696002)(36756003)(68736007)(97736004)(106466001)(86362001)(33646002)(65826007)(7416002)(5660300001)(47776003)(4326008)(6246003)(69596002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2694; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD004; 1:NevNR9Zi5SjmWQLJmmkjA5AS4+1g/50+ezQ/4XU7tYgxiaMghrpM3ao84pRYda7TBS0659nCsT60DM7ZTubWKKKXSJRTM6OFDvfyN3XI8wpRroY30wMe6aOIX5vXRBDJ X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b89e336-f296-468a-5577-08d51098746b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY4PR03MB2694; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 3:br63fYmBhyOImyncsYTXtG2HjvydtoTNfIvLNyfgAXNMgwAMrbzEMjUO/CH0JoHsU6yTfB3zHVs0mCviWZX/YC/GTbNOhiXCY5TTwSLkaTatPjwNtljpdDxFmtL82tyXdF0ccVdtnOVf3r3IMUmmOJd4ERwjgKJWQhwj8v9FbYqa/Bn8bpu5nBlvRm2Lxl2VJmwhWHFCUeEzap+vCFvzKBim4PXLLd2CA9quyKRaF/dybc+QiceJRQo5D0fu5Cx1BruKfy0lStEcgWyMFiPrWjSO9ARVEPXoNU0GX32yTyE41qfxUkBR28lzwF/COihn6t0KSQ1BpryWSrUZ/8TxgzC74bOxuVLAnsRmCf7yb/w=; 25:w8dvORf89RFFBMGjn5wCTm5UEtg8ObDubc8FdW0QWo+UrMFSx/T+V6gbQkyIbkExe+ZE//tzhi0mqUhkbyAhvjyPSTQR3/2sYS8uUduKDN2vXXPfJoYfrPBsQB5hWYc8V3CE12FM/+huIPvX465q8sF6V34YFuqnQ9HIFqEfKKCYcwg9ZECJZA79FbhEWVXPuAnvFnhBpQNOa5F2fvzsYmakXBPDqItwGFCM/Gp7cfaPf10KqaT4nGtfOVXLNV7mSjsBit4h+g/6bgZdJrw+VeUTjfpQ7psPtMWEkV8RYu2Zp7o79OGoE6PN3oW0XJ11nv97kOmVUkLlPlvtTwvacTYmZuGNb0ixUJkhCxPzI5M= X-MS-TrafficTypeDiagnostic: CY4PR03MB2694: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 31:hEoMUg8q+Iav08/TJarhEK2TX75VqOhJJ/ln4lSAZHu0IeyyOKwbTcGX4E8z0yGRgInq1weiQJ24VoplrwQ02GjXaLxKy45yTwh/m0nnHloGnhF5tyBmE/NgKRbBfyK/mD9cZ6xMHuBUtiuHFLYsJIwcv01eI+c4m2eNzh9dDCe3qjNgtl8HG0fSnK0mbzcuEiUYG+Wj62b97vHWgp0fmR07C1NMbVmprhkYpW0Tlo8=; 4:Nu6LO2xnVGkHjFzzjoOk1xKpaMZrUlvt4x4x5j6TieSAwV8ctqDnAxbtU1r/57YkhBCi8Xp68OY+siBxkoVFlVC19ju3hcmQEs8ohSyijDtg2x40civAsxbafnPcgBcxhsoa1us6/2UWt9J6bzFbm8FEA/bF303b0Ww7H1Gz19UWKPXfGQFX0v6yWzOaRFJWUwrOWPy2vc+6yZx4pRpCx63RuKiLPk1c/SJ27zYCq6sqn+lqtBRe0RMIth5LF5ys X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6096035)(20161123561025)(20161123556025)(20161123559100)(20161123565025)(20161123563025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY4PR03MB2694; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY4PR03MB2694; X-Forefront-PRVS: 0457F11EAF X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNjk0OzIzOkVOTGNFNlUvb3E0TlRMT3I1SktBbXhJaHNh?= =?utf-8?B?aUxUZ0Z5bzhKUGh3eURBamRaM0RETXFTc0hNWHg3SlpOVFUzbEY0NGFhS3Ro?= =?utf-8?B?QzFvUlk3OHJqS2hncVUrWWVWZTduZ3JQekdsUTBCbHgrM0M1MTR5YlVZUkZv?= =?utf-8?B?UlE3N25pcW5hd2Exd1JvTkZucnl1UUNxY1J6T0VFaVIwOTJCS0RKZXY4UXFN?= =?utf-8?B?dkFqS0VmVHA0OUFBMWtnTmJlSWZMaU5wTjJDWEJLR2FhYnRCTkprQTF0cDg4?= =?utf-8?B?Z1YzZTBnQ2hoTGp3aHM5YjM5OGRGZ3RtbDNLRWVSdFArd0pZb3FseXJxZGJv?= =?utf-8?B?aGRDbkEwNGU1UlczLzlQaGdEVUsyc1A2OHVid0tNaUtxS3lrWWp4cVBKTXMr?= =?utf-8?B?QkhPTnF5UXViM1dsVmt1OVhEb2s2NG9YL3BYQUZEMllYaUQ1dUpGZE5KU25i?= =?utf-8?B?eWVxV2hzTDM1MDlIOC8wWnhUWFZVSW90aUllZ2RmQ1d1aGVLYW5mZGY4Z2xj?= =?utf-8?B?cnV6S3JtV010OHVRdU9Vc3RMZnpXNHM1TWhQNHdtVU9oWFRGeThRS2RYV1hH?= =?utf-8?B?eGRpTWpFWEs2aXAwY0xtejZkRUhZaXR6RVJQK2F0NHNzM29rTEJKeElaQ3R5?= =?utf-8?B?VjI3REhiTkswdmVrN1pUSGpFL2EyYTJaeHFocXd0Z2dRU0lmczZmNXN1dzBp?= =?utf-8?B?dUVBWkd3Mk5ncUFrMjN4eTh2eGVPREc0VzNqcVpxK1pmdWhSeTlmSmRBRDd4?= =?utf-8?B?V21CRU5HMURLVWFOOE11dE9KYkoxTUlRMXFmSXgvdFJyTlh2SVh0YXZsTUFm?= =?utf-8?B?TXVYeS9KcURDRGNObExYSHRta1RYQWR5WnlnR0JiMDZHUlhOYkVHRjk4RjhX?= =?utf-8?B?ZFVFMmhSYlNxa251dTNZUUJmWFNZRXF5a3hIZG5ZOFJwMndVZ3NrOTkveWZk?= =?utf-8?B?UVFGRTNVTzY3WlpEUTBQdXVETjZXNjFVR2taYzhLR1lBYmVzb05IWlpNL0t1?= =?utf-8?B?UThWVlkraldqRDREdXVoR2Z3dkM4bG5mYS8yL3VKYnVBQnJQZzdNTGE1SzY4?= =?utf-8?B?TzZBTjdOQ3QxbVVpSXJudHNzN2pwWTM5K0pRS25aQVpJU01aK0NtNFRpTmdN?= =?utf-8?B?d1RRakovZzdCK0FMem9xVTBNSUlWQ0hGOFhvOGVQaHhzUzdYSnBVYkVsVWFo?= =?utf-8?B?WElZMUNoNkVLSkZLdkZXL1ExWDNNYlh1ZjRaclVFcVpLMXN4b0xMaVJOak4v?= =?utf-8?B?K0JGOVROaldDRXEzQkhpOXNqaitCUGllMHB5VzN3cjFoWU5aMWNJUGpMeHNJ?= =?utf-8?B?bldmVWhkcUF1VlVBcFZ2OFRPTWhpSGhvckozQlhDdkxqU2Z4Mmc5V0N1Q2J3?= =?utf-8?B?Rm9TM3JYVDY0dnpaYXR1NzQvOEw0eDFtTnFEYWN1TWZQY2xJL3ZtT0hGU3Zx?= =?utf-8?B?RHc4bFFYVHhUcnV0RnUveFh0L0hjWTVtbU5BRG5PRGZiaEVHbDRtSEZBelpu?= =?utf-8?B?R3g5Q2VMSEgwemRhdzJQY3N1MjhNVjVhVnBhVE8xZTI2ZFhadjZ6K3ZIRjBz?= =?utf-8?B?TjFrbGp1Q2dPVHJpN1dxbDFUNmgybWtpTEk2TVBxRHJiZFJLZ1k3UkZmbzFp?= =?utf-8?B?alRpY1AyeVpqejVJQUI2NlBOSUFJZU5GS2M0UkZnVFNNOHd3TnplTXVaUnU3?= =?utf-8?B?SVFHckZDRDhVZXZPOGhtOE5RbVBUYnJQSUtoZGpkc1V4NWdrSWhaY2RTU0FK?= =?utf-8?B?YUxMcUQrWWp6dzJ5T2xnNk5ROUo1dUVHa2hJc29IQ0Q2RW84UXVXVEd0RW9q?= =?utf-8?B?aFZNVzAwNHBXVDRuTDNoY2IzVmlRNm9WYktpUU8zOFI1UG9kSTlCLzZrV1lC?= =?utf-8?B?T0ljTzVXYnluSXhWWXU2cjZQSFIvYUdpNkN1VUhzVzhJd2V3S2MrZE8vbkpl?= =?utf-8?B?MnFSU29HempvLzQyNldORFVFN2hGM0pOOHo5Rk1lUEpXVzNLcXRIN2R1R1hO?= =?utf-8?B?aUZMOU56N1V4bjBLS0RIZ2hpVzI1OTdGbTFnaXRJbGg2S3IyZFJSQkpMVnVX?= =?utf-8?B?L3BWanZUcXRKQm55ZmZscS80RW1hNHZ5T2hMMklOakhFYVUycTFTZkkrOHRQ?= =?utf-8?B?dEE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 6:Jm8mbMvg1N3VzwJkRfLiG/2WUhbSxTPydYO+yVOLLugs0y+q+hnRGPS7FhEBhhYUYp3hUukIjrDSSWJW3v2lEZM4RuLYMs/ie4Ts8z1GVyehy2Tv/MBQlN+WBl3s6q3ji/AW4sLQZ0Ae1SiVk2MUGY5lZPRG5QtL7eThp+8QVgFQuVOBZuaaJYHuGQs/UN7zBx8GCSktAk7GqWG6HW9wXsrfNYBG8gwxV/0nJuq5efbqJEvcjmzJ47gAJWoJol0uz7oGlbWG1UY0txqkd0A6hZizHMLMyUztCYBOdTzig8UkSbHRatU6Ec9+DZl18rxepGTkA35kbDXJ4XMowDjr1g==; 5:RR/QxCdXe3rDJrmoZsDY6zq7zZmTmlEeghG3S9rR+A/7ihR0lOe7YT+YOCiIwdTntCZMGd+7+dy5Igv6QDlh4NUnVhG4BU87AiQj5gdYw9lOMfXemCDmDag6dDNB2GiS7bUfOd/IaLsnivkbcM49DA==; 24:Mv0NLF+z85kj0pqudxR3hY52jEEYPOvOULwQXoYPPyAvk2/FempohH7QD/dmBDTFx9mmbJzGlHBxeB2UmtQQ5q1f+fKL+r3mYWFOtQs8krs=; 7:vmkzBydE5w99JxuvRK/9wN8t4g+0AVWvWYWnd63GQFS8XDy0Y3uXzCaHYpowI1wlAxfNVsdq+oauIM/77/ps7LMDX/YihocGGHzhdQyh5y9nuB1yCTPpefE9ar5gleM1Sk1u+4ihrp5N1RoW161F2Qk/Dn9FVB7dOHjLd2fHLv4xMzxwgfKPmpvsIUq7//5HiIk8RxI81EoL8JepVb+Nk1pX5lh/Ysw40B9Ybs/eXGI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2017 11:08:51.3469 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2694 Subject: Re: [dpdk-dev] [PATCH v5 3/5] bus: introduce new log type for bus drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 11:08:54 -0000 On Wednesday 11 October 2017 04:12 PM, Tan, Jianfeng wrote: > > > On 10/11/2017 2:54 PM, Shreyansh Jain wrote: >> Hello Jianfeng, >> >> On Monday 09 October 2017 04:57 PM, Jianfeng Tan wrote: >>> > [...] >>> -#define PMD_DRV_LOG(level, fmt, args...) \ >>> -    PMD_DRV_LOG_RAW(level, fmt "\n", ## args) >>> +#define FSLMC_VFIO_LOG(level, fmt, args...) \ >>> +    RTE_LOG(level, EAL, "%s(): " fmt "\n", __func__, ##args) >> >> This change breaks the FSLMC bus driver. There are macros like >> PMD_DRV_LOG which are still in use in the code. >> Before removing the above, those would have to be restructured. > > Just try to change all PMD_DRV_LOG in fslmc to FSLMC_VFIO_LOG. As you > are working on that, I will drop it. > >> >> I am already working on converting this logging into dynamic logging. >> Can you skip this work until then? Does it block your work? > > Do you mean you are working on introducing a new log type for bus drivers? A dynamic log type using rte_log_register. So, "bus.fslmc", "net.dpaa2" and so on. I am not introducing LOGTYPE_BUS. In past [1], I sent a patch for LOGTYPE_BUS but at that time I understood that dynamic logging is the preferred way. [1] http://dpdk.org/dev/patchwork/patch/24478/ > > Thanks, > Jianfeng >