From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA24B43CA0; Wed, 13 Mar 2024 16:58:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EF5242E41; Wed, 13 Mar 2024 16:58:48 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) by mails.dpdk.org (Postfix) with ESMTP id AE94442E37; Wed, 13 Mar 2024 16:58:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RRVT4johpyKd7x6LBMmgc1wQRnCaHo4mxinjhh7rcAa2KAd6aBZSpo20uAJiRRe/V8mVFNEG4q5Cvoh60Glsnin3Zo8EHChrnEJeKZgHyslrNuluaeNTSxJAjXhWfMejH8Ec4Pff1UhGcqSDvCDeNqnyq9OJNE7B1C5Y/K1NHByzlVb+jVqMcaQPkTGki5znBp8jfdlynJgh/0/PZTBwu+O3EKoN+2PcEDAnxIbCryVv4l8I7WlO5P+scuVli0Bvw8CLLYvGwvlt7ruRg5NtUEElz04AunalS2BZp4K58P+lvHa3GTZaNati4w7byK1iOovQkNqzsnPP43zoAWUBmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q6jgBxT8Wh3MFTzmWjYQiFnrH9qbRDcqXqG0Iwnhr5M=; b=B5s9wIMcy0gUgYk+J8xYnGjeZonz2yVoyHLxEQMTlfXAHzSebqTNx3kLUmD12Ldbm7t9+I4kvc1pYsOsJIXyj4a85wgckcdeOAAj+MF5vcXjdNP0u5/yi6Q7yVfkz9+1fy8KQ6tz3kE4dTbD6xIiK8BvqS1McT1BDndhEMu8bR38Gweg/W7wRl8H7zSA4weLT3JkO3RuHOIFntIGVYXzHb++Ms9OC+Qvu+4Ga2dX6x1RyQPdxwr2BG9qCFwGnfho90V2Jz94PYa6XqzCIU5AAE8YCbBxrp98AyM5bKm3b4mTOGULd7C4MbwqNZXzcgTx2G7YkleD4gc3sVQ06XtNPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q6jgBxT8Wh3MFTzmWjYQiFnrH9qbRDcqXqG0Iwnhr5M=; b=tCQoG2YOyj8r7YmE9G00sHXQuRYtkyLTkh1yoUGJ5W9v9DM9arJfo32aSGu/Z8Dttl/53BkMic6aN9+tI8V3Xk6+/QncVNcgelWF6M4lfewPHPRz0KkfcqfPJJf7cfa+cyzrnDxQodnRubw6/OK2iPM5dddGUPKqAvapswfjMfQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB9125.namprd12.prod.outlook.com (2603:10b6:510:2f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.18; Wed, 13 Mar 2024 15:58:44 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 15:58:44 +0000 Message-ID: <89da999c-0420-46b1-93d3-aacc28e545ff@amd.com> Date: Wed, 13 Mar 2024 15:58:43 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/31] net/ena: fix fast mbuf free Content-Language: en-US To: shaibran@amazon.com Cc: dev@dpdk.org, stable@dpdk.org References: <20240312180716.8515-1-shaibran@amazon.com> <20240312180716.8515-6-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240312180716.8515-6-shaibran@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB9125:EE_ X-MS-Office365-Filtering-Correlation-Id: 78eaf65c-5f25-4b78-a7d7-08dc437675eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +aX1f0Cz4u3EsJ7Vy6sOGs4f/WDUB01b9Nf2gS7TAkmLJkmPWynWy7Y70FFva093W8cYNAxnDEZ7w5GTIRkFG76s2WaSWuI30Z7YNbxG79abBD7Qj7/coxxh8xY8hQeJkcCiH3gbB2PKkhMmyhCl+wWeWbcgodz6oXIwUt+hJl7Vum+rQLLBYxCFh/PhLIlK7+W+XnEBGXMGs8EemBD8zt7SI/jvHGb9hTcmamxGza7uJbp4O376TintLfLYtVv3I50fnHckL68bDoNTx6jwjg0qBYds24Hf7A694shb1Cbmox+zvDkMdTbepTMkhzmZK3wVflC1qcxt4wwoiij9lM9t8f6DoLGG+iOKFVlaYcODdR7pJeThAqBAKFMgSUBGtNK21HSgZQLu4DluO7FAC6G1+ZCf6a0s8Zh4KMeMP4Kpg0TnQheYKTSCjKkJewVYH4C9cIFTF7Jo15t3GdXl6QM+7aoXNFQ7GuLko5UcvFKZsnTMf5vjaNlPML090SJHmON9/BZXkUiBJK5iq8YPiftcaJqXh+ALFmLGhn4nlz8IcqnHDwFeXtdc5jgRf5ZHUoWrgI/UZe2/AVqEZilZQHso3fzy54OU64HkaMzpXwwMDuJYMvTo8VCEt43b1e0esxe3RDSE1rLZ8eA/lU4ee+fWX3LhYkDvPllRp+ZzB+I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXkrell0RzhYVU1kODA1bWxUWktnWGlXUE1VcXJCTldCYldleklZMDJocEtr?= =?utf-8?B?eklwYVZRT2ptNFBpNjFMdzlZS0FKM2U4anpCSHhHbkhxRG10em5qaTFKdFBL?= =?utf-8?B?b1ZuQ2JzQ3NJbFdWT0U0TnpCRXhGU2FOM3FaOGFlK1VPV1IxamdyUisxWTVh?= =?utf-8?B?aldnMTBmdDcveVR1S0pFZ3NvK3pROWJvMThsTkU5QWFLendodm9FRmRmaXpp?= =?utf-8?B?OEJUT0VNaDdjWEtZQy9UK3Q1MUU5T2VsckpjTEYvS2xqNGNobEZRcCt1NWhK?= =?utf-8?B?RWtscVU2akxTcDN6YUJmaTc2YWlidklJR1hzZkxBcEMxRzRxK3RXbW9KSkhv?= =?utf-8?B?TlI3NXdoVDNnTGh2UTE0a2pyS2UwWUF3dWhyMGEyRWdHNitJN0hWQ3NmVHBw?= =?utf-8?B?eUFSWXRZa1Vqb1RLOExMSE1TNEo0K050Nnl2VXU4cXNka01XQ045ay9tS0J1?= =?utf-8?B?Ujc3NC9mZ1ZtdnlxUEtidjRsSFJROVovZnZUWHNhQmluYjNPb2ZRekNvdWZt?= =?utf-8?B?YStWT09Wd05qWFJRRmNMbjd6ZVVRSC9Xd1FSM0d3bGd1MWk1TVRLNWZyN3Jn?= =?utf-8?B?MDc5c0VPekg1NDdVSGhxMkx6a2ZLN0IvUzR2TU1LeHVNUGs4U0Mybk5saVl4?= =?utf-8?B?aUFJQlVzSnBtdUhqUXA3LzZKMUwvNWR0bVhIcVVlTEZNSWVDdGdjZkcwY3A0?= =?utf-8?B?UjkrZGhSUXVkVE1DbzN1RmlRV2RnWEh0c0hGVnVVa3dweDhDTHNFZkJBdGVM?= =?utf-8?B?ZGZwenFRbGRSbC8vdHE2WjYxTDlnbmhxNUd6MXdIdFAzUi9UN0tWUmNFOVdE?= =?utf-8?B?N2lxQ3hKNFNqVERZa3lnbUMwdmRFdEVBVWxITXpLV3JMbkZ3bEpCL05PSWZh?= =?utf-8?B?THlCWnA5VUtJdUVSZVZpbXNtdFV5YzF5TEl3cU1KMjBQaGQxcDQzVHZiYjQ0?= =?utf-8?B?dmp4eGRkOTc0WFY0ODBIRVIzU3M3bDZKR2tmTGg3ZnhCc3RnVUk0c3pMdUU3?= =?utf-8?B?c3hFTXErWmZFYnlYeDY4OGRXc0dKYnVwd2VKa3BUVVU2OHU0MVBwZlpMOFdv?= =?utf-8?B?VmdjTzZNTGF1TlZ4NHdzRXQ2SkxqOXRYMGcrUEpiaEJaQ1VYV1pIcjFWSUlv?= =?utf-8?B?NkRFWm8wRi9mWEhvZGQySEl5bXBvQmgrZndQOERJQnBUb1hNTFFDVGxiRFEy?= =?utf-8?B?MnJoK0IvWVkrOVRvNWYzWTFHaGVjbDE2RW8rd0V3SzEraUZtU3hZNVhaUW1y?= =?utf-8?B?T21HaFRNb2xRbHBTcGpxNWljSWFqUllLVy9KUnVmbW1pRC8zdHFrTU50Z09J?= =?utf-8?B?c0h4c1ZnNTlwUExiVGpsbzF1YnRmdGpDekJYaWxwZ1BMMlZNOGQxa05KUHcx?= =?utf-8?B?L21TTFhBR0dBZ29vNCt3U3dNbENIK1NMU0RKN1J3Kyt0SW5jcWNSMHNtS0FJ?= =?utf-8?B?RmhNSGt0VTNCS3dCUjJBRm9aZ2tnOC94R1JUeGhNaWRhQ053eGZwTzNvQWpu?= =?utf-8?B?eHFlM280cXNuY1NPN0FTOWRQZ3lkQW1JMXh1WlFQMTU4dmFmYlQyaUdWdVFF?= =?utf-8?B?djVFVTNmU1J6WGlzNEpKQi91RUM4OHdYLzNGT1VmTlV1bjBucVFkdFluZHho?= =?utf-8?B?NHVua0tZM0tZRTNiRjFpeCtZTm4xbzFCWnIxMFhIQ3ZySE5aREhmQmpYQ2Vw?= =?utf-8?B?Y01IQ256MVdEUXNpMk8rOUxrYzhRWWFsZUJxSGhBeGhvMzZMTXZ4aFAxOUNE?= =?utf-8?B?MHd6UHhYZmoxZEF5TThPY0FRbUluaWRsYURFK3FCT1FTNXRFRGwvQWd4RjEy?= =?utf-8?B?MEZFQ28wOEsxeHZIV1VJRTJ5Mk1KcEU1OGc4TDJaL3dBcnRzZEhKblVvNzlj?= =?utf-8?B?SXdlR1VpWmgyZE5pSENrandacGZkd1FaVGduZ3hDeVdpbXNyZXVtcEdQOTNu?= =?utf-8?B?ano4RjErTnhwMmU1K1NVaEFlcmZLMUpRTERjUFMzNW5aMDdIWVNRRVh4UUZr?= =?utf-8?B?RUN1UG9zTlFPOVFTT0l4dDQrN2xCUUcvc3I5WUp3Q3orQitNS1RMbU5Yd3Ar?= =?utf-8?B?b1RGQzl3d3J5Y09SUDlrcWs1bTVKQ1YwUFk0YXoxWlYwZGNBa3piNlU1eEg5?= =?utf-8?Q?fT/ntdWoxI5gc/Iq8+gdQjc6f?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78eaf65c-5f25-4b78-a7d7-08dc437675eb X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 15:58:44.5410 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mfDXsMMRHDsrBO/dEHQ8n943teX/XebplwgZ7RUyABYO9NCyM9LZG0tzmuVtBUFp X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9125 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/12/2024 6:06 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > In case the application enables fast mbuf release optimization, > the driver releases 256 TX mbufs in bulk upon reaching the > TX free threshold. > The existing implementation utilizes rte_mempool_put_bulk for bulk > freeing TXs, which exclusively supports direct mbufs. > In case the application transmits indirect bufs, the driver must > also decrement the mbuf reference count and unlink the mbuf segment. > For such case, the driver should employ rte_pktmbuf_free_bulk. > > Fixes: c339f53823f3 ("net/ena: support fast mbuf free") > Cc: stable@dpdk.org > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > Dropped release notes update while merging, as user impact of the change is low, or no more than fixing a defect.