From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D888A3201 for ; Mon, 21 Oct 2019 04:38:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69D94F3E; Mon, 21 Oct 2019 04:38:49 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3A42D2AB for ; Mon, 21 Oct 2019 04:38:47 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2019 19:38:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,321,1566889200"; d="scan'208";a="209212188" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 20 Oct 2019 19:38:45 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 19:38:45 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 19:38:45 -0700 Received: from shsmsx106.ccr.corp.intel.com ([169.254.10.119]) by SHSMSX152.ccr.corp.intel.com ([10.239.6.52]) with mapi id 14.03.0439.000; Mon, 21 Oct 2019 10:38:44 +0800 From: "Xu, Ting" To: Olivier Matz CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" , "Ye, Xiaolong" , "Yang, Qiming" , "Mcnamara, John" , "Kovacevic, Marko" , "Zhang, Qi Z" Thread-Topic: [PATCH v1 1/2] lib/mbuf: add GTP tunnel type flag Thread-Index: AQHVhY9meA6y77rUskC1d+SUE64n2adkTt6g Date: Mon, 21 Oct 2019 02:38:43 +0000 Message-ID: <8C448DD570D7CD459EACDF44AB3869D701926617@SHSMSX106.ccr.corp.intel.com> References: <9f054f84c5ae5cb871d86ace17f7c3ca658fb890.1568968178.git.ting.xu@intel.com> <20191018083811.mwau5g3shqgz66bw@platinum> In-Reply-To: <20191018083811.mwau5g3shqgz66bw@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/mbuf: add GTP tunnel type flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Olivier, Thanks for advice. I will modify codes according to your comments. As for the packet header, I define a simplified GTP header in patch: app/te= stpmd: enable GTP header parse and Tx checksum offload, in order to help fo= rward GTP packet in testpmd. I just moved some codes to rte_ether.h according to Ferruh's comments in th= at patch, which may need your review as well. Thanks. -----Original Message----- From: Olivier Matz [mailto:olivier.matz@6wind.com]=20 Sent: Friday, October 18, 2019 4:38 PM To: Xu, Ting Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing ; Ye, Xiaolong ; Yang, Qiming ; Mcnamara, John ; Kovacevic, Mark= o ; Zhang, Qi Z Subject: Re: [PATCH v1 1/2] lib/mbuf: add GTP tunnel type flag Hi, On Fri, Sep 20, 2019 at 08:36:23AM +0000, Ting Xu wrote: > Add GTP tunnel type flag in mbuf for future use in GTP checksum=20 > offload. >=20 > Signed-off-by: Ting Xu > --- > lib/librte_mbuf/rte_mbuf.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h=20 > index 98225ec80..0a5d67d9a 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -251,6 +251,8 @@ extern "C" { > /** TX packet with MPLS-in-UDP RFC 7510 header. */ #define=20 > PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45) #define=20 > PKT_TX_TUNNEL_VXLAN_GPE (0x6ULL << 45) > +#define PKT_TX_TUNNEL_GTP (0x7ULL << 45) > + > /** > * Generic IP encapsulated tunnel type, used for TSO and checksum offloa= d. > * It can be used for tunnels which are not standards or listed above. Some updates are missing, for instance in rte_get_tx_ol_flag_name(). Please look what was done for other flags. Please, can you describe in more details what is expected in the packet hea= der? Thanks, Olivier