From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 98AADAD7B
 for <dev@dpdk.org>; Tue,  3 Feb 2015 11:03:20 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga103.fm.intel.com with ESMTP; 03 Feb 2015 01:56:45 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,511,1418112000"; d="scan'208";a="680132478"
Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28])
 by orsmga002.jf.intel.com with ESMTP; 03 Feb 2015 02:03:18 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.64]) by
 irsmsx105.ger.corp.intel.com ([169.254.7.81]) with mapi id 14.03.0195.001;
 Tue, 3 Feb 2015 10:03:16 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v6] testpmd: Add port hotplug support
Thread-Index: AQHQP1FHCdCFKPt2AUeHWwDzOcl0EZzesbVQ
Date: Tue, 3 Feb 2015 10:03:15 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C2049DCF56@IRSMSX108.ger.corp.intel.com>
References: <1421664027-17971-9-git-send-email-mukawa@igel.co.jp>
 <1422763322-13742-1-git-send-email-mukawa@igel.co.jp>
 <1422763322-13742-16-git-send-email-mukawa@igel.co.jp>
 <8CEF83825BEC744B83065625E567D7C2049DCAD2@IRSMSX108.ger.corp.intel.com>
 <54D0251C.2050407@igel.co.jp>
In-Reply-To: <54D0251C.2050407@igel.co.jp>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6] testpmd: Add port hotplug support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Feb 2015 10:03:21 -0000


> >> +.. code-block:: console
> >> +
> >> +    testpmd> port attach 0000:02:00.0
> >> +    Attaching a new port...
> >> +    ... snip ...
> >> +    Port 0 is attached. Now total ports is 1
> >> +    Done
> >> +port detach
> >> +~~~~~~~~~~~
> >> +
> >> +Detach a specific port.
> >> +
> >> +Before detaching a port, the port should be closed.
> >> +Also to remove a pci device completely from the system, first detach =
the port from testpmd.
> >> +Then the device should be moved under kernel management.
> >> +Finally the device can be remove using kernel pci hotplug functionali=
ty.

Hi Tetsuya,
Reword "remove" to "removed"

> >> +On the other hand, to remove a port created by virtual device, above =
steps are not needed.
 Reword " created by virtual device" to "created by a virtual device"

> >
> >> +
> >> +port detach (port_id)
> >> +
> >> +For example, to detach a port 0.
> >> +
> >> +.. code-block:: console
> >> +
> >> +    testpmd> port detach 0
> >> +    Detaching a port...
> >> +    ... snip ...
> >> +    Done
> >> +
> >>  port start
> >>  ~~~~~~~~~~
> >>
> >> --
> >> 1.9.1
> > Regards,
> >
> > Bernard.
> >