From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id B81C1B5F3
 for <dev@dpdk.org>; Mon, 16 Feb 2015 17:18:08 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 16 Feb 2015 08:12:40 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,588,1418112000"; d="scan'208";a="652862175"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by orsmga001.jf.intel.com with ESMTP; 16 Feb 2015 08:17:55 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.236]) with mapi id 14.03.0195.001;
 Mon, 16 Feb 2015 16:17:54 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v8 03/14] eal/pci,ethdev: Remove assumption that port
 will not be detached
Thread-Index: AQHQSZ8kYuuY0vaEHEudJXglCDQwh5zzdI7g
Date: Mon, 16 Feb 2015 16:17:53 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C2049E80D7@IRSMSX108.ger.corp.intel.com>
References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp>
 <1424060073-23484-4-git-send-email-mukawa@igel.co.jp>
In-Reply-To: <1424060073-23484-4-git-send-email-mukawa@igel.co.jp>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v8 03/14] eal/pci,
 ethdev: Remove assumption that port will not be detached
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 16:18:09 -0000

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Monday, February 16, 2015 4:14 AM
> To: dev@dpdk.org
> Cc: Qiu, Michael; Iremonger, Bernard; Tetsuya Mukawa
> Subject: [PATCH v8 03/14] eal/pci,ethdev: Remove assumption that port wil=
l not be detached
>=20
> To remove assumption, do like followings.
>=20
> This patch adds "RTE_PCI_DRV_DETACHABLE" to drv_flags of rte_pci_driver s=
tructure. The flags
> indicate the driver can detach devices at runtime.
> Also, remove assumption that port will not be detached.
>=20
> To remove the assumption.
> - Add 'attached' member to rte_eth_dev structure.
>   This member is used for indicating the port is attached, or not.
> - Add rte_eth_dev_allocate_new_port().
>   This function is used for allocating new port.
>=20
> v8:
> - NONE_TRACE is changed to NO_TRACE.
>   (Thanks to Iremonger, Bernard)
> v5:
> - Change parameters of rte_eth_dev_validate_port() to cleanup code.
> v4:
> - Use braces with 'for' loop.
> - Fix indent of 'if' statement.
>=20
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>