From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 25E53B637
 for <dev@dpdk.org>; Mon, 16 Feb 2015 17:30:06 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga101.jf.intel.com with ESMTP; 16 Feb 2015 08:30:06 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,588,1418112000"; d="scan'208";a="528243543"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by orsmga003.jf.intel.com with ESMTP; 16 Feb 2015 08:21:35 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0195.001;
 Mon, 16 Feb 2015 16:30:04 +0000
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach()
 functions
Thread-Index: AQHQSZ8qm36K0SeD2EeP2YwXDyxwR5zzd/RQ
Date: Mon, 16 Feb 2015 16:30:03 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C2049E8183@IRSMSX108.ger.corp.intel.com>
References: <1423470639-15744-2-git-send-email-mukawa@igel.co.jp>
 <1424060073-23484-13-git-send-email-mukawa@igel.co.jp>
In-Reply-To: <1424060073-23484-13-git-send-email-mukawa@igel.co.jp>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v8 12/14] eal/pci: Add
 rte_eal_dev_attach/detach() functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 16:30:07 -0000

> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp]
> Sent: Monday, February 16, 2015 4:15 AM
> To: dev@dpdk.org
> Cc: Qiu, Michael; Iremonger, Bernard; Tetsuya Mukawa
> Subject: [PATCH v8 12/14] eal/pci: Add rte_eal_dev_attach/detach() functi=
ons
>=20
> These functions are used for attaching or detaching a port.
> When rte_eal_dev_attach() is called, the function tries to realize the de=
vice name as pci address. If
> this is done successfully,
> rte_eal_dev_attach() will attach physical device port. If not, attaches v=
irtual devive port.
> When rte_eal_dev_detach() is called, the function gets the device type of=
 this port to know whether
> the port is come from physical or virtual.
> And then specific detaching function will be called.
>=20
> v8:
> - Add missing symbol in version map.
>   (Thanks to Qiu, Michael and Iremonger, Bernard)
> v7:
> - Fix typo of warning messages.
>   (Thanks to Qiu, Michael)
> v5:
> - Change function names like below.
>   rte_eal_dev_find_and_invoke() to rte_eal_vdev_find_and_invoke().
>   rte_eal_dev_invoke() to rte_eal_vdev_invoke().
> - Add code to handle a return value of rte_eal_devargs_remove().
> - Fix pci address format in rte_eal_dev_detach().
> v4:
> - Fix comment.
> - Add error checking.
> - Fix indent of 'if' statement.
> - Change function name.
>=20
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>