From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id EB23BC56E
 for <dev@dpdk.org>; Thu, 25 Jun 2015 11:04:41 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 25 Jun 2015 02:04:26 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,675,1427785200"; d="scan'208";a="514008991"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by FMSMGA003.fm.intel.com with ESMTP; 25 Jun 2015 02:04:24 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.171]) with mapi id 14.03.0224.002;
 Thu, 25 Jun 2015 10:04:24 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v6] e1000: igb and em1000 PCI Port Hotplug changes
Thread-Index: AQHQrNhyvHmhT1qFz0ui1I48BgciRJ28hKQAgABgn9A=
Date: Thu, 25 Jun 2015 09:04:23 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C204A40B47@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1434969865-10527-1-git-send-email-bernard.iremonger@intel.com>
 <F35DEAC7BCE34641BA9FAC6BCA4A12E70A886CE4@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A886CE4@SHSMSX104.ccr.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6] e1000: igb and em1000 PCI Port Hotplug
	changes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2015 09:04:42 -0000


> -----Original Message-----
> From: Zhang, Helin
> Sent: Thursday, June 25, 2015 3:34 AM
> To: Iremonger, Bernard; dev@dpdk.org
> Subject: RE: [PATCH v6] e1000: igb and em1000 PCI Port Hotplug changes
>=20
> Hi Bernard
>=20
> > -----Original Message-----
> > From: Iremonger, Bernard
> > Sent: Monday, June 22, 2015 6:44 PM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin; Iremonger, Bernard
> > Subject: [PATCH v6] e1000: igb and em1000 PCI Port Hotplug changes
> >
> > This patch depends on the Port Hotplug Framework.
> > It implements the eth_dev_uninit functions for rte_em_pmd,
> rte_igb_pmd
> > and rte_igbvf_pmd.
> Would it be better to split this patch into smaller patches in a patch se=
t as you
> did for i40e hotplug?
>=20
> Regards,
> Helin

Hi Helin,
I don't think there is anything to be gained by splitting up this patch.
All the changes are hotplug related.

In the case of the i40e, there are five patches which are unrelated to hotp=
lug=20
which resolve issues encountered during development.
=20
Regards,

Bernard

<snip>