From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 7E110A10
 for <dev@dpdk.org>; Wed, 15 Jul 2015 10:02:15 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 15 Jul 2015 01:02:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,477,1432623600"; d="scan'208";a="747592842"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by fmsmga001.fm.intel.com with ESMTP; 15 Jul 2015 01:01:51 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.121]) with mapi id 14.03.0224.002;
 Wed, 15 Jul 2015 09:01:50 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [PATCH 4/5] virtio: free queue memory in virtio_dev_close()
Thread-Index: AQHQvjaW136Y3FNdc0SUiCYaM22MYp3bwGswgABrjoA=
Date: Wed, 15 Jul 2015 08:01:50 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C204A48FD6@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1436879459-18400-1-git-send-email-bernard.iremonger@intel.com>
 <1436879459-18400-5-git-send-email-bernard.iremonger@intel.com>
 <F52918179C57134FAEC9EA62FA2F962511BFDDBC@shsmsx102.ccr.corp.intel.com>
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511BFDDBC@shsmsx102.ccr.corp.intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: free queue memory in
	virtio_dev_close()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 08:02:16 -0000

Hi  Ouyang,

<snip>

> > --- a/drivers/net/virtio/virtio_ethdev.c
> > +++ b/drivers/net/virtio/virtio_ethdev.c
> > @@ -438,6 +438,24 @@ virtio_dev_cq_queue_setup(struct rte_eth_dev
> > *dev, uint16_t vtpci_queue_idx,  }
> >
> >  static void
> > +virtio_free_queues(struct rte_eth_dev *dev) {
> > +	unsigned int i;
> > +
> > +	for (i =3D 0; i < dev->data->nb_rx_queues; i++) {
> > +		virtio_dev_rx_queue_release(dev->data->rx_queues[i]);
> > +		dev->data->rx_queues[i] =3D NULL;
> > +	}
> > +	dev->data->nb_rx_queues =3D 0;
> > +
> > +	for (i =3D 0; i < dev->data->nb_tx_queues; i++) {
> > +		virtio_dev_tx_queue_release(dev->data->tx_queues[i]);
> > +		dev->data->tx_queues[i] =3D NULL;
> > +	}
> > +	dev->data->nb_tx_queues =3D 0;
> > +}
> > +
> > +static void
> >  virtio_dev_close(struct rte_eth_dev *dev)  {
> >  	struct virtio_hw *hw =3D dev->data->dev_private; @@ -451,6 +469,7
> @@
> > virtio_dev_close(struct rte_eth_dev *dev)
> >  	vtpci_reset(hw);
> >  	hw->started =3D 0;
> >  	virtio_dev_free_mbufs(dev);
> > +	virtio_free_queues(dev);
>=20
> Validate it with vhost sample or not for this change?

I have tested this change with testpmd on a Fedora VM.

Regards,

Bernard.

>=20
> >  }
> >
> >  static void
> > --
> > 1.9.1