From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id B1080C32A
 for <dev@dpdk.org>; Wed, 15 Jul 2015 10:27:21 +0200 (CEST)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga102.jf.intel.com with ESMTP; 15 Jul 2015 01:27:22 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,477,1432623600"; d="scan'208";a="764775565"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by orsmga002.jf.intel.com with ESMTP; 15 Jul 2015 01:27:21 -0700
Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by
 IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Wed, 15 Jul 2015 09:27:19 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by
 irsmsx111.ger.corp.intel.com ([169.254.2.232]) with mapi id 14.03.0224.002;
 Wed, 15 Jul 2015 09:27:19 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [PATCH 4/5] virtio: free queue memory in virtio_dev_close()
Thread-Index: AQHQvmLY136Y3FNdc0SUiCYaM22MYp3cMnuw
Date: Wed, 15 Jul 2015 08:27:18 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C204A49031@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1436879459-18400-1-git-send-email-bernard.iremonger@intel.com>
 <1436879459-18400-5-git-send-email-bernard.iremonger@intel.com>
 <20150714112810.1319eddd@urahara>
In-Reply-To: <20150714112810.1319eddd@urahara>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 4/5] virtio: free queue memory in
	virtio_dev_close()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 08:27:22 -0000

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Tuesday, July 14, 2015 7:28 PM
> To: Iremonger, Bernard
> Cc: dev@dpdk.org; Ouyang, Changchun
> Subject: Re: [PATCH 4/5] virtio: free queue memory in virtio_dev_close()
>=20
> On Tue, 14 Jul 2015 14:10:58 +0100
> Bernard Iremonger <bernard.iremonger@intel.com> wrote:
>=20
> >  static void
> > +virtio_free_queues(struct rte_eth_dev *dev) {
> > +	unsigned int i;
> > +
> > +	for (i =3D 0; i < dev->data->nb_rx_queues; i++) {
> > +		virtio_dev_rx_queue_release(dev->data->rx_queues[i]);
> > +		dev->data->rx_queues[i] =3D NULL;
> > +	}
> > +	dev->data->nb_rx_queues =3D 0;
> > +
> > +	for (i =3D 0; i < dev->data->nb_tx_queues; i++) {
> > +		virtio_dev_tx_queue_release(dev->data->tx_queues[i]);
> > +		dev->data->tx_queues[i] =3D NULL;
> > +	}
> > +	dev->data->nb_tx_queues =3D 0;
> > +}
> > +
>=20
> Where does command queue get freed?

The command queue is set up in the eth_virtio_dev_init() function and  free=
d in the eth_virtio_dev_uninit() function.

Regards,

Bernard.