From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 548FDC4F4
 for <dev@dpdk.org>; Mon, 27 Jul 2015 10:31:58 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga103.fm.intel.com with ESMTP; 27 Jul 2015 01:31:58 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,552,1432623600"; d="scan'208";a="530712834"
Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99])
 by FMSMGA003.fm.intel.com with ESMTP; 27 Jul 2015 01:31:56 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.22]) by
 IRSMSX107.ger.corp.intel.com ([169.254.10.245]) with mapi id 14.03.0224.002;
 Mon, 27 Jul 2015 09:31:55 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v6 3/3] bonding: free queue memory in stop
 function
Thread-Index: AQHQyBbdfHTSOhmexkGeApB12V5fe53u+2RQ
Date: Mon, 27 Jul 2015 08:31:55 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F34510@IRSMSX108.ger.corp.intel.com>
References: <1437491784-26676-4-git-send-email-bernard.iremonger@intel.com>
 <4617847.gsgatBVqCY@xps13>
In-Reply-To: <4617847.gsgatBVqCY@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v6 3/3] bonding: free queue memory in stop
 function
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2015 08:31:58 -0000


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, July 27, 2015 3:48 AM
> To: Iremonger, Bernard
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v6 3/3] bonding: free queue memory in stop
> function
>=20
> 2015-07-21 16:16, Bernard Iremonger:
> > add function bond_ethdev_free_queues() and call from the
> bond_ethdev_stop() function.
>=20
> Other drivers free their queues when closing.
> Why is it done in stop() for bonding?

Hi Thomas,

The close() function  is empty in bonding so I decided to free the queues i=
n the stop() function which is implemented.
The stop() function is called before the close() function, so the effect is=
 the same.=20
It would be better to free the queues in the close() function, I will move =
it there.

Regards,

Bernard.
 =20