From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 61F16C52C for ; Mon, 27 Jul 2015 11:42:18 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 27 Jul 2015 02:42:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,552,1432623600"; d="scan'208";a="530743137" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by FMSMGA003.fm.intel.com with ESMTP; 27 Jul 2015 02:42:15 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.22]) by IRSMSX102.ger.corp.intel.com ([169.254.2.158]) with mapi id 14.03.0224.002; Mon, 27 Jul 2015 10:42:14 +0100 From: "Iremonger, Bernard" To: Stephen Hemminger , "harish.patil@qlogic.com" Thread-Topic: [dpdk-dev] [PATCH v5 4/4] bnx2x: enable PMD build Thread-Index: AQHQwwnocftFwsdN8kac5TpWiYdRRZ3vGl2Q Date: Mon, 27 Jul 2015 09:42:14 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219F345F5@IRSMSX108.ger.corp.intel.com> References: <1437410000-15907-1-git-send-email-stephen@networkplumber.org> <1437410000-15907-5-git-send-email-stephen@networkplumber.org> In-Reply-To: <1437410000-15907-5-git-send-email-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 4/4] bnx2x: enable PMD build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 09:42:20 -0000 Hi Stephen, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen > Hemminger > Sent: Monday, July 20, 2015 5:33 PM > To: harish.patil@qlogic.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v5 4/4] bnx2x: enable PMD build >=20 > This is build infrastructure changes for bnx2x driver. > - enable BNX2X poll mode driver in default config. > - add it to mk > - put entry in MAINTAINERS >=20 > Note: I intentionally did not list myself as maintainer of this driver. Q= Logic has > discussed taking over as maintainer. >=20 > Signed-off-by: Stephen Hemminger >=20 > --- > v4 - Add PCI id's for 57840 > --- > MAINTAINERS | 3 ++ > config/common_linuxapp | 10 ++++ > drivers/net/Makefile | 1 + > drivers/net/bnx2x/Makefile | 28 ++++++++++++ > lib/librte_eal/common/include/rte_pci_dev_ids.h | 61 > +++++++++++++++++++++++++ > mk/rte.app.mk | 2 + > 6 files changed, 105 insertions(+) > create mode 100644 drivers/net/bnx2x/Makefile >=20 > diff --git a/MAINTAINERS b/MAINTAINERS > index 6531900..b6a82ad 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -277,6 +277,9 @@ M: John McNamara > F: drivers/net/pcap/ > F: doc/guides/nics/pcap_ring.rst >=20 > +Qlogic/Broadcom bnx2x > +F: drivers/net/bnx2x/ > + > Ring PMD > M: Bruce Richardson > F: drivers/net/ring/ > diff --git a/config/common_linuxapp b/config/common_linuxapp index > 579a5d7..a8a392e 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -229,6 +229,16 @@ CONFIG_RTE_LIBRTE_ENIC_PMD=3Dy > CONFIG_RTE_LIBRTE_ENIC_DEBUG=3Dn >=20 > # > +# Compile burst-oriented Broadcom PMD driver # > +CONFIG_RTE_LIBRTE_BNX2X_PMD=3Dy > CONFIG_RTE_LIBRTE_BNX2X_DEBUG_INIT=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_DEBUG=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_MF_SUPPORT=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_TX=3Dn > +CONFIG_RTE_LIBRTE_BNX2X_DEBUG_RX=3Dn > + > +# > # Compile burst-oriented VIRTIO PMD driver # > CONFIG_RTE_LIBRTE_VIRTIO_PMD=3Dy diff --git a/drivers/net/Makefile > b/drivers/net/Makefile index 6171430..6d519b6 100644 > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -47,6 +47,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_PMD_RING) +=3D ring > DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) +=3D virtio > DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) +=3D vmxnet3 > DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) +=3D xenvirt > +DIRS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x >=20 > include $(RTE_SDK)/mk/rte.sharelib.mk > include $(RTE_SDK)/mk/rte.subdir.mk > diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile new > file mode 100644 index 0000000..0de5db9 > --- /dev/null > +++ b/drivers/net/bnx2x/Makefile > @@ -0,0 +1,28 @@ > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB =3D librte_pmd_bnx2x.a > + > +CFLAGS +=3D -O3 -g > +CFLAGS +=3D $(WERROR_FLAGS) > +CFLAGS +=3D -DZLIB_CONST > + > +# > +# all source are stored in SRCS-y > +# > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x_rxtx.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x_stats.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x_ethdev.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D ecore_sp.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D elink.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D bnx2x_vfpf.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNX2X_DEBUG) +=3D debug.c > + > +# this lib depends upon: > +DEPDIRS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D lib/librte_eal > +lib/librte_ether lib/librte_hash > +DEPDIRS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D lib/librte_mempool > +lib/librte_mbuf > + > +include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/lib/librte_eal/common/include/rte_pci_dev_ids.h > b/lib/librte_eal/common/include/rte_pci_dev_ids.h > index 084d182..badb719 100644 > --- a/lib/librte_eal/common/include/rte_pci_dev_ids.h > +++ b/lib/librte_eal/common/include/rte_pci_dev_ids.h > @@ -144,6 +144,14 @@ > #define RTE_PCI_DEV_ID_DECL_ENIC(vend, dev) #endif >=20 > +#ifndef RTE_PCI_DEV_ID_DECL_BNX2X > +#define RTE_PCI_DEV_ID_DECL_BNX2X(vend, dev) #endif > + > +#ifndef RTE_PCI_DEV_ID_DECL_BNX2XVF > +#define RTE_PCI_DEV_ID_DECL_BNX2XVF(vend, dev) #endif > + > #ifndef PCI_VENDOR_ID_INTEL > /** Vendor ID used by Intel devices */ > #define PCI_VENDOR_ID_INTEL 0x8086 > @@ -164,6 +172,11 @@ > #define PCI_VENDOR_ID_CISCO 0x1137 > #endif >=20 > +#ifndef PCI_VENDOR_ID_BROADCOM > +/** Vendor ID used by Broadcom devices */ #define > +PCI_VENDOR_ID_BROADCOM 0x14E4 #endif > + > /******************** Physical EM devices from e1000_hw.h > ********************/ >=20 > #define E1000_DEV_ID_82542 0x1000 > @@ -566,6 +579,52 @@ > RTE_PCI_DEV_ID_DECL_FM10KVF(PCI_VENDOR_ID_INTEL, > FM10K_DEV_ID_VF) RTE_PCI_DEV_ID_DECL_ENIC(PCI_VENDOR_ID_CISCO, > PCI_DEVICE_ID_CISCO_VIC_ENET) > RTE_PCI_DEV_ID_DECL_ENIC(PCI_VENDOR_ID_CISCO, > PCI_DEVICE_ID_CISCO_VIC_ENET_VF) >=20 > +/****************** QLogic devices ******************/ > + > +/* Broadcom/QLogic BNX2X */ > +#define BNX2X_DEV_ID_57710 0x164e > +#define BNX2X_DEV_ID_57711 0x164f > +#define BNX2X_DEV_ID_57711E 0x1650 > +#define BNX2X_DEV_ID_57712 0x1662 > +#define BNX2X_DEV_ID_57712_MF 0x1663 > +#define BNX2X_DEV_ID_57712_VF 0x166f > +#define BNX2X_DEV_ID_57713 0x1651 > +#define BNX2X_DEV_ID_57713E 0x1652 > +#define BNX2X_DEV_ID_57800 0x168a > +#define BNX2X_DEV_ID_57800_MF 0x16a5 > +#define BNX2X_DEV_ID_57800_VF 0x16a9 > +#define BNX2X_DEV_ID_57810 0x168e > +#define BNX2X_DEV_ID_57810_MF 0x16ae > +#define BNX2X_DEV_ID_57810_VF 0x16af > +#define BNX2X_DEV_ID_57811 0x163d > +#define BNX2X_DEV_ID_57811_MF 0x163e > +#define BNX2X_DEV_ID_57811_VF 0x163f > + > +#define BNX2X_DEV_ID_57840_OBS 0x168d > +#define BNX2X_DEV_ID_57840_OBS_MF 0x16ab > +#define BNX2X_DEV_ID_57840_4_10 0x16a1 > +#define BNX2X_DEV_ID_57840_2_20 0x16a2 > +#define BNX2X_DEV_ID_57840_MF 0x16a4 > +#define BNX2X_DEV_ID_57840_VF 0x16ad > + > + > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > BNX2X_DEV_ID_57800) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57800_VF) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > BNX2X_DEV_ID_57711) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > BNX2X_DEV_ID_57810) > +RTE_PCI_DEV_ID_DECL_BNX2XVF(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57810_VF) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > BNX2X_DEV_ID_57811) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57811_VF) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57840_OBS) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57840_4_10) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57840_2_20) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57840_VF) #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57810_MF) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57811_MF) > +RTE_PCI_DEV_ID_DECL_BNX2X(PCI_VENDOR_ID_BROADCOM, > +BNX2X_DEV_ID_57840_MF) #endif > + > /* > * Undef all RTE_PCI_DEV_ID_DECL_* here. > */ > @@ -578,5 +637,7 @@ > RTE_PCI_DEV_ID_DECL_ENIC(PCI_VENDOR_ID_CISCO, > PCI_DEVICE_ID_CISCO_VIC_ENET_VF) #undef > RTE_PCI_DEV_ID_DECL_I40EVF #undef RTE_PCI_DEV_ID_DECL_VIRTIO > #undef RTE_PCI_DEV_ID_DECL_VMXNET3 > +#undef RTE_PCI_DEV_ID_DECL_BNX2X > +#undef RTE_PCI_DEV_ID_DECL_BNX2XVF > #undef RTE_PCI_DEV_ID_DECL_FM10K > #undef RTE_PCI_DEV_ID_DECL_FM10KVF > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 67bce48..2cc5b5b 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -101,6 +101,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) +=3D - > lfuse > endif >=20 > _LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) +=3D -libverbs > +_LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D -lz >=20 > _LDLIBS-y +=3D --start-group >=20 > @@ -138,6 +139,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) +=3D - > lrte_pmd_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) +=3D -lrte_pmd_pcap > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) +=3D - > lrte_pmd_af_packet > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL) +=3D -lrte_pmd_null > +_LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) +=3D -lrte_pmd_bnx2x >=20 > endif # ! $(CONFIG_RTE_BUILD_SHARED_LIB) >=20 > -- > 2.1.4 Seeing a build error on Linux with build of bnx2x enabled =3D=3D Build drivers/net/bnx2x CC bnx2x.o /root/dpdk_sforge_2/drivers/net/bnx2x/bnx2x.c:50:18: fatal error: zlib.h: N= o such file or directory #include Regards, Bernard. ^