From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 8AA5E568B
 for <dev@dpdk.org>; Wed,  5 Aug 2015 15:39:44 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga103.jf.intel.com with ESMTP; 05 Aug 2015 06:39:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,617,1432623600"; d="scan'208";a="536465786"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by FMSMGA003.fm.intel.com with ESMTP; 05 Aug 2015 06:39:27 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.22]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.131]) with mapi id 14.03.0224.002;
 Wed, 5 Aug 2015 14:39:26 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in
 rte_eth_bond_create()
Thread-Index: AQHQz4EHWlDzLSiWzUi2fHE6yxx4zZ39Y2CQ///z7ACAABHScA==
Date: Wed, 5 Aug 2015 13:39:26 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F36ECA@IRSMSX108.ger.corp.intel.com>
References: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com>
 <1514392.p4W8R5bZo1@xps13>
 <8CEF83825BEC744B83065625E567D7C219F36EA6@IRSMSX108.ger.corp.intel.com>
 <3872346.WHI1RvlFCy@xps13>
In-Reply-To: <3872346.WHI1RvlFCy@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in
 rte_eth_bond_create()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2015 13:39:45 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, August 5, 2015 2:35 PM
> To: Iremonger, Bernard
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/1] bonding: fix error handling in
> rte_eth_bond_create()
>=20
> 2015-08-05 13:19, Iremonger, Bernard:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2015-08-05 13:36, Bernard Iremonger:
> > > > if the name parameter to rte_eth_bond_create() was NULL, there was
> > > > a segmentation fault because eth_dev was also NULL.
> > >
> > > You also add error handling of mac_addrs alloc and release_port().
> > > It deserves to be said in this commit message.
> >
> > Will I send a v3 patch ?
>=20
> My comment was mostly to show which kind of information may be useful.
> Sometimes I write it myself. You are welcome to write it in order I add i=
t or
> you can send a v3.
>=20
> Other note: the function names are avoided in commit titles as they are
> redundant with the title prefix and not so easy to read.
> The title could be
> 	bonding: fix crash on initialization error or, to include other fixes,
> 	bonding: fix device initialization error handling
>=20
> Thanks

I will send a v3.

Regards,

Bernard.