From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D134E91AB for ; Mon, 31 Aug 2015 13:22:07 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 31 Aug 2015 04:22:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,440,1437462000"; d="scan'208";a="794525819" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga002.jf.intel.com with ESMTP; 31 Aug 2015 04:21:48 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.12]) by IRSMSX152.ger.corp.intel.com ([169.254.6.220]) with mapi id 14.03.0224.002; Mon, 31 Aug 2015 12:21:47 +0100 From: "Iremonger, Bernard" To: "Wiles, Keith" , Neil Horman Thread-Topic: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs Thread-Index: AQHQ4PAprrsGaqoMN02VOjrYJZek+Z4hEK2AgAAWb4CAAJsygIAENyCw Date: Mon, 31 Aug 2015 11:21:46 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C219F49405@IRSMSX108.ger.corp.intel.com> References: <1440690041-32391-1-git-send-email-bernard.iremonger@intel.com> <20150827174357.GC8113@tuxdriver.com> <8CEF83825BEC744B83065625E567D7C219F4883E@IRSMSX108.ger.corp.intel.com> <20150828103245.GB3351@hmsreliant.think-freely.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [RFC PATCH 0/6] remove pci driver from vdevs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2015 11:22:08 -0000 Hi Keith, Neil, > >> > On Thu, Aug 27, 2015 at 04:40:35PM +0100, Bernard Iremonger wrote: > >> > > There is a dummy pci driver in the vdev PMD's at present. > >> > > This RFC proposes to remove the pci driver from the vdev PMD's. > >> > > Changes have been made to librte_ether to handle vdevs which do > >> > > not > >> > have a pci driver. > >> > > > >> > > The pdev PMD's should work as before with the changes to > >>librte_ether > >> > > The vdev PMD's which still have a pci driver should work as > >> > > before > >>with the > >> > librte_ether changes. > >> > > > >> > > The following vdev PMD's have had the pci driver removed > >> > > > >> > > bonding PMD > >> > > null PMD > >> > > pcap PMD > >> > > ring PMD > >> > > >> > Any reason there is no patch for the af_packet driver? > >> > > >> > John > >> > >> I have just modified the Intel vdev PMD's. > >> It would be best if the owners of the non Intel vdev's submitted > >>patches for their drivers. > >> > >I disagree. Its ok given that this is an RFC patch I suppose, but if > >you intend to actually propose this change for review, you need to > >modify all affected drivers in a single commit. Asking individual > >driver maintainers to submit patches to not access a struct element > >that is removed in a separate patch will by definition cause FTBFS > >errors. All references to the structure member being removed must also > >be eliminated in the same or a prior commit, preferably the former. >=20 > +1, if you introduce a chance that effects other places in the > code/drivers then you must also make the changes to those parts as well. > It really should not be an option IMO. > > > >Neil < snip > > Regards, > ++Keith > Intel Corporation >=20 >=20 Firstly no struct element has been removed from struct rte_eth_dev {} in th= e eth_dev patch. A dev_flags element has been added to struct rte_eth_dev{} A numa_node element has been added to struct rte_eth_dev_data{}. Unmodified VDEV's and PDEV's will not be aware of these new elements and wi= ll be unaffected by the eth_dev changes. Regards, Bernard.