From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bernard.iremonger@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 613143787
 for <dev@dpdk.org>; Tue, 29 Sep 2015 10:41:18 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by orsmga101.jf.intel.com with ESMTP; 29 Sep 2015 01:41:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,607,1437462000"; d="scan'208";a="570369891"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2015 01:41:16 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.216]) by
 IRSMSX102.ger.corp.intel.com ([169.254.2.160]) with mapi id 14.03.0248.002;
 Tue, 29 Sep 2015 09:41:14 +0100
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Thread-Topic: [dpdk-dev] [PATCH 16/20] cxgbe: copy pci device info to
 eth_dev data
Thread-Index: AQHQ+h7v8OsgTi/1ukyQyFQTKuLZ555TMBUw
Date: Tue, 29 Sep 2015 08:41:14 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C219F62871@IRSMSX108.ger.corp.intel.com>
References: <PATCH>
 <1443445418-18498-1-git-send-email-bernard.iremonger@intel.com>
 <1443445418-18498-17-git-send-email-bernard.iremonger@intel.com>
 <20150928185301.GA12770@scalar.blr.asicdesigners.com>
In-Reply-To: <20150928185301.GA12770@scalar.blr.asicdesigners.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>, Felix Marti <felix@chelsio.com>,
 Kumar Sanghvi <kumaras@chelsio.com>,
 Nirranjan Kirubaharan <nirranjan@chelsio.com>
Subject: Re: [dpdk-dev] [PATCH 16/20] cxgbe: copy pci device info to eth_dev
 data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Sep 2015 08:41:18 -0000

Hi Rahul,

<snip>

> Out of curiosity, do you really need to add Intel copyright on top of sou=
rce
> file for a 3 line change in source file? I see that you have done the sam=
e for
> cisco, mellanox, broadcom and other vendors as well.
>=20
> I don't claim to understand Copyright very well. However, I have seen in
> other
> open community projects like kernel.org where people many times do
> significant
> change in someone else's code and yet, don't normally add their own
> copyright
> to source files.
>=20
> Care to explain what is the intention here with addition of Intel Copyrig=
ht
> statement?
>=20
> Thanks,
> Rahul

I thought it was necessary to add the Intel Copyright, because I had modifi=
ed the code.
I will remove it in the next revision of the patchset.

Regards,

Bernard.